fish integration broken in focal

[Niklas Sombert]

After upgrading snapd from 2.51.1+20.04ubuntu2 to 2.54.2+20.04 I get the following stacktrace upon each start of the fish shell:

/usr/share/fish/vendor_conf.d/snapd.fish (line 3):
fish_add_path -aP $snap_bin_path
^
from sourcing file /usr/share/fish/vendor_conf.d/snapd.fish
        called on line 294 of file /usr/share/fish/config.fish
from sourcing file /usr/share/fish/config.fish
        called during startup

I guess the fish integration was written for a newer version than the one I have. fish_add_path does not seem to exist here.

The shell seems to work fine nevertheless, but it is still annoying.

$ lsb_release -rd
Description: Ubuntu 20.04.3 LTS
Release: 20.04
$ apt-cache policy snapd
snapd:
  Installed: 2.54.2+20.04
  Candidate: 2.54.2+20.04
  Version table:
 *** 2.54.2+20.04 500
        500 http://de.archive.ubuntu.com/ubuntu focal-proposed/main amd64 Packages
        100 /var/lib/dpkg/status
     2.51.1+20.04ubuntu2 500
        500 http://de.archive.ubuntu.com/ubuntu focal-updates/main amd64 Packages
     2.48.3+20.04 500
        500 http://security.ubuntu.com/ubuntu focal-security/main amd64 Packages
     2.44.3+20.04 500
        500 http://de.archive.ubuntu.com/ubuntu focal/main amd64 Packages
$ apt-cache policy fish
fish:
  Installed: 3.1.0-1.2
  Candidate: 3.1.0-1.2
  Version table:
 *** 3.1.0-1.2 500
        500 http://de.archive.ubuntu.com/ubuntu focal/universe amd64 Packages
        100 /var/lib/dpkg/status

ProblemType: Bug
DistroRelease: Ubuntu 20.04
Package: snapd 2.54.2+20.04
ProcVersionSignature: Ubuntu 5.13.0-25.26~20.04.1-generic 5.13.19
Uname: Linux 5.13.0-25-generic x86_64
ApportVersion: 2.20.11-0ubuntu27.21
Architecture: amd64
CasperMD5CheckResult: skip
CurrentDesktop: KDE
Date: Sat Jan 15 15:27:14 2022
InstallationDate: Installed on 2011-11-29 (3699 days ago)
InstallationMedia: Kubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111011)
SourcePackage: snapd
UpgradeStatus: No upgrade log present (probably fresh install)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Ian Johnson (anonymouse67)]

This was introduced in https://github.com/snapcore/snapd/pull/11141

[maurizio de santis (izietto)]

This bug is present in fish < 3.2, because fish_add_path has been added in fish 3.2: https://github.com/fish-shell/fish-shell/releases/tag/3.2.0

So a quick and dirty workaround is installing the official fish PPA: https://launchpad.net/~fish-shell/+archive/ubuntu/release-3

[Luis Alberto Pabón (copong)]

Issue also present in Impish.

[Quinn Diggity (quinndiggity)]

Got hit by this, flooded with cron emails, thanks.

For others affected who land here, I've found that the proper fix for the issue is:

```
apt purge snapd
apt-mark hold snapd
```

Good riddance.

Dear, Canonical, no one wants snapd, and it is pushing a large majority of your userbase away. Would love to keep using Ubuntu, but your decisions around snapd (such as discovering security updates aren't being applied at all to Firefox, thanks again for that) are making the Ubuntu ecosystem unusable, particularly for long time users.