add dh_installmenu to rules.

Bug #176761 reported by Stanislav Maslovski on 2007-12-16
8
Affects Status Importance Assigned to Milestone
smplayer (Ubuntu)
Undecided
Daniel Schwitzgebel

Bug Description

Binary package hint: smplayer

Please add dh_installmenu to debian/rules.

Changed in smplayer:
assignee: nobody → schwitzd
Daniel Schwitzgebel (schwitzd) wrote :

The bugfix

Changed in smplayer:
status: New → Confirmed
assignee: schwitzd → nobody
Cesare Tirabassi (norsetto) wrote :

Thanks, but a couple of problems need to be corrected:

dh_installmenu needs to be called BEFORE dpkg-deb is called to build the debian package.
For instance, it can be after the dh_installman call.
Also note that current hardy package is 0.5.62-0ubuntu1 while you have based your patch on the current gutsy version.
If you use apt-get source you need to add the correct deb-src entry in sources.list to retrieve the hardy source version.

Please test your package before submitting again (for instance with dpkg -c and dpkg -I) to check that menu file and icon are installed correctly.

Changed in smplayer:
assignee: nobody → schwitzd
status: Confirmed → In Progress
Maia Everett (linneris) wrote :

My fault for not catching the missing call. Attaching debdiff for 0.5.62.

Changed in smplayer:
status: In Progress → Confirmed
Daniel Schwitzgebel (schwitzd) wrote :

Hi, I noticed you prepared a new debdiff for bug #176761. Please, ping me next time, so we avoid duplicating efforts :)

Changed in smplayer:
assignee: schwitzd → nobody
assignee: nobody → schwitzd
Daniel Holbach (dholbach) wrote :

Bryce: can you take a look at this?

Maia Everett (linneris) wrote :

smplayer (0.5.62-0ubuntu2) hardy; urgency=low

  * Added dh_installmenu (suggested by
    Daniel Schwitzgebel <email address hidden>). (LP: #176761)

 -- Matvey Kozhev <email address hidden> Mon, 17 Dec 2007 17:31:54 +0600

Changed in smplayer:
status: Confirmed → Fix Released
Bryce Harrington (bryce) wrote :

Accepted:
 OK: smplayer_0.5.62.orig.tar.gz
 OK: smplayer_0.5.62-0ubuntu2.diff.gz
 OK: smplayer_0.5.62-0ubuntu2.dsc
     -> Component: multiverse Section: graphics

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Mon, 17 Dec 2007 17:31:54 +0600
Source: smplayer
Binary: smplayer-translations smplayer
Architecture: source
Version: 0.5.62-0ubuntu2
Distribution: hardy
Urgency: low
Maintainer: Ubuntu MOTU Developers <email address hidden>
Changed-By: Matvey Kozhev <email address hidden>
Description:
 smplayer - complete front-end for MPlayer
 smplayer-translations - complete front-end for MPlayer
Launchpad-Bugs-Fixed: 176761
Changes:
 smplayer (0.5.62-0ubuntu2) hardy; urgency=low
 .
   * Added dh_installmenu (suggested by
     Daniel Schwitzgebel <email address hidden>). (LP: #176761)
Files:
 531bf73bdb6c9701ff615a1156c716a3 696 graphics optional smplayer_0.5.62-0ubuntu2.dsc
 a91467f80243ece83c01a0e80bbbd4ad 7344 graphics optional smplayer_0.5.62-0ubuntu2.diff.gz
Original-Maintainer: Cyril Breuil <email address hidden>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFHZ42mEaMBVuDmdhERAlRzAJ9Pn5BWc+/P5OREDQY3DPTp9EPBLQCdGmMh
SDjJq3pGFp52wlvosW1ofNc=
=MCgv
-----END PGP SIGNATURE-----

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers