Smokeping cleared notification repeated indefinitely even if edgetrigger is yes

Bug #1886584 reported by Giovanni Panozzo
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
smokeping (Ubuntu)
Fix Released
Undecided
Unassigned
Focal
Fix Released
Undecided
Gianfranco Costamagna

Bug Description

The SRU template:

[Impact]

 * User receives repeated notification e-mail when an alert is triggered
   on an "Alert" with option edgetrigger = yes

 * backporting because broken smokeping edgetrigger option makes smokeping
   useless in many scenarios

 * the bug is fixed upstream
     https://github.com/oetiker/SmokePing/issues/183#issuecomment-533722180
   and in Debian
     https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934170#46

[Test Case]

 * Install smokeping, add an Alert with edgetrigger = yes and a target
   which uses that Alert. Configure e-mail alerting.
   Point that target to ping a powered on device.
   Start smokeping, wait 10 minutes, power off or disconnect these
   target device from the network.
   You will receive an email with "raised" event, and then an
   infinite sequence of email with "cleared" event at every
   smokeping poll (5 minutes default).
   A working option edgetrigger = yes should only send one email when
   target is unreachable and one when is reachable again.

[Regression Potential]

 * none known

Changed in smokeping (Ubuntu):
status: New → Fix Released
Changed in smokeping (Ubuntu Focal):
status: New → In Progress
Changed in smokeping (Ubuntu Focal):
assignee: nobody → Gianfranco Costamagna (costamagnagianfranco)
Revision history for this message
Giovanni Panozzo (giox069) wrote :

The SRU template:

[Impact]

 * User receives repeated notification e-mail when an alert is triggered
   on an "Alert" with option edgetrigger = yes

 * backporting because broken smokeping edgetrigger option makes smokeping
   useless in many scenarios

 * the bug is fixed upstream
     https://github.com/oetiker/SmokePing/issues/183#issuecomment-533722180
   and in Debian
     https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934170#46

[Test Case]

 * Install smokeping, add an Alert with edgetrigger = yes and a target
   which uses that Alert. Configure e-mail alerting.
   Point that target to ping a powered on device.
   Start smokeping, wait 10 minutes, power off or disconnect these
   target device from the network.
   You will receive an email with "raised" event, and then an
   infinite sequence of email with "cleared" event at every
   smokeping poll (5 minutes default).
   A working option edgetrigger = yes should only send one email when
   target is unreachable and one when is reachable again.

[Regression Potential]

 * none known

description: updated
Revision history for this message
Giovanni Panozzo (giox069) wrote :

debdiff 2.7.3-2 -> 2.7.3-2ubuntu20.04.1

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

Uploaded in unapproved queue for review

Revision history for this message
Timo Aaltonen (tjaalton) wrote : Please test proposed package

Hello Giovanni, or anyone else affected,

Accepted smokeping into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/smokeping/2.7.3-2ubuntu20.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in smokeping (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Revision history for this message
Giovanni Panozzo (giox069) wrote :

Tested smokeping_2.7.3-2ubuntu20.04.1_all.deb
It's working now.
Thank you.

Revision history for this message
Gianfranco Costamagna (costamagnagianfranco) wrote :

wonderful, tags updated.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package smokeping - 2.7.3-2ubuntu20.04.1

---------------
smokeping (2.7.3-2ubuntu20.04.1) focal; urgency=medium

  [ Matteo F. Vescovi ]
  * debian/patches/: fix-alert-edgetriggers added (Closes: #934170)
    LP: #1886584

 -- Gabriel Filion <email address hidden> Sat, 11 Jul 2020 00:00:19 +0200

Changed in smokeping (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for smokeping has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.