package smb2www 980804-38 failed to install/upgrade: subprocess installed post-installation script returned error exit status 1

[K. A. Sayeed]

Binary package hint: smb2www

1. E: smb2www: subprocess installed post-installation script returned error exit status 1

2. This happened when a set of were being installed using the Update Manager.

ProblemType: Package
DistroRelease: Ubuntu 10.04
Package: smb2www 980804-38
ProcVersionSignature: Ubuntu 2.6.32-25.44-generic 2.6.32.21+drm33.7
Uname: Linux 2.6.32-25-generic x86_64
Architecture: amd64
Date: Wed Oct 6 08:58:16 2010
ErrorMessage: subprocess installed post-installation script returned error exit status 1
InstallationMedia: Ubuntu 10.04 LTS "Lucid Lynx" - Release amd64 (20100429)
PackageArchitecture: all
SourcePackage: smb2www
Title: package smb2www 980804-38 failed to install/upgrade: subprocess installed post-installation script returned error exit status 1

[K. A. Sayeed (sayeed-ka)]

1. The crash occurred when a set of updates were being installed using the Update Manager.

[Eric Blake (eblake)]

On 01/11/2017 12:50 PM, Jose Ricardo Ziviani wrote:
> This commit fixes a warning in the code "(i * 2) ? .. : ..", which
> should be better as "(i) ? .. : ..", and improves the BCD_DIG_BYTE

Could remove the () around i here.

> macro by placing parentheses around its argument to avoid possible
> expansion issues like: BCD_DIG_BYTE(i + j).
>
> Signed-off-by: Jose Ricardo Ziviani <email address hidden>
> ---
> target/ppc/int_helper.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c
> index 24e5964..d889084 100644
> --- a/target/ppc/int_helper.c
> +++ b/target/ppc/int_helper.c
> @@ -2583,9 +2583,9 @@ void helper_vsubecuq(ppc_avr_t *r, ppc_avr_t *a, ppc_avr_t *b, ppc_avr_t *c)
> #define NATIONAL_NEG 0x2D
>
> #if defined(HOST_WORDS_BIGENDIAN)
> -#define BCD_DIG_BYTE(n) (15 - (n/2))
> +#define BCD_DIG_BYTE(n) (15 - ((n) / 2))
> #else
> -#define BCD_DIG_BYTE(n) (n/2)
> +#define BCD_DIG_BYTE(n) ((n) / 2)
> #endif
>
> static int bcd_get_sgn(ppc_avr_t *bcd)
> @@ -2908,7 +2908,7 @@ uint32_t helper_bcdcfz(ppc_avr_t *r, ppc_avr_t *b, uint32_t ps)
> }
>
> for (i = 0; i < 16; i++) {
> - zone_digit = (i * 2) ? b->u8[BCD_DIG_BYTE(i * 2)] >> 4 : zone_lead;
> + zone_digit = (i) ? b->u8[BCD_DIG_BYTE(i * 2)] >> 4 : zone_lead;

Extra (); I'd go with zone_digit = i ? ...

With that tweak,
Reviewed-by: Eric Blake <email address hidden>

--
Eric Blake eblake redhat com [phone]
Libvirt virtualization library http://libvirt.org