update-smart-drivedb is missing in Xenial and Bionic

[Humphrey van Polanen Petel]

[Impact]

In Bionic and Xenial we have a manpage for update-smart-drivedb script but it is not available. This script is quite important to users because it allows them to update the file which contains information about hardware, and this data is constantly updated, sometimes if it is not updated you cannot support some specific hardware.

The update-smart-drivedb script was removed in the past because of some security concerns regarding the update process. After sometime it was re-introduced because upstream implemented GPG verification support (which is available in Focal). The proposed fix re-introduce the new version of this script with a GPG verification support in Bionic and Xenial.

[Test Case]

$ lxc launch ubuntu-daily:bionic smartmontools-bionic
$ lxc shell smartmontools-bionic
# apt update && apt upgrade -y
# apt install -y smartmontools
# man update-smart-drivedb
# update-smart-drivedb
update-smart-drivedb: command not found

The same applies to Xenial.

[Regression Potential]

The chance of a regression is minimal. This script was not available previously.

[Original Description]

manpage
    manpages.ubuntu.com/manpages/xenial/man8/update-smart-drivedb.8.html
says
    Provided by: smartmontools_6.4+svn4214-1_amd64
but
invoking it fails with
    ~$ update-smart-drivedb
    update-smart-drivedb: command not found

[Christian Ehrhardt (paelzer)]

There were several issues with the tool to download unauthenticated data and such.
So it was removed in 6.4+svn4214-1 which is the one in Xenial and Bionic.

It was later introduced in an improved form in 7.0-1 therefore the latest LTS release of ubuntu Focal is good.

[Christian Ehrhardt (paelzer)]

We'll have to evaluate how easy (then let's do it) or complex-and-error-prone (then lets mark won't fix) this is to properly triage the SRU Tasks.

[Christian Ehrhardt (paelzer)]

The fix might not be, but the evaluation is bitesize - tagging as that

[Humphrey van Polanen Petel (hpvpp)]

The hardware maintenance phase of 16.04 finished end Q1 2018.
The release date of the Kingston SA400S37 ssd was Q1 2017 which falls within the responsibility of the hardware maintenance phase of 16.04.
Therefore, this information should be incorporated in 16.04

[Lucas Kanashiro (lucaskanashiro)]

I was able to backport the update-smart-drivedb.in file with gpg verification support:

https://github.com/smartmontools/smartmontools/blob/master/smartmontools/update-smart-drivedb.in

To make it work in Bionic and Xenial I needed to make the following changes:

- Update the GPG public key used to sign the drivedb.h file for versions 6.4 (Xenial) and 6.5 (Bionic). Upstream uses a different key for those old releases, I added the following GPG key:

# gpg --list-keys DFD22559
pub 2048R/DFD22559 2016-10-24 [expires: 2024-12-31]
uid Smartmontools Signing Key (ext. to 2024) <email address hidden>
uid Smartmontools Signing Key (through 2018) <email address hidden>
uid Smartmontools Signing Key (through 2018) <email address hidden>

- This new version of update-smart-drivedb also uses some variables defined via configure script which are not available in the old releases. To workaround that I set those variable inside the script with the same values we have in Focal. Those variables are:

  + ENABLE_SCRIPTPATH_TRUE and ENABLE_SCRIPTPATH_FALSE: in Focal this is enabled, so true was used.
  + scriptpath: this variable contains the search paths for binaries, I set it to "/usr/local/bin:/usr/bin:/bin" as in Focal.
  + GPG: this variable points to the GPG binary, I set it to "gpg" as in Focal.

With those changes in place I was able to run update-smart-drivedb with GPG verification support (also tried some of the new options). To give all the options available to users we will also need to suggest some other packages like it was done here:

https://salsa.debian.org/debian/smartmontools/-/commit/c894f39ddcbc48f478bad9d

My plan is to propose MPs with those changes to collect some feedback.

[Robie Basak (racb)]

Hello Humphrey, or anyone else affected,

Accepted smartmontools into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/smartmontools/6.5+svn4324-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Robie Basak (racb)]

Hello Humphrey, or anyone else affected,

Accepted smartmontools into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/smartmontools/6.4+svn4214-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Humphrey van Polanen Petel (hpvpp)]

I love you people and I love open source, but testing is a 'bridge too far' for me. Sorry.

[Paride Legovini (paride)]

Stumbled on this and did the verification on Xenial and Bionic: it works as expected, however:

1. The package will need a SRU across all the supported releases later in 2020 per:

https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1893126

2. Like in Focal, the update-smart-drivedb script causes:

https://bugs.launchpad.net/ubuntu/+source/smartmontools/+bug/1893202

Paride

[Paride Legovini (paride)]

I updated the bug title to make it more to the point.

[Lucas Kanashiro (lucaskanashiro)]

Thanks for the verification work Paride :)

For the 6.x the GPG key used by upstream is different than the one used in 7.x (Focal), the key introduced in this SRU expires in 2024. So only the Focal version has this expiration key issue for this year.

[Paride Legovini (paride)]

Fixed the tags.

For sure I had the bug open in two tabs, edited the tags from one tab, then again from the other tab which was not up-to-date with the changes at that point.

[Launchpad Janitor (janitor)]

This bug was fixed in the package smartmontools - 6.5+svn4324-1ubuntu0.1

---------------
smartmontools (6.5+svn4324-1ubuntu0.1) bionic; urgency=medium

  * Add GPG verification support to update-smart-drivedb (LP: #1874362)
    - d/p/update-smart-drivedb{,.8}.in-add-gpg-verification-support.patch:
      created.
    - d/rules: do not remove update-smart-drivedb during installation
    - d/control: add update-smart-drivedb dependencies as Suggests

 -- Lucas Kanashiro <email address hidden> Thu, 20 Aug 2020 11:17:35 -0300

[Brian Murray (brian-murray)]

The verification of the Stable Release Update for smartmontools has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package smartmontools - 6.4+svn4214-1ubuntu0.1

---------------
smartmontools (6.4+svn4214-1ubuntu0.1) xenial; urgency=medium

  * Add GPG verification support to update-smart-drivedb (LP: #1874362)
    - d/p/update-smart-drivedb{,.8}.in-add-gpg-verification-support.patch:
      created.
    - d/rules: do not remove update-smart-drivedb during installation
    - d/control: add update-smart-drivedb dependencies as Suggests

 -- Lucas Kanashiro <email address hidden> Thu, 20 Aug 2020 10:12:29 -0300