| 2012-10-04 17:37:14 |
Dustin Kirkland |
bug |
|
|
added bug |
| 2012-10-04 17:37:45 |
Dustin Kirkland |
summary |
sks postinst uses dpkg-vendor, but doesn't depend on dpkg-dev |
sks postinst uses dpkg-vendor, but doesn't depend on dpkg-dev (nor should it) |
|
| 2012-10-04 17:41:06 |
Dustin Kirkland |
sks (Ubuntu): importance |
Undecided |
High |
|
| 2012-10-04 17:41:08 |
Dustin Kirkland |
sks (Ubuntu): assignee |
|
Dustin Kirkland (kirkland) |
|
| 2012-10-04 17:41:12 |
Dustin Kirkland |
sks (Ubuntu): status |
New |
In Progress |
|
| 2012-10-04 17:41:33 |
Dustin Kirkland |
nominated for series |
|
Ubuntu Precise |
|
| 2012-10-04 17:41:33 |
Dustin Kirkland |
bug task added |
|
sks (Ubuntu Precise) |
|
| 2012-10-04 17:41:33 |
Dustin Kirkland |
nominated for series |
|
Ubuntu Quantal |
|
| 2012-10-04 17:41:33 |
Dustin Kirkland |
bug task added |
|
sks (Ubuntu Quantal) |
|
| 2012-10-04 17:41:51 |
Dustin Kirkland |
sks (Ubuntu Precise): status |
New |
In Progress |
|
| 2012-10-04 17:41:55 |
Dustin Kirkland |
sks (Ubuntu Precise): importance |
Undecided |
High |
|
| 2012-10-04 17:41:56 |
Dustin Kirkland |
sks (Ubuntu Precise): assignee |
|
Dustin Kirkland (kirkland) |
|
| 2012-10-04 17:57:38 |
Micah Gersten |
bug task added |
|
precise-backports |
|
| 2012-10-04 18:18:08 |
Dustin Kirkland |
description |
A recent change to sks packaging uses the dpkg-vendor command to determine if the current OS derives from Ubuntu. dpkg-vendor is provided by the dpkg-dev package, which sks does not, and should not depend on.
In order for the postinst to behave properly, it needs to gracefully handle the situation where the dpkg-vendor command does not exist. |
A recent change to sks packaging uses the dpkg-vendor command to determine if the current OS derives from Ubuntu. dpkg-vendor is provided by the dpkg-dev package, which sks does not, and should not depend on.
In order for the postinst to behave properly, it needs to gracefully handle the situation where the dpkg-vendor command does not exist.
ubuntu@ip-10-195-165-105:~$ sudo apt-get install sks --reinstall
Reading package lists... Done
Building dependency tree
Reading state information... Done
0 upgraded, 0 newly installed, 1 reinstalled, 0 to remove and 6 not upgraded.
Need to get 0 B/802 kB of archives.
After this operation, 0 B of additional disk space will be used.
(Reading database ... 25941 files and directories currently installed.)
Preparing to replace sks 1.1.1+dpkgv3-7ubuntu0.2 (using .../sks_1.1.1+dpkgv3-7ubuntu0.2_amd64.deb) ...
Stopping sks daemons: sksrecon.. sksdb.. done.
Unpacking replacement sks ...
Processing triggers for ureadahead ...
Processing triggers for man-db ...
Setting up sks (1.1.1+dpkgv3-7ubuntu0.2) ...
debian-sks uid check: ok
debian-sks homedir check: ok
/var/lib/dpkg/info/sks.postinst: 76: /var/lib/dpkg/info/sks.postinst: dpkg-vendor: not found
Starting sks daemons: Not starting sks (as configured in /etc/default/sks)
== SRU ==
=== IMPACT ===
This bug impacts any 12.04 server running SKS where dpkg-dev is not installed (which is often the case), and upgrades to the current package in precise-updates. dpkg-dev would drag in a handful of development level utilities and compilers that many administrators would not want on their production server.
=== TEST CASE ===
Take a 12.04 server installed prior to July 9, 2012, with SKS installed. In my case, I started a 12.04 server in EC2, and commented out the two lines in /etc/apt/sources.list referencing precise-updates. Install SKS:
$ sudo apt-get update && sudo apt-get install -y sks
Then, uncomment the precise-updates lines in /etc/apt/sources.list, and upgrade SKS:
$ sudo apt-get update && sudo apt-get install -y sks
=== REGRESSION POTENTIAL ===
As implemented, minimal.
=== MINIMAL PATCH ===
diff -Nru sks-1.1.3/debian/sks.postinst sks-1.1.3/debian/sks.postinst
--- sks-1.1.3/debian/sks.postinst 2012-07-02 06:19:39.000000000 -0500
+++ sks-1.1.3/debian/sks.postinst 2012-10-04 12:46:25.000000000 -0500
@@ -73,7 +73,8 @@
if [ -r /var/lib/sks/berkeley_db.active ]; then
OLD_BDB=$(cat /var/lib/sks/berkeley_db.active)
else
- if dpkg-vendor --derives-from Ubuntu; then
+ if (type dpkg-vendor >/dev/null && dpkg-vendor --derives-from Ubuntu) || \
+ [ -e /etc/dpkg/origins/ubuntu ]; then
if dpkg --compare-versions "$2" lt "1.1.1+dpkgv3-6.1"; then
OLD_BDB=4.7
else |
|
| 2012-10-04 18:19:38 |
Dustin Kirkland |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2012-10-04 18:19:54 |
Dustin Kirkland |
sks (Ubuntu Precise): status |
In Progress |
Fix Committed |
|
| 2012-10-04 18:19:56 |
Dustin Kirkland |
sks (Ubuntu Quantal): status |
In Progress |
Fix Committed |
|
| 2012-10-04 18:48:37 |
Adam Conrad |
sks (Ubuntu Precise): status |
Fix Committed |
In Progress |
|
| 2012-10-04 18:52:11 |
Launchpad Janitor |
sks (Ubuntu Quantal): status |
Fix Committed |
Fix Released |
|
| 2012-10-04 19:25:27 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/sks |
|
| 2012-10-04 19:55:21 |
Adam Conrad |
sks (Ubuntu Precise): status |
In Progress |
Fix Committed |
|
| 2012-10-04 19:55:25 |
Adam Conrad |
bug |
|
|
added subscriber SRU Verification |
| 2012-10-04 19:55:32 |
Adam Conrad |
tags |
|
verification-needed |
|
| 2012-10-04 20:49:38 |
Launchpad Janitor |
branch linked |
|
lp:ubuntu/precise-proposed/sks |
|
| 2013-02-06 19:38:14 |
Brian Murray |
tags |
verification-needed |
removal-candidate verification-needed |
|
| 2013-02-08 13:01:48 |
Stefano Rivera |
tags |
removal-candidate verification-needed |
verification-done |
|
| 2013-02-15 10:15:15 |
Launchpad Janitor |
sks (Ubuntu Precise): status |
Fix Committed |
Fix Released |
|
| 2013-02-15 10:15:21 |
Colin Watson |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-11-16 21:28:32 |
Dan Streetman |
precise-backports: status |
New |
Won't Fix |
|
