simutrans assert failure: *** invalid %N$ use detected ***

[bazzdee]

[SRU] Please consider the patch attached to comment #12 for an SRU for Quantal.

[IMPACT]
The game is unplayable for German users as starting the game in the German language mode (simutrans -lang de) results in a crash.

[Test Cases]
Test that the game is able to start in the German language mode (simutrans -lang de).

[Regression Potential]
Minimal: Only German translations have been changed.

Original bug description:
When starting simutrans, it crashes while loading

ProblemType: Crash
DistroRelease: Ubuntu 13.04
Package: simutrans 111.2.2-1
ProcVersionSignature: Ubuntu 3.8.0-2.6-generic 3.8.0-rc4
Uname: Linux 3.8.0-2-generic i686
ApportVersion: 2.8-0ubuntu4
Architecture: i386
AssertionMessage: *** invalid %N$ use detected ***
CrashCounter: 1
Date: Sat Feb 2 11:42:21 2013
ExecutablePath: /usr/games/simutrans
MarkForUpload: True
ProcCmdline: simutrans
ProcEnviron:
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=de_DE.UTF-8
 SHELL=/bin/bash
Signal: 6
SourcePackage: simutrans
StacktraceTop:
 __libc_message (do_abort=do_abort@entry=1, fmt=fmt@entry=0xb6ffeb65 "%s") at ../sysdeps/unix/sysv/linux/libc_fatal.c:199
 __GI___libc_fatal (message=message@entry=0xb7000c04 "*** invalid %N$ use detected ***\n") at ../sysdeps/unix/sysv/linux/libc_fatal.c:210
 _IO_vfprintf_internal (s=s@entry=0xbfb749a0, format=<optimized out>, format@entry=0xb7f37968 "Der Verkehr in %$1s nimmt zu:\n%3$i waren bei der Er\366ffnung\nvon %2$s.", ap=ap@entry=0xbfb74b28 "\260/h\270 \247z\267*\001") at vfprintf.c:1901
 ___vsnprintf_chk (s=0xb7d5a268 "Der Verkehr in ", maxlen=<optimized out>, flags=1, slen=4294967295, format=0xb7f37968 "Der Verkehr in %$1s nimmt zu:\n%3$i waren bei der Er\366ffnung\nvon %2$s.", args=0xbfb74b28 "\260/h\270 \247z\267*\001") at vsnprintf_chk.c:63
 ?? ()
Title: simutrans assert failure: *** invalid %N$ use detected ***
UpgradeStatus: Upgraded to raring on 2012-12-04 (59 days ago)
UserGroups: adm admin audio cdrom dialout lpadmin plugdev sambashare

[Julian Taylor (jtaylor)]

looks like this is fixed in the new version in debian, I'll sync it to ubuntu
please test if you still have this issue in version 111.3.1

-Der Verkehr in %$1s nimmt zu:\n%3$i waren bei der Er<F6>ffnung\nvon %2$s.
+Der Verkehr in %1$s nimmt zu:\n%3$i waren bei der Er<F6>ffnung\nvon %2$s.

[Sasa Paporovic (melchiaros)]

Hi bazzdee,

the simutrans version 111.3.1 is now in raring.

Could you please test it like Julian has requested.

In meantime I set the status of the report to incomplete(you know we have to prevent bugtracker swamping ->more than 1000 bugs for raring).

Feel free to set the status of the report back to new if the version 111.3.1 do not solve this problem. Or when the problem is solved please set it to fix released(only for simutrans not for quantal(for backporting I guess)).

Thank you

melchiaros

[Julian Taylor (jtaylor)]

works for me in raring, confirmed in quantal

[Graham Inggs (ginggs)]

The attached debdiff backports various translation fixes from 111.3.1 in Raring, including the "Der Verkehr in %1$s nimmt..." fix which makes the game playable for German users.

[Julian Taylor (jtaylor)]

thanks for the patch, but I for the sru would prefer that it only fixes the issue in the german translation.
The other translation updates can't really be reviewed and are also not very important.

[Graham Inggs (ginggs)]

The attached debdiff backports German translation fixes from 111.3.1 in Raring, including the "Der Verkehr in %1$s nimmt..." fix which makes the game playable for German users.

[Julian Taylor (jtaylor)]

thanks, I uploaded the fix to quantal, though I did minimize the diff to only the required fix.

[Sebastien Bacher (seb128)]

seems it has been uploaded by Julian:
http://launchpadlibrarian.net/132871225/simutrans_111.2.2-1ubuntu0.1_source.changes

unsuscribing sponsors, subscribing ubuntu-sru instead

[Dave Walker (davewalker)]

Hello bazzdee, or anyone else affected,

Accepted simutrans into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/simutrans/111.2.2-1ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Graham Inggs (ginggs)]

After upgrading to the version in quantal-proposed, 'simutrans -lang de' no longer core dumps.

[Brian Murray (brian-murray)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package simutrans - 111.2.2-1ubuntu0.1

---------------
simutrans (111.2.2-1ubuntu0.1) quantal-proposed; urgency=low

  * Backport German translation fix from 111.3.1 (LP: #1113356)
    fixes "invalid %N$ use detected" crash with -D_FORTIFY_SOURCE=2
 -- Graham Inggs <email address hidden> Sun, 03 Mar 2013 13:29:16 +0200