Patch to stop siloconfig from running from dpkg

Bug #431106 reported by Michael Casadevall
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
silo (Ubuntu)
Undecided
Unassigned
Hardy
Undecided
Adam Conrad

Bug Description

Binary package hint: silo

siloconfig defaults to running interactively when called via postinst when we're not doing an upgrade. The end result is that this breaks both the buildds when silo is installed as a build-dep, and breaks d-i which can't handle siloconfig trying to grab the console from it.

This patch removes the siloconfig call as under ubuntu, siloconfig doesn't do anything more than an over-glorified silo -f call, and doesn't create a usable silo.conf by default.

summary: - Patch to modify siloconfig to run sanely
+ Patch to modify siloconfig to not run from dpkg
description: updated
summary: - Patch to modify siloconfig to not run from dpkg
+ Patch to modify siloconfig to run sanely from dpkg
Revision history for this message
Michael Casadevall (mcasadevall) wrote :
summary: - Patch to modify siloconfig to run sanely from dpkg
+ Patch to stop siloconfig from running from dpkg
description: updated
Revision history for this message
StefanPotyra (sistpoty) wrote :

looks good, uploading (stripping ppa from the version number).

Thanks.

Changed in silo (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package silo - 1.4.14-0ubuntu3

---------------
silo (1.4.14-0ubuntu3) karmic; urgency=low

  * Disable siloconfig from ever running automatically
    - siloconfig doesn't properly handle UUIDs, and its default configuration
      doesn't set important things like initrd. In almost all cases it will be
      a silo -f, which we can simply do ourselves. We'll leave it in case the user
      ever needs it. This also puts silo more in line with the current behavior of
      lilo. (LP: #431106)

 -- Michael Casadevall <email address hidden> Wed, 16 Sep 2009 23:37:30 -0400

Changed in silo (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote :

Given that it's hard to say, several years later, if the above fix is "correct" for hardy (since it changes the behaviour experienced over the last several years), I'm going to just "cheat" and skip running siloconfig if we're running in a launchpad-style buildd chroot.

Changed in silo (Ubuntu Hardy):
assignee: nobody → Adam Conrad (adconrad)
status: New → In Progress
Revision history for this message
Chris Halse Rogers (raof) wrote : Please test proposed package

Hello Michael, or anyone else affected,

Accepted silo into hardy-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/silo/1.4.13a+git20070930-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in silo (Ubuntu Hardy):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Adam Conrad (adconrad) wrote :

Verified that it no longer hangs the d-i build at https://launchpad.net/ubuntu/+source/debian-installer/20070308ubuntu40.15/+build/3629180

Also verified that it still behaves as before on a non-buildd system.

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package silo - 1.4.13a+git20070930-1ubuntu2

---------------
silo (1.4.13a+git20070930-1ubuntu2) hardy; urgency=low

  * Don't run siloconfig from the postinst if we're running in a
    launchpad-style buildd chroot, fixing d-i FTBFS (LP: #431106)
 -- Adam Conrad <email address hidden> Thu, 12 Jul 2012 19:30:46 -0600

Changed in silo (Ubuntu Hardy):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers