Shimmer-theme Greybird does not get along with LXAppearance

Bug #1448487 reported by Mélodie
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
shimmer-themes (Ubuntu)
Fix Released
Low
Simon Steinbeiß

Bug Description

In short:
As of Ubuntu Trusty up to Vivid, I met with an issue affecting the display of images in buttons in the logout screen. The logout screen is provided by obsession which is forked from lxsession-logout.

Versions for now:
shimmer-themes 1.9.4-0ubuntu2
Ubuntu (Bento Remix) 15.04

I could not get LXApearance to add the images in the buttons, then my logout window had
no icons. I tried Orion and Bluebird GTK themes from the same package and they are free
from this issue.

Here is a screen-shot showing where the issue lies:
http://linuxvillage.org/wp-content/uploads/images/bento-dev/images-in-buttons.png

when the field is ticked, after pressing "apply" it doesn't write the setting, and then when LXAppearance
is restarted the tick in the field is not kept.

Once I switch to other GTK themes the issue does not exist anymore.

Thanks for fixing.

Best regards,
Mélodie

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

The likely reason is that Greybird disables button images in its gtkrc: https://github.com/shimmerproject/Greybird/blob/master/gtk-2.0/gtkrc#L15

Feel free to switch that 0 to a 1 in the theme and see whether that helps your case.

Revision history for this message
Mélodie (meets) wrote :

Hi Simon,

I understand that I should hence recompile this theme to make it compliant with the logout UI? I won't.

I came to point to it in a bug report, because my belief is that any GTK theme should fit in any kind of GTK friendly desktop environment. LXAppearance has a switch to make these buttons appear or not appear, on the user level. I would suppose the Xfce4 themes could be delivered with a choice available in the user session which other GTK3 themes provide, that's to say, either make it show or no, at will.

The default could be 0 if you want it so, as long as the end user has *the choice*.

Thanks for your explanation.

Best regards,
Mélodie

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

All you have to do is edit your /usr/share/themes/Greybird/gtk-2.0/gtkrc file, which is a text file. So any editor will do.

What I asked was for you to check whether that fixes the issue, in Xubuntu users have that choice too, but everything works fine here. If it fixes things with LXAppearance (and if it doesn't break things in Xubuntu) I wouldn't mind switching it to 1 by default.

Revision history for this message
Mélodie (meets) wrote :

Hi,
My bad, I had not understood your instruction. Yes it works, see here:
http://linuxvillage.org/wp-content/uploads/images/greybird-logout.png

I have one more question, how come the Greybird theme also pulls in gtk2-engines-murrine and gtk2-engines-pixbuf ? What are they needed for?

Best regards,
Mélodie

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

Ok, fixed upstream: commit 598933fa61658bc88f7d4c2b483e14a28cd4fffd

Those two engines are used to draw the gtk2 theme. The murrine engine is one of the most widespread ones (or: used to be, in the times of Gtk2).

Changed in shimmer-themes (Ubuntu):
status: New → Fix Committed
assignee: nobody → Simon Steinbeiß (ochosi)
Revision history for this message
Mélodie (meets) wrote :

Hello,

Great! And fixed soo fast thank you. When will it be expected to hit the repositories?

Best regards,
Mélodie

Revision history for this message
Simon Steinbeiß (ochosi) wrote :

That depends. This isn't really a very critical bug, so I suppose the fix might land in some PPA and in 15.10. Atm I don't think we'll backport it to 15.04.

Changed in shimmer-themes (Ubuntu):
importance: Undecided → Low
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shimmer-themes - 2.0.0-0ubuntu1

---------------
shimmer-themes (2.0.0-0ubuntu1) wily; urgency=medium

  * New theme releases (Albatross: 1.7.4, Greybird:1.6.0)
    - Fix LXAppearance button icon settings (LP: #1448487)
    - Fix GTK3 Theme parsing error (LP: #1314977)
    - Fix tiny arrows in Albatross (LP: #1249471)
  * debian/patches/greybird_no_symbolic_icons_in_sidebar.patch
    - Dropped, included upstream

 -- Sean Davis <email address hidden> Mon, 27 Jul 2015 23:55:36 -0500

Changed in shimmer-themes (Ubuntu):
status: Fix Committed → Fix Released
Pasi Lallinaho (knome)
no longer affects: lxappearance (Ubuntu)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.