userdel doesn't supports extrausers

Bug #1659534 reported by Matteo Croce
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Snappy
Fix Released
Undecided
Unassigned
shadow (Ubuntu)
Fix Released
Wishlist
Unassigned
Xenial
Fix Released
Wishlist
Unassigned
Bionic
Fix Released
Wishlist
Unassigned
Cosmic
Won't Fix
Undecided
Unassigned

Bug Description

TEST CASE:
- run userdel --extrausers foo on a ubuntu core system

REGRESSION POTENTIAL:
- low, this option will only take effect when "userdel --extrauser" is used.

On an Ubuntu Core system is impossible to delete an user from the extrausers db:

root@localhost:/# userdel --extrausers alice
userdel: unrecognized option '--extrausers'

Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in shadow (Ubuntu):
status: New → Confirmed
Revision history for this message
Stefan Nilsson (stefannilsson) wrote :

Any updates on this?

Changed in snappy:
status: New → Confirmed
Revision history for this message
Michael Vogt (mvo) wrote :

This is the fix for disco

Revision history for this message
Michael Vogt (mvo) wrote :
Changed in snappy:
status: Confirmed → In Progress
Changed in shadow (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Michael Vogt (mvo) wrote :
description: updated
Revision history for this message
Michael Vogt (mvo) wrote :
Changed in shadow (Ubuntu Xenial):
status: New → In Progress
Changed in shadow (Ubuntu Bionic):
status: New → In Progress
Revision history for this message
Michael Vogt (mvo) wrote :

SRUs for xenial,bionic are uploaded and in the unapproved queue.

tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shadow - 1:4.5-1.1ubuntu2

---------------
shadow (1:4.5-1.1ubuntu2) disco; urgency=medium

  * debian/patches/1013_extrausers_deluser.patch
    - add --extrausers option to "userdel" (LP: #1659534)

 -- Michael Vogt <email address hidden> Fri, 22 Mar 2019 19:32:50 +0100

Changed in shadow (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Please test proposed package

Hello Matteo, or anyone else affected,

Accepted shadow into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shadow/1:4.5-1ubuntu2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in shadow (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-bionic
Revision history for this message
Brian Murray (brian-murray) wrote :

Hello Matteo, or anyone else affected,

Accepted shadow into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/shadow/1:4.2-3.1ubuntu5.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-xenial to verification-done-xenial. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-xenial. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in shadow (Ubuntu Xenial):
status: In Progress → Fix Committed
tags: added: verification-needed-xenial
Mathew Hodson (mhodson)
Changed in shadow (Ubuntu):
importance: Undecided → Wishlist
Changed in shadow (Ubuntu Xenial):
importance: Undecided → Wishlist
Changed in shadow (Ubuntu Bionic):
importance: Undecided → Wishlist
Revision history for this message
Sergio Cazzolato (sergio-j-cazzolato) wrote :

Validation done on xenial and bionic

This log is part of the test I did to check --extrausers can be used to add and del users.

https://paste.ubuntu.com/p/Jn2kDcNcnv/

tags: added: verification-done verification-done-bionic verification-needed-done
removed: verification-needed verification-needed-bionic verification-needed-xenial
Revision history for this message
Brian Murray (brian-murray) wrote : Reminder of SRU verification policy change

Thank you for taking the time to verify this stable release fix. We have noticed that you have used the verification-done tag for marking the bug as verified and would like to point out that due to a recent change in SRU bug verification policy fixes now have to be marked with per-release tags (i.e. verification-done-$RELEASE). Please remove the verification-done tag and add one for the release you have tested the package in. Thank you!

https://wiki.ubuntu.com/StableReleaseUpdates#Verification

Michael Vogt (mvo)
tags: added: verification-done-xenial
removed: verification-done verification-needed-done
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shadow - 1:4.5-1ubuntu2

---------------
shadow (1:4.5-1ubuntu2) bionic; urgency=medium

  * debian/patches/1013_extrausers_deluser.patch
    - add --extrausers option to "userdel" (LP: #1659534)
  * debian/patches/2000_fix-su-pam-env-handling.
    - fix "su -l" to correctly use pam_getenvlist (LP: #984390)

 -- Michael Vogt <email address hidden> Fri, 22 Mar 2019 20:05:38 +0100

Changed in shadow (Ubuntu Bionic):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for shadow has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package shadow - 1:4.2-3.1ubuntu5.4

---------------
shadow (1:4.2-3.1ubuntu5.4) xenial; urgency=medium

  * patches/1012_extrausers_chfn.patch:
    - add --extrausers option to "chfn" (LP: #1495580)
  * debian/patches/1013_extrausers_deluser.patch:
    - add --extrausers option to "userdel" (LP: #1659534)
  * debian/patches/2000_fix-su-pam-env-handling:
    - fix "su -l" to correctly use pam_getenvlist (LP: #984390)

 -- Michael Vogt <email address hidden> Fri, 22 Mar 2019 20:22:06 +0100

Changed in shadow (Ubuntu Xenial):
status: Fix Committed → Fix Released
Revision history for this message
Balint Reczey (rbalint) wrote :

@mvo This fix raised bionic-update's shadow version above cosmic's. Do you plan fixing that or just wait for Cosmic's EOL?

Changed in shadow (Ubuntu Cosmic):
status: New → Confirmed
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I inspected snapd and noticed that we don't invoke "userdel" or "deluser" in any production code. We have some tests that do use it and we now support --extrausers there.

I'm inclined to mark the snappy task as fix released, given that we inherit the relevant tools from core and core18 snaps which in turn are fed with updates from the archive. While in the past we carried this patch locally in a package override, given that it is now fixed in both Xenial and Bionic I cannot imagine anything else we'd have to do in the context of this issue.

With this rationale I'm marking it as fix released. Please reopen if there's more relevant work to be done.

Changed in snappy:
status: In Progress → Fix Released
Michael Vogt (mvo)
Changed in shadow (Ubuntu Cosmic):
status: Confirmed → Won't Fix
Revision history for this message
Stefan Nilsson (stefannilsson) wrote :

Big thanks guys!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers