[needs-packaging] sgt-launcher

[Sean Davis]

SGT Puzzles Collection (sgt-launcher) is a game launcher and wrapper for Simon Tatham’s Portable Puzzle Collection (sgt-puzzles in Ubuntu). By embedding the games into the launcher window, additional functionality and improved usability is added to the games. Additionally, the large multitude of launchers in the applications menu is replaced by a single application.

The inclusion of this package in a Xubuntu release goal for 17.04.
https://blueprints.launchpad.net/ubuntu/+spec/xubuntu-z-development

URL: https://launchpad.net/sgt-launcher
License: GPL-3+
Release Announcement: https://smdavis.us/2016/11/06/sgt-puzzles-collection-introduction/

An initial package has been uploaded to:
https://launchpad.net/~bluesabre/+archive/ubuntu/sponsoring

[Mattia Rizzolo (mapreri)]

A small review:
* all files I could see declare GPL-3 as license, not GPL-3+, but you are using latter in d/copyright
* why are you disabling the tests? furthermore you're doing it only for 3.5; are they going to be magically fixed for 3.6 which I assume is not so far?
* could you please use dh 10? no real gain, but I like to use the newest stuff when possible
* you have trailing whitespaces in d/control:6,21
* mind bumping the date in d/changelog?1
* please declare the source format you're using, and please use 3.0
* please fix/override as needed these lintian overrides: debian-watch-file-is-missing, application-in-library-section, duplicate-changelog-files, manpage-has-useless-whatis-entry, desktop-command-not-in-package (don't override just becuase, of those only one should be overridden)

[Sean Davis (bluesabre)]

Hello Mattia, thank you very much for your review. I've made a number of improvements to the source as well as the packaging.

sgt-launcher 0.2.1 (https://launchpad.net/sgt-launcher/0.2/0.2.1)
* Install to PREFIX/games
* Improved manpage
* Add keywords to desktop file
* Upgraded license to GPL-3+
* Fix typo in sgt-launcher.desktop

Packaging (https://launchpad.net/~bluesabre/+archive/ubuntu/sponsoring/+files/sgt-launcher_0.2.1-0ubuntu1.dsc)
* Copyright in the source was bumped to GPL3+
* Reenabled tests. I had previously disabled these for other python packages I maintain because they caused build failures and incorrect dependencies. I further researched this and resolved the issues within the packaging.
* debhelper bumped to 10
* Removed trailing whitespace
* Bumped changelog version and date
* Resolved all lintian overrides except desktop-command-not-in-package, added an override (sgt-launcher adds diversions for each of the sgt-puzzles desktop files)

The new package has been tested and uploaded to my sponsoring PPA. Please let me know if there are any other changes that are needed.

[Mattia Rizzolo (mapreri)]

Note that now in the copyright notices you have a repetition:
    under the terms of the under the terms of the
You might want to fix it for your next release (no need for it now).

And... uploaded!

[Jeremy Bicha (jbicha)]

unsubscribing ubuntu-sponsors. Feel free to re-subscribe if something else needs to be sponsored!

[Sean Davis (bluesabre)]

Thanks for the upload Mattia! Would you mind also releasing it from the NEW queue? I've poked a few times in #-release but I am not around when the channel has any activity. :-)

[Mattia Rizzolo (mapreri)]

It is now accepted.