Activity log for bug #848605

Date Who What changed Old value New value Message
2011-09-13 05:00:41 Khairul Nizam bug added bug
2011-09-13 05:10:36 Apport retracing service tags apport-crash i386 need-duplicate-check oneiric running-unity apport-crash i386 oneiric running-unity
2011-09-13 05:10:37 Apport retracing service bug added subscriber Crash bug triagers for Ubuntu packages
2011-12-19 13:00:59 Launchpad Janitor sessioninstaller (Ubuntu): status New Confirmed
2012-04-07 06:53:50 Sebastian Heinlein visibility private public
2012-05-18 17:15:33 Ubuntu Foundations Team Bug Bot tags apport-crash i386 oneiric running-unity apport-crash i386 oneiric precise running-unity
2012-05-31 00:37:14 Ubuntu Foundations Team Bug Bot sessioninstaller (Ubuntu): importance Undecided Medium
2012-07-05 13:34:19 Sebastien Bacher nominated for series Ubuntu Precise
2012-07-05 13:34:19 Sebastien Bacher bug task added sessioninstaller (Ubuntu Precise)
2012-07-05 13:36:53 Sebastien Bacher sessioninstaller (Ubuntu Precise): importance Undecided High
2012-07-05 13:36:55 Sebastien Bacher sessioninstaller (Ubuntu Precise): milestone ubuntu-12.04.1
2012-07-05 13:38:12 Sebastien Bacher sessioninstaller (Ubuntu Precise): assignee Michael Terry (mterry)
2012-07-12 18:38:28 Stéphane Graber sessioninstaller (Ubuntu Precise): status New Triaged
2012-07-12 18:38:43 Stéphane Graber sessioninstaller (Ubuntu): status Confirmed Triaged
2012-07-23 21:03:54 Michael Terry attachment added aptd.py https://bugs.launchpad.net/ubuntu/precise/+source/sessioninstaller/+bug/848605/+attachment/3233381/+files/aptd.py
2012-07-25 13:44:43 Stéphane Graber sessioninstaller (Ubuntu Precise): status Triaged In Progress
2012-07-30 00:57:59 Scott Kitterman sessioninstaller (Ubuntu Precise): status In Progress Incomplete
2012-07-30 01:16:04 Khairul Nizam removed subscriber Khairul Nizam
2012-07-30 14:17:14 Michael Terry description unable to do partial upgrade ProblemType: Crash DistroRelease: Ubuntu 11.10 Package: sessioninstaller 0.20+bzr120-0ubuntu2 ProcVersionSignature: Ubuntu 3.0.0-11.17-generic 3.0.4 Uname: Linux 3.0.0-11-generic i686 ApportVersion: 1.22.1-0ubuntu2 Architecture: i386 Date: Tue Sep 13 12:58:04 2011 ExecutablePath: /usr/bin/session-installer InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Beta i386 (20110901) InterpreterPath: /usr/bin/python2.7 PackageArchitecture: all ProcCmdline: /usr/bin/python /usr/bin/session-installer ProcEnviron: SHELL=/bin/bash PATH=(custom, no user) LANG=en_US.UTF-8 PythonArgs: ['/usr/bin/session-installer'] SourcePackage: sessioninstaller Title: session-installer crashed with AlreadyCalledDeferred in callback() UpgradeStatus: Upgraded to oneiric on 2011-09-13 (0 days ago) UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare [IMPACT] * This can prevent users from installing helper packages needed to do their work (for example, can prevent opening rar, 7z, or jnlp files). * In addition, this is a highly reported crash on errors.ubuntu.com, so we know it affects many users. * The proposed fix just makes a certain deferral callback not be called twice, avoiding the assertion crash. [TESTCASE] * Unfortunately, I could not reproduce. So the patch is only based on code analysis. Someone that can reproduce needs to test it. I'm hoping by being accepted into precise-proposed, that will make it easier for the affected audience to test. * But the indicated reproduction steps as reported are: 0) Make sure you don't have rar installed: sudo apt-get purge rar unrar 1) Download a rar file. Try http://www.philipp-winterberg.com/download/example.rar 2) Open that file with file-roller 3) Try to install the necessary packages to open it [Regression Potential] * Regression potential is low. In the worst case, I could imagine if the patch is bogus, I could imagine the installation dialog would just stay open indefinitely because the deferral callback never got called. [Patch] The patch is simple: --- sessioninstaller-0.20+bzr128.orig/sessioninstaller/backends/aptd.py +++ sessioninstaller-0.20+bzr128/sessioninstaller/backends/aptd.py @@ -44,12 +44,11 @@ class AptDaemonBackend(object): def _run_trans(self, trans, parent, interaction): deferred = defer.Deferred() dia = aptdaemon.gtk3widgets.AptProgressDialog(trans) - dia.connect("finished", lambda x: deferred.callback()) if parent: dia.realize() dia.set_transient_for(parent) dia.run(close_on_finished=True, show_error=True, - reply_handler=lambda: True, + reply_handler=deferred.callback, error_handler=deferred.errback) return deferred ========================================================= unable to do partial upgrade ProblemType: Crash DistroRelease: Ubuntu 11.10 Package: sessioninstaller 0.20+bzr120-0ubuntu2 ProcVersionSignature: Ubuntu 3.0.0-11.17-generic 3.0.4 Uname: Linux 3.0.0-11-generic i686 ApportVersion: 1.22.1-0ubuntu2 Architecture: i386 Date: Tue Sep 13 12:58:04 2011 ExecutablePath: /usr/bin/session-installer InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Beta i386 (20110901) InterpreterPath: /usr/bin/python2.7 PackageArchitecture: all ProcCmdline: /usr/bin/python /usr/bin/session-installer ProcEnviron:  SHELL=/bin/bash  PATH=(custom, no user)  LANG=en_US.UTF-8 PythonArgs: ['/usr/bin/session-installer'] SourcePackage: sessioninstaller Title: session-installer crashed with AlreadyCalledDeferred in callback() UpgradeStatus: Upgraded to oneiric on 2011-09-13 (0 days ago) UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare
2012-07-30 16:41:31 Adam Conrad sessioninstaller (Ubuntu Precise): status Incomplete Fix Committed
2012-07-30 16:41:33 Adam Conrad bug added subscriber Ubuntu Stable Release Updates Team
2012-07-30 16:41:35 Adam Conrad bug added subscriber SRU Verification
2012-07-30 16:41:38 Adam Conrad tags apport-crash i386 oneiric precise running-unity apport-crash i386 oneiric precise running-unity verification-needed
2012-07-30 17:47:08 Launchpad Janitor branch linked lp:ubuntu/precise-proposed/sessioninstaller
2012-08-11 05:38:53 Steve Langasek tags apport-crash i386 oneiric precise running-unity verification-needed apport-crash i386 oneiric precise running-unity verification-done
2012-08-11 05:40:14 Launchpad Janitor sessioninstaller (Ubuntu): status Triaged Fix Released
2012-08-13 12:01:02 Colin Watson removed subscriber Ubuntu Stable Release Updates Team
2012-08-13 12:02:15 Launchpad Janitor sessioninstaller (Ubuntu Precise): status Fix Committed Fix Released
2012-08-21 06:25:45 Launchpad Janitor branch linked lp:~aptdaemon-developers/sessioninstaller/ubuntu-precise
2012-08-21 06:30:24 Launchpad Janitor branch linked lp:sessioninstaller