Seahorse fails to import OpenPGP keys

[Mackenzie Morgan]

Binary package hint: seahorse

Steps to reproduce:
1. Open Seahorse (Applications -> Accessories -> Passwords and Encryption Keys)
2. Click "Find Remote Keys"
3. Search for someone....even someone random
4. Pick a key from the list returned
5. Hit either the big "Import" button or go to Key -> Import

What happens:
Nothing

What should happen:
Public key should be downloaded and added to keyring

[Mackenzie Morgan (maco.m)]

I have a diff for the broken file

[Mackenzie Morgan (maco.m)]

forgot to free a pointer. oops. here's the correct patch.

[Mackenzie Morgan (maco.m)]

g_malloc, strncpy, an strncat because the release manager said so

[Andrew Starr-Bochicchio (andrewsomething)]

Thanks for the patch. I have test and can confirm that this resolves the issue. Attached is a debdiff adding this patch.

[Steve Langasek (vorlon)]

The proposed patch has a memory leak. Attached is a revised patch that fixes the memory management issues; can someone test that it also fixes the problem?

[Mackenzie Morgan (maco.m)]

Where's the memory leak? The first version that was attached didn't
have hexfpr being freed, but all subsequent ones did.

On Wed, 2008-04-16 at 02:50 +0000, Steve Langasek wrote:
> The proposed patch has a memory leak. Attached is a revised patch that
> fixes the memory management issues; can someone test that it also fixes
> the problem?
>
> ** Attachment added: "updated debdiff"
> http://launchpadlibrarian.net/13480676/seahorse-hex-key-import.debdiff
>
--
Mackenzie Morgan
http://ubuntulinuxtipstricks.blogspot.com
apt-get moo

[Steve Langasek (vorlon)]

On Wed, Apr 16, 2008 at 03:06:56AM -0000, Mackenzie Morgan wrote:
> Where's the memory leak? The first version that was attached didn't
> have hexfpr being freed, but all subsequent ones did.

The previous patch showed hexfpr being freed once at the end of the
function - but being re-malloc()ed repeatedly inside a loop, overwriting the
pointer to the previously-malloc()ed memory each time.

A static buffer is much simpler here, given that the amount of data we need
to pass is small and constant.

[Andrew Starr-Bochicchio (andrewsomething)]

I don't know enough about C to comment on the memory leak, but I have tested the updated debdiff and I can confirm that it also resolves the issue.

Thanks all for your work...

[Steve Langasek (vorlon)]

Ok, this fix has been uploaded and is now sitting in the queue pending approval from another member of the release team.

Thanks, all!

[Andrew Starr-Bochicchio (andrewsomething)]

Just want to note that I have forwarded this upstream, and the Ubuntu patch has been committed to trunk.

[Launchpad Janitor (janitor)]

This bug was fixed in the package seahorse - 2.22.1-0ubuntu2

---------------
seahorse (2.22.1-0ubuntu2) hardy; urgency=low

  * debian/patches/12_import_key.patch: fix importing of remote keys to
    prepend "0x" to key ids when constructing URIs. Thanks to Mackenzie
    Morgan for the preliminary patch. LP: #215729

 -- Steve Langasek <email address hidden> Tue, 15 Apr 2008 19:44:59 -0700

[Phill (phill.l)]

This is back in Ubuntu 16.04, exactly the same method to reproduce.

[Phill (phill.l)]

For clarification, I experienced the problem finding and importing the remote keys for <email address hidden>.