[upgrade] sdlmame new upstream release 0.136

Bug #502191 reported by Cesare Falco
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sdlmame (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: sdlmame

New SDLMAME upstream 0.136 needs packaging.

Tags: upgrade

Related branches

tags: added: upgrade
Revision history for this message
Cesare Falco (c.falco) wrote :

This is the .diff file for the new upstream release - sdlmame 0.136.

To build the source package use

zcat sdlmame_0.136-0ubuntu1.diff.gz | patch -p0
cd sdlmame-0.136
chmod +x debian/rules
debian/rules get-orig-source
mv sdlmame_0.136.orig.tar.gz ../
cd ..
tar xvfz sdlmame_0.136.orig.tar.gz
and the source tree should be in
sdlmame-0.136

Compiled binaries are available on my PPA as well:
https://edge.launchpad.net/~c.falco/+archive

Changed in sdlmame (Ubuntu):
status: New → Confirmed
Changed in sdlmame (Ubuntu):
assignee: nobody → Fabrice Coutadeur (fabricesp)
status: Confirmed → In Progress
Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi,

Why is the NOASM option required? And also, why we can delete contrib/joymap.dat ? With this info, I'll update the changelog and upload it.
By the way: the changelog entry should be with lucid ;-)

Thanks,
Fabrice

Changed in sdlmame (Ubuntu):
assignee: Fabrice Coutadeur (fabricesp) → Cesare Falco (c.falco)
Revision history for this message
Cesare Falco (c.falco) wrote :

Hello Fabrice,

the NOASM make variable selects which emulation engine to use. For all the targets currently supported by Ubuntu is recommended unsetting it, to take full advantage of the Assembly core when available. On the other hand, there are other targets (e.g. ARM or MIPS, according to the upstream SDLMAME.txt) for which it's mandatory to set NOASM.

I should have removed joymap.dat some release ago (0.129), when joystick code based on SDL was superseded by mainline code (see changelog). I simply forgot about it.

And yes, the changelog entry was another silly mistake. Sorry! ;-)

Thank you!
Cesare.

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi Cesare,

thanks for that explanations! Here is the changelog entry I will upload:
sdlmame (0.136-0ubuntu1) lucid; urgency=low

  * New upstream release - Closes (LP: #502191)
  * debian/rules:
    - Added new make variable NOASM to take advantage of the Assembly core when
      available, and also mandatory on some targets (ARM, for example)
    - Get whatsnew.txt from MAME site in get-orig-source target as it's missing
      in upstream tarball
  * debian/sdlmame.1: updated with new options "listdevices" and "numprocessors"
  * debian/contrib/config/joymap.dat: deleted for obsolete as joystick code is not
    based on SDL anymore

 -- Cesare Falco <email address hidden> Sun, 03 Jan 2010 15:39:00 +0100

I only have one concern with the whatsnew.txt file, as I think it should be part of the debian directory, and not put in the upstream tarball during the get-orig-source steps. What do you think? This way, you would have, and install, the whatnew.txt file in debian directory.

Thanks,
Fabrice

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Ohh, one more thing: Standards-version should be bump to 3.8.3, and you are repacking the source tarball, you would need a README.source file (I can take care of that, if you want :-) )

Fabrice

Revision history for this message
Cesare Falco (c.falco) wrote :

Hello Fabrice,

retrieving whatsnew.txt from the net is just a quick fix for the current release. Upstream maintainers didn't bother to repack the zipfile, but it will be back with 0.137. Putting whatsnew.txt in debian would require some changes in debian/rules. If you feel it would be cleaner, however, I'll do it and upload an updated package.

It seems I can't catch up with Standard-version: I forgot to bump it on karmic first release too. :)

I didn't know about the README.source file. I was told it would have been enough mentioning repacking in debian/changelog. Can you please point me to some info on what it it should contain? You can do it yourself if you like, however I'd like to understand things better. ;)

Thanks for all your help, which I really appreciate! :)
Cesare.

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Hi Cesare,

Even if it's a temporary fix, I prefer to have it in debian directory. This way, you won't need to update the get-orig-source target to get it, and I personally find it cleaner :-)

About the README.source file, you're right: it's seems to be necessary only when dpkg-source -x does not produce a directly editable directory, and that's not your case. So forget about that point ;-)

Thanks,
Fabrice

Revision history for this message
Cesare Falco (c.falco) wrote :

Hello Fabrice,

here's the new diff.gz, including fixes to changelog entry and debian/control file, as well as whatsnew.txt now in debian (rules updated accordingly).

Package builds on both karmic (pbuilder on my box) and lucid (see my PPA, I had to bump to 0ubuntu2 to avoid conflict with previous build, however it's the only change I made).

Thanks again,,
Cesare.

Revision history for this message
Fabrice Coutadeur (fabricesp) wrote :

Uploaded. Thanks for your work! :-
I had to update debian/rules to take into account the new whatsnew location, to fix a FTBFS. Apart from that, it's ok :-)

Thanks again,
Fabrice

Changed in sdlmame (Ubuntu):
assignee: Cesare Falco (c.falco) → nobody
status: In Progress → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sdlmame - 0.136-0ubuntu1

---------------
sdlmame (0.136-0ubuntu1) lucid; urgency=low

  * New upstream release - Closes (LP: #502191)
  * debian/rules:
    - Added new make variable NOASM to take advantage of the Assembly core when
      available, and also mandatory on some targets (ARM, for example)
    - Updated to take into account that whatnext is in debian directory for this
      release
  * debian/whatsnew.txt: get from MAME site as it's missing in upstream tarball
  * debian/sdlmame.1: updated with new options "listdevices" and "numprocessors"
  * debian/contrib/config/joymap.dat: deleted for obsolete as joystick code
    is not based on SDL anymore
 -- Cesare Falco <email address hidden> Sun, 04 Jan 2010 15:39:00 +0100

Changed in sdlmame (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.