lintian doesn't work as of sbuild 0.62.6-1ubuntu2

Bug #940410 reported by Jeremy Bícha
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
sbuild (Debian)
Fix Released
Unknown
sbuild (Ubuntu)
Fix Released
Low
Reinhard Tartler

Bug Description

For the last couple days, lintian isn't working in my sbuild.

Setting up lintian (2.5.4) ...
Generating en_US.UTF-8 locale for internal Lintian use....
Setting up sbuild-build-depends-lintian-dummy (0.invalid.0) ...
Package name and type must be defined at /usr/bin/lintian line 1692

E: Lintian run failed (runtime error)

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: sbuild 0.62.6-1ubuntu2
ProcVersionSignature: Ubuntu 3.2.0-17.26-generic 3.2.6
Uname: Linux 3.2.0-17-generic x86_64
ApportVersion: 1.93-0ubuntu2
Architecture: amd64
CheckboxSubmission: 201084ed41ea7548f8becd47fa4d1e6c
CheckboxSystem: c541d13ea4f205f2fd751f76ed21105b
Date: Fri Feb 24 11:01:51 2012
PackageArchitecture: all
SourcePackage: sbuild
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Jeremy Bícha (jbicha) wrote :
Revision history for this message
Jeremy Bícha (jbicha) wrote :

If I use sbuild 0.62.6-1ubuntu1, lintian works correctly. Something must be wrong with this patch

http://launchpadlibrarian.net/93727213/sbuild_0.62.6-1ubuntu1_0.62.6-1ubuntu2.diff.gz

I have these lines in my .sbuildrc

$lintian_opts = ["-I", "--pedantic", "--show-overrides"];
$run_lintian = 1;

tags: added: regression-release
Revision history for this message
Jeremy Bícha (jbicha) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sbuild - 0.63.1-1ubuntu1

---------------
sbuild (0.63.1-1ubuntu1) quantal; urgency=low

  * Resynchronize with Debian testing. Remaining changes:
    - debian/patches/do-not-install-debfoster-into-chroots.patch:
      do not install debfoster into the chroots because it is in universe and
      not needed for package building itself.
    - debian/patches/run-pre-build-hooks-as-root.patch:
      run pre-build hooks as root
  * Drop run-lintian-inside-chroot.patch: It hasn't been picked up
    by Debian and doesn't work quite right (LP: #940410)

sbuild (0.63.1-1) unstable; urgency=low

  [ Roger Leigh ]
  * New release
  * Don't require xapt. Remove duplicate and incorrect check. Thanks
    to Andres Mejia and Jakub Wilk (Closes: #675332, #675354).
  * Remove /etc/schroot/setup.d/99builddsourceslist which was
    provided with earlier versions of sbuild, but no longer works with
    current schroot versions (Closes: #675349).

sbuild (0.63.0-1) unstable; urgency=low

  [ Wookey ]
  * Support for cross-compiling has been added. This includes the
    addition of $host and $build configuration variables, with
    corresponding --host and --build command-line options. This
    includes the addition of a new 'xapt' dependency resolver.
    - Merge cross-build support (thanks to Hector Oron,
      Closes: #610689).
    - Add multiarch cross-build support.

  [ Roger Leigh ]
  * The deprecated 'internal' dependency resolver has been removed,
    along with the configuration variables $apt_policy,
    $check_depends_algorithm and $resolve_virtual, and the
    command-line option --check-depends-algorithm. The 'apt'
    resolver is the default replacement for 'internal'.
    (Closes: #622788)
  * Support for watches has been removed. The configuration
    variables $check_watches, $ignore_watches_no_build_deps and
    $watches (and obsolete variables @ignore_watches_no_build_deps
    and %watches) have also been removed.
  * sbuild-stats and support for build time and space statistics
    recording has been removed. These statistics are recorded in
    both the build log and are available as build metadata
    internally. The statistics recorded in the database were not
    particularly informative; storing the statistics in a proper
    relational database is recommended. The configuration variables
    $avg_time_db and $avg_space_db have been removed.
  * Drop 25nssdatabases schroot setup script used on compatibility
    mode (on buildds). This has been replaced by the schroot
    20nssdatabases for many years.
 -- Jeremy Bicha <email address hidden> Sat, 23 Jun 2012 22:27:58 -0400

Changed in sbuild (Ubuntu):
status: New → Fix Released
Revision history for this message
Reinhard Tartler (siretart) wrote :

The "fix" was to drop the patch, which I find something between disrespectful and wrong. AFAIUI, it did not break normal operation, but rather an optional functionality that does work in some cases, and for which there is an easy workaround (run lintian manually). Moreover, I'm using this functionality in precise and earlier on every upload.

I currently do not have the time to look into it immediately, but I'm assigning the issue to me so I don't forget about it.

Changed in sbuild (Ubuntu):
assignee: nobody → Reinhard Tartler (siretart)
importance: Undecided → Low
status: Fix Released → Triaged
Revision history for this message
Jeremy Bícha (jbicha) wrote :

I'm sorry you consider it wrong and disrespectful, but my sbuild has been broken since February. I reported it then. Almost two months ago, I also reported it (on the bug you filed!) to Debian, cautioning them not to accept your patch until the regression was fixed. There was no response.

As lintian is very useful to correct Debian/Ubuntu packaging and I only use sbuild, I consider this a high importance bug because it can lead to packaging bugs in other software. Optional functionality shouldn't break existing functionality.

Revision history for this message
Reinhard Tartler (siretart) wrote : Re: [Bug 940410] Re: lintian doesn't work as of sbuild 0.62.6-1ubuntu2

On Di, Jun 26, 2012 at 14:36:05 (CEST), Jeremy Bicha wrote:

> I'm sorry you consider it wrong and disrespectful, but my sbuild has
> been broken since February. I reported it then.

What it that much broken that it didn't manage to build packages? This
is not what I read from the bug report.

Without that patch, does the --run-lintian option do what you expect?

--
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4

Revision history for this message
Reinhard Tartler (siretart) wrote :

It seems that the resolver API has changed. Please find my updated proposed changed attached to this bug.

I'm going to upload a test package to my ppa

Changed in sbuild (Ubuntu):
status: Triaged → In Progress
tags: added: patch
Changed in sbuild (Debian):
status: Unknown → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote :

This was fixed with 0.64

Changed in sbuild (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.