sbuild-launchpad-chroot doesn't detect current overlayfs

Bug #1652117 reported by Stéphane Graber on 2016-12-22
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
sbuild-launchpad-chroot (Ubuntu)
Medium
Stéphane Graber
Yakkety
Medium
Stéphane Graber
Zesty
Medium
Stéphane Graber

Bug Description

With the switch from out of tree overlayfs to in-tree overlay, sbuild-launchpad-chroot must be updated to properly detect both of those, otherwise users end up with a "directory" type chroot that doesn't use unioning and so looses a few of the useful features provided by this tool.

# Rationale
New kernel doesn't have a "overlayfs" module, it's now called "overlay".
Both names should be used in the detection code.

# Test case
 - Before upgrade
   - sbuild-launchpad-chroot create -n test -s xenial -a amd64
   - Check that /etc/schroot/chroot.d/test doesn't contain "union-type"
   - sbuild-launchpad-chroot remove -n test
 - After upgrade
   - sbuild-launchpad-chroot create -n test -s xenial -a amd64
   - Check that /etc/schroot/chroot.d/test contains "union-type"
   - sbuild-launchpad-chroot remove -n test

# Regression potential
Not much, this won't affect anyone who has existing chroots, it only affects new chroots and re-introduces the behavior that people have been expecting up until the time where the overlayfs driver was removed from the kernel.

Changed in sbuild-launchpad-chroot (Ubuntu Xenial):
status: New → Triaged
Changed in sbuild-launchpad-chroot (Ubuntu Yakkety):
status: New → Triaged
Changed in sbuild-launchpad-chroot (Ubuntu Zesty):
status: New → Triaged
Changed in sbuild-launchpad-chroot (Ubuntu Xenial):
importance: Undecided → Medium
Changed in sbuild-launchpad-chroot (Ubuntu Yakkety):
importance: Undecided → Medium
Changed in sbuild-launchpad-chroot (Ubuntu Zesty):
importance: Undecided → Medium
Changed in sbuild-launchpad-chroot (Ubuntu Xenial):
assignee: nobody → Stéphane Graber (stgraber)
Changed in sbuild-launchpad-chroot (Ubuntu Yakkety):
assignee: nobody → Stéphane Graber (stgraber)
Changed in sbuild-launchpad-chroot (Ubuntu Zesty):
assignee: nobody → Stéphane Graber (stgraber)
no longer affects: sbuild-launchpad-chroot (Ubuntu Xenial)
Stéphane Graber (stgraber) wrote :

This probably should be SRUed to xenial at some point too, but right now xenial's schroot appears to be lacking support for the "overlay" union-type.

Changed in sbuild-launchpad-chroot (Ubuntu Zesty):
status: Triaged → Fix Committed
Changed in sbuild-launchpad-chroot (Ubuntu Yakkety):
status: Triaged → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sbuild-launchpad-chroot - 0.14

---------------
sbuild-launchpad-chroot (0.14) zesty; urgency=medium

  * Properly detect the "overlay" filesystem. (LP: #1652117)

 -- Stéphane Graber <email address hidden> Thu, 22 Dec 2016 12:42:25 -0500

Changed in sbuild-launchpad-chroot (Ubuntu Zesty):
status: Fix Committed → Fix Released
Jon Grimm (jgrimm) wrote :

I tested the zesty 0.14 upload on Yakkety, now works as expected. Thanks!

Hello Stéphane, or anyone else affected,

Accepted sbuild-launchpad-chroot into yakkety-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sbuild-launchpad-chroot/0.13.1ubuntu16.10.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in sbuild-launchpad-chroot (Ubuntu Yakkety):
status: In Progress → Fix Committed
tags: added: verification-needed
Jon Grimm (jgrimm) wrote :

Verified sbuild-launchpad-chroot 0.13.1ubuntu16.10.1

From newly created test schroot: /etc/schroot/chroot.d/test:

..
union-type=overlay
..

Additionally successful sbuild invocation using 'test'.

tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sbuild-launchpad-chroot - 0.13.1ubuntu16.10.1

---------------
sbuild-launchpad-chroot (0.13.1ubuntu16.10.1) yakkety; urgency=medium

  * Properly detect the "overlay" filesystem. (LP: #1652117)

 -- Stéphane Graber <email address hidden> Thu, 22 Dec 2016 12:42:25 -0500

Changed in sbuild-launchpad-chroot (Ubuntu Yakkety):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for sbuild-launchpad-chroot has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers