udev rules broken, causes /bin/chmod 0666 to be run on all USB ADD events

[TJ]

A user with 18.10 reported log being spammed with:

Nov 01 16:49:50 myhostname systemd-udevd[3398]: Process '/bin/chmod 0666 ' failed with exit code 1.
Nov 01 16:49:50 myhostname systemd-udevd[3400]: Process '/bin/chmod 0666 ' failed with exit code 1.
Nov 01 16:49:50 myhostname systemd-udevd[3399]: Process '/bin/chmod 0666 ' failed with exit code 1.
Nov 01 16:49:50 myhostname systemd-udevd[3403]: Process '/bin/chmod 0666 ' failed with exit code 1.

We tracked this down to a broken udev rule

Nov 1 16:49:53 feminalia systemd-udevd[3293]: Invalid rule /etc/udev/rules.d/99-sbig.rules:49: unknown key 'SYSFS{idVendor}'
Nov 1 16:49:53 feminalia systemd-udevd[3293]: Invalid rule /etc/udev/rules.d/99-sbig.rules:54: unknown key 'SYSFS{idVendor}'
Nov 1 16:49:53 feminalia systemd-udevd[3293]: Invalid rule /etc/udev/rules.d/99-sbig.rules:59: unknown key 'SYSFS{idVendor}'

where it is using:

SUBSYSTEM=="usb", ACTION=="add", SYSFS{idVendor}=="0d97", SYSFS{idProduct}=="0003" ... RUN+="/bin/chmod 0666 $env{DEVNAME}"

and as the idVendor is being ignored is executing for almost all USB ADD events. It should be using ATTR{idVendor}

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.