[SRU] no ufw profile or apport hook is included in the 12.04 packages

[James Page]

Impact:
Bugs reported in Ubuntu have limited apport information compared to previous releases.
UFW profile is missing - regression from previous release.

Development Fix:
Restore missing lines from install files in packaging.

Stable Fix:
Restore missing lines from install files in packaging.

Test Case:
sudo apt-get install samba
/etc/ufw/applications.d/samba and /usr/share/apport/package-hooks/source_samba.py are missing.

Regression Potential:
Minimal - these files are missing from the release version in 12.04 and don't really impact outside of ufw or apport.

Original Bug Report:

The samba packages in 11.10 ship both a ufw profile and an apport hook:

   samba: /etc/ufw/applications.d/samba
   samba-common-bin: /usr/share/apport/package-hooks/source_samba.py

Neither of these is included in the 12.04 packages - looks like they got dropped from the .install files during merging.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: samba 2:3.6.3-2ubuntu2.1
ProcVersionSignature: Ubuntu 3.2.0-24.37-generic 3.2.14
Uname: Linux 3.2.0-24-generic x86_64
ApportVersion: 2.0.1-0ubuntu7
Architecture: amd64
Date: Tue May 15 16:47:40 2012
SourcePackage: samba
UpgradeStatus: No upgrade log present (probably fresh install)

[Launchpad Janitor (janitor)]

This bug was fixed in the package samba - 2:3.6.5-2ubuntu1

---------------
samba (2:3.6.5-2ubuntu1) quantal; urgency=low

  * Merge from Debian unstable, remaining changes:
    + debian/patches/VERSION.patch:
      - set SAMBA_VERSION_SUFFIX to Ubuntu.
    + debian/smb.conf:
      - add "(Samba, Ubuntu)" to server string.
      - comment out the default [homes] share, and add a comment about
        "valid users = %S" to show users how to restrict access to
        \\server\username to only username.
      - Other changes now in Debian packaging.
    + debian/samba-common.config:
      - Do not change priority to high if dhclient3 is installed.
      - Use priority medium instead of high for the workgroup question.
    + debian/control:
      - Don't build against or suggest ctdb.
      - Add dependency on samba-common-bin to samba.
    + Add ufw integration:
      - Created debian/samba.ufw.profile
      - debian/rules, debian/samba.install: install profile.
      - debian/control: have samba suggest ufw.
    + Add apport hook:
      - Created debian/source_samba.py.
      - debian/rules, debian/samba-common-bin.install: install hook.
    + Switch to upstart:
      - Added debian/samba.{nmbd,smbd}.upstart.
      - debian/samba.logrotate, debian/samba-common.dhcp, debian/samba.if-up:
        Make upstart compatible.
  * d/samba.install, d/samba-common-bin.install: Restore apport hook and ufw
    profile (LP: #999764).
  * Dropped:
    + debian/patches/CVE-2012-1182-*.patch: fixed in upstream release 3.6.4.
    + debian/patches/CVE-2012-2111.patch: fixed in upstream release 3.6.5.
    + debian/patches/fix-debuglevel-name-conflict.patch: fixed upstream -
      debug_level is no longer used as a global variable name.
    + debian/patches/error-trans.fix-276472: fixed upstream.

samba (2:3.6.5-2) unstable; urgency=low

  * The yearly "SambaXP bug cleaning party" release. 11 years
    SambaXP, 20 years Samba and counting...
  * Make samba-common "Multi-Arch: foreign"
  * Adapt patch in upstream #7499 and stop nss_wins clobbering other
    daemon's logfiles. Closes: #598313
  * Add some mention about some use for the user information in Kerberos
    environments in the smbspool manpage. Closes: #387266
  * Drop link to no longer provided "Using Samba" documentation in
    HTML documentation summary file. Closes: #604768
  * Provide WHATSNEW.txt in samba-doc too as it is linked from the
    documentation summary file. Do not compress that file.
  * Fix link to WHATSNEW.txt in HTML documentation summary file. This
    is the second part of the fix for #604768
  * Use lp_state_dir() instead of get_dyn_STATEDIR() in
    fhs-filespaths.patch as the latter does indeed hardcode the
    location for passdb.tdb and secrets.tdb to /var/lib/samba
    (the compile-time option for state directory and NOT the configurable
    value). This is left to "state directory" instead of "private dir"
    at least as of now, because if doesn't change anything to the
    current behaviour, but allows the files' location to be configurable
    through "state directory" (and not "private dir").
    Closes: #249873
  * Disable useless smbtorture4 build. Thanks to Ivo De Deck...

[Martin Pitt (pitti)]

Hello James, or anyone else affected,

Accepted samba into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Liam Young (gnuoy)]

I enabled precise-proposed and installed samba (2:3.6.3-2ubuntu2.2) and samba-common-bin (2:3.6.3-2ubuntu2.2). After which both files were present:

[James Page (james-page)]

I also tested the apport hook in -proposed and it raises bug reports with additional samba information.

[Launchpad Janitor (janitor)]

This bug was fixed in the package samba - 2:3.6.3-2ubuntu2.2

---------------
samba (2:3.6.3-2ubuntu2.2) precise-proposed; urgency=low

  * Fix issue with winbind crashing when trying to access groups containing
    more than 1000 members (LP: #970679):
    - d/patches/lp_970679_fix-large-groups.patch: Cherry picked patch from
      upstream VCS which ensures that large hunk handling in winbind works
      with talloc preventing crashes.
  * d/samba.install: Restore missing ufw profile (LP: #999764).
  * d/samba-common-bin.install: Restore missing apport hook (LP: #999764).
 -- James Page <email address hidden> Wed, 16 May 2012 13:10:02 +0100