Activity log for bug #1795772

Date Who What changed Old value New value Message
2018-10-03 02:06:51 Rolando Gorgs bug added bug
2018-10-03 13:11:57 Andreas Hasenack nominated for series Ubuntu Bionic
2018-10-03 13:11:57 Andreas Hasenack bug task added samba (Ubuntu Bionic)
2018-10-03 13:14:01 Andreas Hasenack bug watch added https://bugzilla.samba.org/show_bug.cgi?id=13204
2018-10-03 13:14:01 Andreas Hasenack bug task added samba
2018-10-03 13:14:30 Andreas Hasenack tags server-next
2018-10-03 13:14:34 Andreas Hasenack samba (Ubuntu): importance Undecided High
2018-10-03 13:14:36 Andreas Hasenack samba (Ubuntu Bionic): importance Undecided High
2018-10-03 13:14:44 Andreas Hasenack bug added subscriber Ubuntu Server
2018-10-03 14:21:06 Karl Stenerud marked as duplicate 1777601
2018-10-03 14:28:21 Karl Stenerud removed duplicate marker 1777601
2018-10-03 14:28:35 Launchpad Janitor samba (Ubuntu): status New Confirmed
2018-10-03 14:28:35 Launchpad Janitor samba (Ubuntu Bionic): status New Confirmed
2018-10-03 14:28:50 Karl Stenerud samba (Ubuntu): assignee Karl Stenerud (kstenerud)
2018-10-03 14:28:53 Karl Stenerud samba (Ubuntu Bionic): assignee Karl Stenerud (kstenerud)
2018-10-03 17:50:21 Karl Stenerud description When you delete a non-empty directory in Nautilus or Nemo, the Folder-Icon disappears and stays away but when you refresh the current directory or navigate back there it reappears. No error message at all. This bug is very annoying in two ways: 1) When you only have smb access to the share you have to delete all files and directories in sub, subsub and subsubsubdirecories by hand to actually delete a directory. 2) You don't get warned that the delete operation failed. In our case this produced a horrible mess in our shares before we recognized what was going wrong. You can find many people complaining in various forums. I found bug reports in bugtrackers of Nemo, Nautilus and Gnome but the root seems to be this (upstream fixed) bug in samba: https://bugzilla.samba.org/show_bug.cgi?id=13204 Please cherry pick the fix into current version of samba. Thanks a lot for your help! samba [Impact] The samba client doesn't check the result of rmdir, returning success when the directory is not empty. This results in clients reporting successful directory removal when in fact the directory was not removed. This bug affects anything that uses the samba client, including file managers, mount, and gvfs. [Test Case] # lxc launch ubuntu-daily:cosmic sambatest # lxc exec sambatest bash Inside container: # apt update # apt dist-upgrade -y # apt install -y samba samba-client # mkdir -p /tmp/shared/testdir/testsubdir # chown -R nobody:nogroup /tmp/shared # printf "%s" "[global] workgroup = WORKGROUP server role = standalone server security = user map to guest = Bad User guest ok = yes guest only = yes guest account = nobody [shared] path = /tmp/shared writable = yes browsable = yes guest ok = yes " | tee "/etc/samba/smb.conf" >/dev/null # service smbd restart # CLI_FORCE_INTERACTIVE=yes smbclient -U " "%" " //localhost/shared <<EOF rmdir testdir quit EOF * Should get NT_STATUS_DIRECTORY_NOT_EMPTY [Upstream Report and Fix] https://bugzilla.samba.org/show_bug.cgi?id=13204 https://attachments.samba.org/attachment.cgi?id=14408 [Regression Potential] If the fix is implemented incorrectly, clients may receive false error messages, and report failure even on success when removing directories. [Original Description] When you delete a non-empty directory in Nautilus or Nemo, the Folder-Icon disappears and stays away but when you refresh the current directory or navigate back there it reappears. No error message at all. This bug is very annoying in two ways: 1) When you only have smb access to the share you have to delete all files and directories in sub, subsub and subsubsubdirecories by hand to actually delete a directory. 2) You don't get warned that the delete operation failed. In our case this produced a horrible mess in our shares before we recognized what was going wrong. You can find many people complaining in various forums. I found bug reports in bugtrackers of Nemo, Nautilus and Gnome but the root seems to be this (upstream fixed) bug in samba: https://bugzilla.samba.org/show_bug.cgi?id=13204 Please cherry pick the fix into current version of samba. Thanks a lot for your help!
2018-10-03 17:50:33 Karl Stenerud description samba [Impact] The samba client doesn't check the result of rmdir, returning success when the directory is not empty. This results in clients reporting successful directory removal when in fact the directory was not removed. This bug affects anything that uses the samba client, including file managers, mount, and gvfs. [Test Case] # lxc launch ubuntu-daily:cosmic sambatest # lxc exec sambatest bash Inside container: # apt update # apt dist-upgrade -y # apt install -y samba samba-client # mkdir -p /tmp/shared/testdir/testsubdir # chown -R nobody:nogroup /tmp/shared # printf "%s" "[global] workgroup = WORKGROUP server role = standalone server security = user map to guest = Bad User guest ok = yes guest only = yes guest account = nobody [shared] path = /tmp/shared writable = yes browsable = yes guest ok = yes " | tee "/etc/samba/smb.conf" >/dev/null # service smbd restart # CLI_FORCE_INTERACTIVE=yes smbclient -U " "%" " //localhost/shared <<EOF rmdir testdir quit EOF * Should get NT_STATUS_DIRECTORY_NOT_EMPTY [Upstream Report and Fix] https://bugzilla.samba.org/show_bug.cgi?id=13204 https://attachments.samba.org/attachment.cgi?id=14408 [Regression Potential] If the fix is implemented incorrectly, clients may receive false error messages, and report failure even on success when removing directories. [Original Description] When you delete a non-empty directory in Nautilus or Nemo, the Folder-Icon disappears and stays away but when you refresh the current directory or navigate back there it reappears. No error message at all. This bug is very annoying in two ways: 1) When you only have smb access to the share you have to delete all files and directories in sub, subsub and subsubsubdirecories by hand to actually delete a directory. 2) You don't get warned that the delete operation failed. In our case this produced a horrible mess in our shares before we recognized what was going wrong. You can find many people complaining in various forums. I found bug reports in bugtrackers of Nemo, Nautilus and Gnome but the root seems to be this (upstream fixed) bug in samba: https://bugzilla.samba.org/show_bug.cgi?id=13204 Please cherry pick the fix into current version of samba. Thanks a lot for your help! [Impact] The samba client doesn't check the result of rmdir, returning success when the directory is not empty. This results in clients reporting successful directory removal when in fact the directory was not removed. This bug affects anything that uses the samba client, including file managers, mount, and gvfs. [Test Case] # lxc launch ubuntu-daily:cosmic sambatest # lxc exec sambatest bash Inside container: # apt update # apt dist-upgrade -y # apt install -y samba samba-client # mkdir -p /tmp/shared/testdir/testsubdir # chown -R nobody:nogroup /tmp/shared # printf "%s" "[global]     workgroup = WORKGROUP     server role = standalone server     security = user     map to guest = Bad User     guest ok = yes     guest only = yes     guest account = nobody [shared]     path = /tmp/shared     writable = yes     browsable = yes     guest ok = yes " | tee "/etc/samba/smb.conf" >/dev/null # service smbd restart # CLI_FORCE_INTERACTIVE=yes smbclient -U " "%" " //localhost/shared <<EOF rmdir testdir quit EOF * Should get NT_STATUS_DIRECTORY_NOT_EMPTY [Upstream Report and Fix] https://bugzilla.samba.org/show_bug.cgi?id=13204 https://attachments.samba.org/attachment.cgi?id=14408 [Regression Potential] If the fix is implemented incorrectly, clients may receive false error messages, and report failure even on success when removing directories. [Original Description] When you delete a non-empty directory in Nautilus or Nemo, the Folder-Icon disappears and stays away but when you refresh the current directory or navigate back there it reappears. No error message at all. This bug is very annoying in two ways: 1) When you only have smb access to the share you have to delete all files and directories in sub, subsub and subsubsubdirecories by hand to actually delete a directory. 2) You don't get warned that the delete operation failed. In our case this produced a horrible mess in our shares before we recognized what was going wrong. You can find many people complaining in various forums. I found bug reports in bugtrackers of Nemo, Nautilus and Gnome but the root seems to be this (upstream fixed) bug in samba: https://bugzilla.samba.org/show_bug.cgi?id=13204 Please cherry pick the fix into current version of samba. Thanks a lot for your help!
2018-10-09 17:51:39 Andreas Hasenack merge proposal linked https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/356356
2018-10-09 17:51:49 Andreas Hasenack samba (Ubuntu): assignee Karl Stenerud (kstenerud) Andreas Hasenack (ahasenack)
2018-10-09 17:51:51 Andreas Hasenack samba (Ubuntu Bionic): assignee Karl Stenerud (kstenerud) Andreas Hasenack (ahasenack)
2018-10-09 17:51:55 Andreas Hasenack samba (Ubuntu): status Confirmed In Progress
2018-10-11 06:35:39 Launchpad Janitor samba (Ubuntu): status In Progress Fix Released
2018-10-11 19:24:56 Andreas Hasenack samba (Ubuntu Bionic): status Confirmed In Progress
2018-10-11 19:55:45 Andreas Hasenack merge proposal linked https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/356614
2018-11-06 20:55:11 Brian Murray samba (Ubuntu Bionic): status In Progress Fix Committed
2018-11-06 20:55:14 Brian Murray bug added subscriber Ubuntu Stable Release Updates Team
2018-11-06 20:55:17 Brian Murray bug added subscriber SRU Verification
2018-11-06 20:55:21 Brian Murray tags server-next server-next verification-needed verification-needed-bionic
2018-11-07 00:21:50 Rolando Gorgs tags server-next verification-needed verification-needed-bionic server-next verification-failed-bionic verification-needed
2018-11-07 11:36:01 Rolando Gorgs samba (Ubuntu Bionic): status Fix Committed In Progress
2018-11-08 18:47:21 Andreas Hasenack merge proposal linked https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+merge/358520
2018-11-08 23:03:00 Andreas Hasenack description [Impact] The samba client doesn't check the result of rmdir, returning success when the directory is not empty. This results in clients reporting successful directory removal when in fact the directory was not removed. This bug affects anything that uses the samba client, including file managers, mount, and gvfs. [Test Case] # lxc launch ubuntu-daily:cosmic sambatest # lxc exec sambatest bash Inside container: # apt update # apt dist-upgrade -y # apt install -y samba samba-client # mkdir -p /tmp/shared/testdir/testsubdir # chown -R nobody:nogroup /tmp/shared # printf "%s" "[global]     workgroup = WORKGROUP     server role = standalone server     security = user     map to guest = Bad User     guest ok = yes     guest only = yes     guest account = nobody [shared]     path = /tmp/shared     writable = yes     browsable = yes     guest ok = yes " | tee "/etc/samba/smb.conf" >/dev/null # service smbd restart # CLI_FORCE_INTERACTIVE=yes smbclient -U " "%" " //localhost/shared <<EOF rmdir testdir quit EOF * Should get NT_STATUS_DIRECTORY_NOT_EMPTY [Upstream Report and Fix] https://bugzilla.samba.org/show_bug.cgi?id=13204 https://attachments.samba.org/attachment.cgi?id=14408 [Regression Potential] If the fix is implemented incorrectly, clients may receive false error messages, and report failure even on success when removing directories. [Original Description] When you delete a non-empty directory in Nautilus or Nemo, the Folder-Icon disappears and stays away but when you refresh the current directory or navigate back there it reappears. No error message at all. This bug is very annoying in two ways: 1) When you only have smb access to the share you have to delete all files and directories in sub, subsub and subsubsubdirecories by hand to actually delete a directory. 2) You don't get warned that the delete operation failed. In our case this produced a horrible mess in our shares before we recognized what was going wrong. You can find many people complaining in various forums. I found bug reports in bugtrackers of Nemo, Nautilus and Gnome but the root seems to be this (upstream fixed) bug in samba: https://bugzilla.samba.org/show_bug.cgi?id=13204 Please cherry pick the fix into current version of samba. Thanks a lot for your help! [Impact] The samba client doesn't check the result of rmdir, returning success when the directory is not empty. This results in clients reporting successful directory removal when in fact the directory was not removed. This bug affects anything that uses the samba client, including file managers, mount, and gvfs. [Test Case] # lxc launch ubuntu-daily:bionic sambatest # lxc exec sambatest bash Inside container: # apt update # apt dist-upgrade -y # apt install -y samba samba-client # mkdir -p /tmp/shared/testdir/testsubdir # chown -R nobody:nogroup /tmp/shared # printf "%s" "[global]     workgroup = WORKGROUP     server role = standalone server     security = user     map to guest = Bad User     guest ok = yes     guest only = yes     guest account = nobody [shared]     path = /tmp/shared     writable = yes     browsable = yes     guest ok = yes " | tee "/etc/samba/smb.conf" >/dev/null # service smbd restart # CLI_FORCE_INTERACTIVE=yes smbclient -U " "%" " //localhost/shared <<EOF rmdir testdir quit EOF * Should get NT_STATUS_DIRECTORY_NOT_EMPTY [Upstream Report and Fix] https://bugzilla.samba.org/show_bug.cgi?id=13204 https://attachments.samba.org/attachment.cgi?id=14408 [Regression Potential] If the fix is implemented incorrectly, clients may receive false error messages, and report failure even on success when removing directories. [Original Description] When you delete a non-empty directory in Nautilus or Nemo, the Folder-Icon disappears and stays away but when you refresh the current directory or navigate back there it reappears. No error message at all. This bug is very annoying in two ways: 1) When you only have smb access to the share you have to delete all files and directories in sub, subsub and subsubsubdirecories by hand to actually delete a directory. 2) You don't get warned that the delete operation failed. In our case this produced a horrible mess in our shares before we recognized what was going wrong. You can find many people complaining in various forums. I found bug reports in bugtrackers of Nemo, Nautilus and Gnome but the root seems to be this (upstream fixed) bug in samba: https://bugzilla.samba.org/show_bug.cgi?id=13204 Please cherry pick the fix into current version of samba. Thanks a lot for your help!
2018-11-09 11:49:54 Christian Ehrhardt  description [Impact] The samba client doesn't check the result of rmdir, returning success when the directory is not empty. This results in clients reporting successful directory removal when in fact the directory was not removed. This bug affects anything that uses the samba client, including file managers, mount, and gvfs. [Test Case] # lxc launch ubuntu-daily:bionic sambatest # lxc exec sambatest bash Inside container: # apt update # apt dist-upgrade -y # apt install -y samba samba-client # mkdir -p /tmp/shared/testdir/testsubdir # chown -R nobody:nogroup /tmp/shared # printf "%s" "[global]     workgroup = WORKGROUP     server role = standalone server     security = user     map to guest = Bad User     guest ok = yes     guest only = yes     guest account = nobody [shared]     path = /tmp/shared     writable = yes     browsable = yes     guest ok = yes " | tee "/etc/samba/smb.conf" >/dev/null # service smbd restart # CLI_FORCE_INTERACTIVE=yes smbclient -U " "%" " //localhost/shared <<EOF rmdir testdir quit EOF * Should get NT_STATUS_DIRECTORY_NOT_EMPTY [Upstream Report and Fix] https://bugzilla.samba.org/show_bug.cgi?id=13204 https://attachments.samba.org/attachment.cgi?id=14408 [Regression Potential] If the fix is implemented incorrectly, clients may receive false error messages, and report failure even on success when removing directories. [Original Description] When you delete a non-empty directory in Nautilus or Nemo, the Folder-Icon disappears and stays away but when you refresh the current directory or navigate back there it reappears. No error message at all. This bug is very annoying in two ways: 1) When you only have smb access to the share you have to delete all files and directories in sub, subsub and subsubsubdirecories by hand to actually delete a directory. 2) You don't get warned that the delete operation failed. In our case this produced a horrible mess in our shares before we recognized what was going wrong. You can find many people complaining in various forums. I found bug reports in bugtrackers of Nemo, Nautilus and Gnome but the root seems to be this (upstream fixed) bug in samba: https://bugzilla.samba.org/show_bug.cgi?id=13204 Please cherry pick the fix into current version of samba. Thanks a lot for your help! [Impact] The samba client doesn't check the result of rmdir, returning success when the directory is not empty. This results in clients reporting successful directory removal when in fact the directory was not removed. This bug affects anything that uses the samba client, including file managers, mount, and gvfs. [Test Case] # lxc launch ubuntu-daily:bionic sambatest # lxc exec sambatest bash Inside container: # apt update # apt dist-upgrade -y # apt install -y samba samba-client # mkdir -p /tmp/shared/testdir/testsubdir # chown -R nobody:nogroup /tmp/shared # printf "%s" "[global]     workgroup = WORKGROUP     server role = standalone server     security = user     map to guest = Bad User     guest ok = yes     guest only = yes     guest account = nobody [shared]     path = /tmp/shared     writable = yes     browsable = yes     guest ok = yes " | tee "/etc/samba/smb.conf" >/dev/null # service smbd restart # CLI_FORCE_INTERACTIVE=yes smbclient -U " "%" " //localhost/shared <<EOF rmdir testdir quit EOF * Should get NT_STATUS_DIRECTORY_NOT_EMPTY - with the bug present one will get no error message, but in both cases the delete didn't happen [Upstream Report and Fix] https://bugzilla.samba.org/show_bug.cgi?id=13204 https://attachments.samba.org/attachment.cgi?id=14408 [Regression Potential] If the fix is implemented incorrectly, clients may receive false error messages, and report failure even on success when removing directories. [Original Description] When you delete a non-empty directory in Nautilus or Nemo, the Folder-Icon disappears and stays away but when you refresh the current directory or navigate back there it reappears. No error message at all. This bug is very annoying in two ways: 1) When you only have smb access to the share you have to delete all files and directories in sub, subsub and subsubsubdirecories by hand to actually delete a directory. 2) You don't get warned that the delete operation failed. In our case this produced a horrible mess in our shares before we recognized what was going wrong. You can find many people complaining in various forums. I found bug reports in bugtrackers of Nemo, Nautilus and Gnome but the root seems to be this (upstream fixed) bug in samba: https://bugzilla.samba.org/show_bug.cgi?id=13204 Please cherry pick the fix into current version of samba. Thanks a lot for your help!
2018-11-13 19:17:38 Brian Murray samba (Ubuntu Bionic): status In Progress Fix Committed
2018-11-13 19:17:43 Brian Murray tags server-next verification-failed-bionic verification-needed server-next verification-needed verification-needed-bionic
2018-11-14 23:09:58 Rolando Gorgs tags server-next verification-needed verification-needed-bionic server-next verification-done-bionic verification-needed
2018-11-20 22:56:08 Brian Murray removed subscriber Ubuntu Stable Release Updates Team
2018-11-20 23:06:13 Launchpad Janitor samba (Ubuntu Bionic): status Fix Committed Fix Released