swat rewrites fields incorrectly

Bug #17829 reported by Tessa
8
Affects Status Importance Assigned to Milestone
samba
Won't Fix
Medium
samba (Ubuntu)
Won't Fix
Medium
Unassigned

Bug Description

When SWAT re-parses the config file after making changes, it parses and displays
some of the fields incorrectly. This has a nasty side-effect: if you change a
different field, and then click "Commit" again, the broken, incorrectly parsed
values get committed to the smb.conf file, potentially breaking your Samba
configuration.

Here are the fields I've found with problems:

All mode and mask fields assume that the field will be in the format 0###. If
you want directories to be created with the sguid bit, for example, and enter in
2777, it will commit this value to the conf file and then read it back in as
02777, which breaks Samba's interpretation of that config entry.

All entry fields (or, at the very least, admin users, read list, and write list)
misinterpret user and group names with spaces in them. You should be able to put
in entries like '@group name', and indeed, SWAT will translate it to that format
if you put in something like @"group name", but when SWAT reads these back in,
it translates them to: '@group, name'.

There's probably others, but these are the ones I run into most frequently.

Revision history for this message
Matt Zimmerman (mdz) wrote :

This looks like it should go upstream

Changed in samba:
assignee: nobody → adconrad
Revision history for this message
Tessa (unit3) wrote :

I have no idea if this is still an issue, did anyone ever submit this upstream?

Revision history for this message
Soren Hansen (soren) wrote :

Confirmed and submitted upstream.

Changed in samba:
status: New → Triaged
assignee: adconrad → nobody
Changed in samba:
status: Unknown → Confirmed
Changed in samba:
importance: Unknown → Medium
Revision history for this message
Paul.E.T (paul-tabo) wrote :

Has this Bug been closed out or what ??
Need an info update.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Nobody is actively working on this bug, either in Ubuntu or upstream.

Revision history for this message
Maarten Bezemer (veger) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. We are sorry that we do not always have the capacity to look at all reported bugs in a timely manner. There have been many changes in Ubuntu since that time you reported the bug and your problem may have been fixed with some of the updates. It would help us a lot if you could test it on a currently supported Ubuntu version. When you test it and it is still an issue, kindly upload the updated logs by running apport-collect 17829 and any other logs that are relevant for this particular issue.

Changed in samba (Ubuntu):
status: Triaged → Incomplete
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Re-opening - this bug is still open upstream, and while there have been changes in this area of the code I'm pretty sure none of them have affected the rewriting of fields in SWAT.

Changed in samba (Ubuntu):
status: Incomplete → Confirmed
Changed in samba:
status: Confirmed → Won't Fix
Revision history for this message
Jelmer Vernooij (jelmer) wrote :

SWAT has been discontinued.

Changed in samba (Ubuntu):
status: Confirmed → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.