samba's apport hook uses incorrect syntax to list cifs mounts

Bug #1703604 reported by Andreas Hasenack on 2017-07-11
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
samba (Ubuntu)
Low
Andreas Hasenack

Bug Description

The current apport hook in debian/source_samba.py uses command_output() incorrectly to list cifs shares:

report['CIFSMounts'] = command_output(['mount', '|', 'grep', 'cifs'])

command_output() from apport.hookutils doesn't use shell or system(), so the above is just passing a literal "|" to mount as a parameter, which fails:

Error: command ['mount', '|', 'grep', 'cifs'] failed with exit code 1:

summary: - apport hook uses incorrect syntax to list cifs mounts
+ samba's apport hook uses incorrect syntax to list cifs mounts
Changed in samba (Ubuntu):
assignee: nobody → Andreas Hasenack (ahasenack)
status: New → In Progress
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package samba - 2:4.6.7+dfsg-1ubuntu2

---------------
samba (2:4.6.7+dfsg-1ubuntu2) artful; urgency=medium

  * d/source_samba.py: use the new recommended findmnt(8) tool to list
    mountpoints and correctly filter by the cifs filesystem type.
    (LP: #1703604)

 -- Andreas Hasenack <email address hidden> Fri, 01 Sep 2017 09:47:58 -0300

Changed in samba (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers