Offer to include testparm's analysis in bug reports

Bug #1694334 reported by Andreas Hasenack on 2017-05-29
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
samba (Ubuntu)
Wishlist
Andreas Hasenack

Bug Description

It would be helpful to offer to include samba's testparm(1) analysis of the smb.conf config file in samba bug reports.

If the user agrees to attach smb.conf, then it's not really needed (bug triagers can run it themselves), but in the case of a refusal, having testparm run a quick sanity check on that file and include its report in the bug would save time.

I have a test branch that implements the following workflow:
- if the user refuses to attach smb.conf, ask a followup question about testparm
- this followup question asks if the user would allow us to run "testparm -s /etc/samba/smb.conf > /dev/null". This will capture testparm's analysis of the config file, show share names, show syntax errors, and give a good or bad result.
- the user can refuse to run testparm
- if the user agreed to attach smb.conf in the previous question, then we don't run testparm.

Andreas Hasenack (ahasenack) wrote :

Attached is a quick diff showing the changes made for this proposal. This is the corresponding git branch: https://code.launchpad.net/~ahasenack/ubuntu/+source/samba/+git/samba/+ref/apport-run-testparm

summary: - Offer to include testparm's analysis in but reports
+ Offer to include testparm's analysis in bug reports
Andreas Hasenack (ahasenack) wrote :

I removed the debdiff attachment in favor of the linked git packaging MP.

tags: added: patch
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package samba - 2:4.5.8+dfsg-2ubuntu2

---------------
samba (2:4.5.8+dfsg-2ubuntu2) artful; urgency=medium

  * Add extra DEP8 tests to samba (LP: #1696823):
    - d/t/control: enable the new DEP8 tests
    - d/t/smbclient-anonymous-share-list: list available shares anonymously
    - d/t/smbclient-authenticated-share-list: list available shares using
      an authenticated connection
    - d/t/smbclient-share-access: create a share and download a file from it
    - d/t/cifs-share-access: access a file in a share using cifs
  * Ask the user if we can run testparm against the config file. If yes,
    include its stderr and exit status in the bug report. Otherwise, only
    include the exit status. (LP: #1694334)
  * If systemctl is available, use it to query the status of the smbd
    service before trying to reload it. Otherwise, keep the same check
    as before and reload the service based on the existence of the
    initscript. (LP: #1579597)
  * Remove d/p/fix-1584485.patch as it builds a broken pam_winbind
    module. There is a fixed version of that patch attached to
    #1677329 but it has not been vetted yet, so for now it's best
    to revert (again) so that pam_winbind can be used.
    (LP: #1677329, LP: #1644428)

 -- Andreas Hasenack <email address hidden> Mon, 19 Jun 2017 10:49:29 -0700

Changed in samba (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers