`stop salt-master` causes upstart to hang

[Peter Waller]

On the Saucy (13.10) 64-bit image provided by Amazon web services, `stop salt-master` causes upstart to hang.

This makes it difficult to even un-install salt-master. I've mentioned this problem upstream* in an issue that shows related behaviour. However, that upstream issue is currently marked "closed" and I'm currently unsure whose side the problem is on.

* https://github.com/saltstack/salt/issues/2166#issuecomment-28231668

[Joe Healy (joehealy)]

I (the debian maintainer) have been able to confirm this bug in saucy.

I suspect it is due to the use of respawn in the /etc/init/salt-master.conf file.

I didn't seem to be able to set the importance, but once salt is installed, shutdowns are severely delayed as the system waits for the salt-master to stop properly.

[Joe Healy (joehealy)]

replacing /etc/init/salt-master.conf with:

description "Salt Master"

start on (net-device-up
          and local-filesystems
          and runlevel [2345])
stop on runlevel [!2345]
limit nofile 100000 100000

script
  # Read configuration variable file if it is present
  [ -f /etc/default/$UPSTART_JOB ] && . /etc/default/$UPSTART_JOB

  exec salt-master
end script

Makes it much happier...

this is based on https://github.com/saltstack/salt/blob/develop/pkg/salt-master.upstart

[Joe Healy (joehealy)]

Regarding whose side the problem is on, I'll be making this change (or very similar) to the debian packaging, which will help the next auto-sync, but I don't know how to make the change in this release (due to not being sure about uploading to ubuntu and also how to deal with a package that "hangs" on uninstall).

Anything I can do to help, please let me know.

[Lionel Porcheron (lionel.porcheron)]

I'm marking this bug as fixed released. In Ubuntu 14.04 we have the last upstart configuration Joe just described.