[MIR] ryu

[Corey Bryant]

[MIR] ryu (specifically python-ryu)

[Availability]
Currently in universe.

[Rationale]
Dependency for Openstack Neutron in Liberty.

[Security]
No security history

[Quality Assurance]
Package works out of the box with no prompting. There are no major bugs in Ubuntu and there are no major bugs in Debian. Unit tests are run during build (in recently uploaded version 3.24-1ubuntu1).

[Dependencies]
All are in main

[Standards Compliance]
FHS and Debian Policy compliant.

[Maintenance]
Python package that the Ubuntu Server Team will take care of.

[Background]
Ryu is a component-based software defined networking framework.

Ryu provides software components with well defined API that make it
easy for developers to create new network management and control
applications. Ryu supports various protocols for managing network
devices, such as OpenFlow, Netconf, OF-config, etc. About OpenFlow,
Ryu supports fully 1.0, 1.2, 1.3, 1.4 and Nicira Extensions.

All of the code is freely available under the Apache 2.0 license. Ryu
is fully written in Python.

[Ubuntu Foundations Team Bug Bot (crichton)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. It seems that your bug report is not filed about a specific source package though, rather it is just filed against Ubuntu in general. It is important that bug reports be filed about source packages so that people interested in the package can find the bugs about it. You can find some hints about determining what package your bug might be about at https://wiki.ubuntu.com/Bugs/FindRightPackage. You might also ask for help in the #ubuntu-bugs irc channel on Freenode.

To change the source package that this bug is filed about visit https://bugs.launchpad.net/ubuntu/+bug/1500950/+editstatus and add the package name in the text box next to the word Package.

[This is an automated message. I apologize if it reached you inappropriately; please just reply to this message indicating so.]

[Matthias Klose (doko)]

 - the packaging itself looks ok
 - I think we should not accept new python modules in main
   which are not already packaged for python3. According to
   the upstream sources, the packages is ready for python3.4.
 - ryu-bin should use python3.
 - The ryu-bin package starts a service as root, and doesn't
   seem to drop privileges, and is accessing the network.
   The MIR misses the security checks mentioned in the
   MIR requirements.

[James Page (james-page)]

I'm proposing to address the py3 support next cycle; formencode needs a version bump and I don't want to take the risk this late in cycle.

Re the ryu-bin package starting a service as root - looking at that now.

[James Page (james-page)]

For the purposes of the MIR, only python-ryu is required in main (neutron uses its openflow features to directly configure openvswitch).

[James Page (james-page)]

Further context:

http://specs.openstack.org/openstack/neutron-specs/specs/liberty/ovs-ofctl-to-python.html

This dependency supports an alternative openvswitch driver implementation; its not the default (that remains as is).

[James Page (james-page)]

Query on IRC re scope of review:

<jamespage> jdstrand, doko: re our later MIR of ryu - https://bugs.launchpad.net/ubuntu/+source/ryu/+bug/1500950
<ubottu> Launchpad bug 1500950 in ryu (Ubuntu) "[MIR] ryu" [High,Incomplete]
<jamespage> openstack neutron is using the python-ryu ofprotocol library to communicate with openvswitch
 which is the bit we need this cycle to support liberty - not the agent process provided by ryu-bin; can we constrain the MIR review on that basis?
 promoting python-ryu to main only this cycle

[James Page (james-page)]

Deferring for wily, we can patch out the ryu dep for this cycle.

[Corey Bryant (corey.bryant)]

Opening this bug back up because python-ryu is no longer optional for Neutron in OpenStack Newton.

[James Page (james-page)]

Default openflow driver for neutron-openvswitch-agent is now native == ryu; this is much more optimal than the 1000's of subprocess calls the agent made using the old driver.

[Michael Terry (mterry)]

Doko, you looked at this before, assigning back to you.

[James Page (james-page)]

Looking back, I need to sortout the py3 support as well.

[James Page (james-page)]

Hmm - not quite:

Installing ryu-manager script to /<<BUILDDIR>>/ryu-3.30+dfsg1/debian/python3-ryu/usr/bin
Installing ryu script to /<<BUILDDIR>>/ryu-3.30+dfsg1/debian/python3-ryu/usr/bin
  File "/usr/lib/python3/dist-packages/ryu/contrib/ovs/db/idl.py", line 189
    except error.Error, e:
                      ^
SyntaxError: invalid syntax

  File "/usr/lib/python3/dist-packages/ryu/contrib/ovs/json.py", line 146
    except UnicodeDecodeError, e:
                             ^
SyntaxError: invalid syntax

  File "/usr/lib/python3/dist-packages/ryu/contrib/ovs/stream.py", line 122
    def open_block((error, stream)):
                   ^
SyntaxError: invalid syntax

  File "/usr/lib/python3/dist-packages/ryu/contrib/ovs/fatal_signal.py", line 93
    except OSError, e:
                  ^
SyntaxError: invalid syntax

  File "/usr/lib/python3/dist-packages/ryu/contrib/ovs/socket_util.py", line 40
    except socket.error, e:
                       ^
SyntaxError: invalid syntax

  File "/usr/lib/python3/dist-packages/ryu/contrib/ovs/daemon.py", line 147
    except IOError, e:
                  ^
SyntaxError: invalid syntax

  File "/usr/lib/python3/dist-packages/ryu/contrib/ovs/poller.py", line 174
    except select.error, e:
                       ^
SyntaxError: invalid syntax

  File "/usr/lib/python3/dist-packages/ryu/contrib/ovs/ovsuuid.py", line 45
    except error.Error, e:
                      ^
SyntaxError: invalid syntax

[James Page (james-page)]

ryu updated to test and build python3-ryu; ryu-bin prefers 3 over 2 for a new install.

I'll submit that back to Debian; note that version 4.4 is in experimental, however that has know incompatibilities with OpenStack, so I'll wait for the 4.5 release before re-syncing with the latest.

[James Page (james-page)]

I've also addressed the concern about the daemon running as root; now runs as 'ryu' user instead. The daemon is an SDN controller - it does not effect state change on the local machine, so no need to run as root.

[James Page (james-page)]

This MIR was been ready for review for the last month, and is currently blocking the second b2 milestone of neutron in Yakkety - any ETA for when it might get reviewed?

b3 is next week - would be nice to be able to test on 16.10 again.

[Michael Terry (mterry)]

Looks OK to me now.

Archive admins: please only promote python-ryu. We don't want ryu-bin in yet (hasn't had a security check and isn't needed yet).

[James Page (james-page)]

Thankyou Michael!

[Matthias Klose (doko)]

Override component to main
ryu 3.30+dfsg1-3ubuntu1 in yakkety: universe/misc -> main
1 publication overridden.

Override component to main
python-ryu 3.30+dfsg1-3ubuntu1 in yakkety amd64: universe/python/optional/100% -> main
python-ryu 3.30+dfsg1-3ubuntu1 in yakkety arm64: universe/python/optional/100% -> main
python-ryu 3.30+dfsg1-3ubuntu1 in yakkety armhf: universe/python/optional/100% -> main
python-ryu 3.30+dfsg1-3ubuntu1 in yakkety i386: universe/python/optional/100% -> main
python-ryu 3.30+dfsg1-3ubuntu1 in yakkety powerpc: universe/python/optional/100% -> main
python-ryu 3.30+dfsg1-3ubuntu1 in yakkety ppc64el: universe/python/optional/100% -> main
python-ryu 3.30+dfsg1-3ubuntu1 in yakkety s390x: universe/python/optional/100% -> main
7 publications overridden.