[MIR] Promote ruby-mime-types-data to main as pcs indirect dependency

Bug #1990568 reported by Lucas Kanashiro
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ruby-mime-types-data (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

[Availability]

The package ruby-mime-types-data is already in Ubuntu universe.

The package ruby-mime-types-data build for the architectures it is designed to work on.

It currently builds and works for architectures: amd64 (arch:all)

Link to package [[https://launchpad.net/ubuntu/+source/ruby-mime-types-data|ruby-mime-types-data]]

[Rationale]

The package ruby-mime-types-data is required in Ubuntu main for ruby-mime-types promotion which is needed by ruby-ethon, and ruby-ethon is a runtime dependency of pcs (the main reason for this promotion).

Ideally, we expect that ruby-mime-types-data (and pcs) will be promoted in the "L" development cycle. The idea is to promote only the ruby-mime-types-data binary.

[Security]

Required links:

https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=mime-types-data

Nothing was found searching for the gem name.

Nothing was found searching in the OSS security mailing list archive.

https://ubuntu.com/security/cves?package=ruby-mime-types-data

Also nothing found in the Ubuntu security tracker.

No CVEs/security issues in this software in the past

No `suid` or `sgid` binaries.

Package does not install services, timers or recurring jobs.

Packages does not open privileged ports (ports < 1024).

Packages does not contain extensions to security-sensitive software
(filters, scanners, plugins, UI skins, ...).

[Quality assurance - function/usage]

The package works well right after install.

[Quality assurance - maintenance]

The package is maintained well in Debian/Ubuntu and has no bugs open:

- Ubuntu https://bugs.launchpad.net/ubuntu/+source/ruby-mime-types-data/+bug
- Debian https://bugs.debian.org/cgi-bin/pkgreport.cgi?src=ruby-mime-types-data

The package does not deal with exotic hardware we cannot support.

[Quality assurance - testing]

The package does not run a test at build time because this is just data, not code to be tested.

The package does not run an autopkgtest because of what was explained above.

This package is minimal and will be tested in a more wide reaching
solution context of pcs, details about this testing are here:

https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1953341

[Quality assurance - packaging]

debian/watch is present and works.

debian/control defines a correct Maintainer field.

`lintian --pedantic` output:

P: ruby-mime-types-data source: silent-on-rules-requiring-root [debian/control]
P: ruby-mime-types-data source: update-debian-copyright 2015 vs 2022 [debian/copyright:10]
P: ruby-mime-types-data source: very-long-line-length-in-source-file data/mime-types.json line 1 is 345873 characters long (>512)

Lintian overrides are not present.

This package does not rely on obsolete or about to be demoted packages.

The package will not be installed by default.

Packaging and build is easy, link to d/rules:

https://git.launchpad.net/~git-ubuntu-import/ubuntu/+source/ruby-mime-types-data/tree/debian/rules

[UI standards]

Application is not end-user facing (does not need translation).

[Dependencies]

No further depends or recommends dependencies that are not yet in main.

[Standards compliance]

This package correctly follows FHS and Debian Policy.

[Maintenance/Owner]

Owning Team will be Server.

Team is not yet, but will subscribe to the package before promotion.

This does not use static builds.

This does not use vendored code.

This package is not rust based.

The package has been built in the archive more recently than the last
test rebuild.

[Background information]

The Package description explains the package well.

Upstream Name is mime-types-data

Link to upstream project: https://github.com/mime-types/mime-types-data/

description: updated
Changed in ruby-mime-types-data (Ubuntu):
assignee: nobody → Ioanna Alifieraki (joalif)
Revision history for this message
Ioanna Alifieraki (joalif) wrote :
Download full text (3.3 KiB)

Review for Package: ruby-mime-types-data

[Summary]
MIR team ACK under the constraint to resolve the below listed
required TODOs and as much as possible having a look at the
recommended TODOs.
This does not need a security review
List of specific binary packages to be promoted to main: ruby-mime-types-data

Notes:
The package does not contain any tests, but this is not a problem since
this is data packaging and no source code.
Required TODOs:
1. The latest upstream release is 2022.0105, the release in Ubuntu and
debian is 2015.1120-1. According to the changelog, there is an update
in 2022 however which pulls in from upstream but the version remains
the same, please take a look at it.

- The package should get a team bug subscriber before being promoted

[Duplication]
There is no other package in main providing the same functionality.

[Dependencies]
OK:
- no other Dependencies to MIR due to this
  - mime-types-data checked with `check-mir`
  - all dependencies can be found in `seeded-in-ubuntu` (already in main)
  - none of the (potentially auto-generated) dependencies (Depends
    and Recommends) that are present after build are not in main
- no -dev/-debug/-doc packages that need exclusion
- No dependencies in main that are only superficially tested requiring
  more tests now.

Problems: None

[Embedded sources and static linking]
OK:
- no embedded source present
- no static linking
- does not have unexpected Built-Using entries
- not a go package, no extra constraints to consider in that regard
- not a rust package, no extra constraints to consider in that regard
- Does not include vendored code

Problems: None

[Security]
OK:
- history of CVEs does not look concerning
- does not run a daemon as root
- does not use webkit1,2
- does not use lib*v8 directly
- does not parse data formats (files [images, video, audio,
  xml, json, asn.1], network packets, structures, ...) from
  an untrusted source.
- does not open a port/socket
- does not process arbitrary web content
- does not use centralized online accounts
- does not integrate arbitrary javascript into the desktop
- does not deal with system authentication (eg, pam), etc)
- does not deal with security attestation (secure boot, tpm, signatures)
- does not deal with cryptography (en-/decryption, certificates, signing, ...)

Problems: None

[Common blockers]
OK:
- does not FTBFS currently
- no new python2 dependency

Problems: None

[Packaging red flags]
OK:
- Ubuntu does not carry a delta
- symbols tracking not applicable for this kind of code.
- d/watch is present and looks ok (if needed, e.g. non-native)
- Upstream update history is good
- Debian/Ubuntu update history is sporadic
- promoting this does not seem to cause issues for MOTUs that so far
  maintained the package
- no massive Lintian warnings
- d/rules is rather clean
- It is not on the lto-disabled list

Problems:
- the current release is packaged

[Upstream red flags]
OK:
- no Errors/warnings during the build
- no incautious use of malloc/sprintf (as far as we can check it)
- no use of sudo, gksu, pkexec, or LD_LIBRARY_PATH (usage is OK inside
  tests)
- no use of user nobody
- no use of setuid
- no important open bugs (crashe...

Read more...

Changed in ruby-mime-types-data (Ubuntu):
assignee: Ioanna Alifieraki (joalif) → nobody
status: New → Incomplete
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for the review Ioanna.

I uploaded version 3.2022.0105-1 to Debian unstable and it should be synced into lunar soon. I also added myself as one of the uploaders. And I will also make sure the server team is subscribed to the package before its promotion.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Latest version is present and subscription done -> move this to the correct "ready" state.

Changed in ruby-mime-types-data (Ubuntu):
status: Incomplete → In Progress
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Showing up in component mismatch now as planned.

Changed in ruby-mime-types-data (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Promoted together with the full PCS stack, details see https://bugs.launchpad.net/ubuntu/+source/pcs/+bug/1953341/comments/13

Changed in ruby-mime-types-data (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.