Sync ruby-ffi-yajl 2.3.1-3 (universe) from Debian unstable (main)

Bug #1871629 reported by Lucas Kanashiro
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ruby-ffi-yajl (Ubuntu)
Fix Released
Wishlist
Unassigned

Bug Description

Please sync ruby-ffi-yajl 2.3.1-3 (universe) from Debian unstable (main)

Changelog entries since current focal version 2.3.1-2build1:

ruby-ffi-yajl (2.3.1-3) unstable; urgency=medium

  * Team upload
  * Add patch to disable test in arm arch
  * Fix package wrt cme
  * Fix insecure link
  * Add Rules-Requires-Root: no

 -- Utkarsh Gupta <email address hidden> Sun, 05 Apr 2020 20:36:35 +0530

Changed in ruby-ffi-yajl (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

debian compat change from 10 to 12 might change things under the cover.
I was torn a bit, but I think it needs no FFe.
+1 on syncing that if it helps to clear migrations - it should be a no-op.

Don't you just want to add debian/patches/disable-test-failing-on-arm-arch.patch ?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

Are these build time tests - if so is there a PPA that shows it works fine now?

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

autopkgtest for ruby-ffi-yajl/2.3.1-2build1: amd64: Pass, arm64: Pass, armhf: Pass, ppc64el: Regression ♻ , s390x: Pass

This fails on PPC, why do you expect it to be fixed by that?

ok the failures at least are on the same file:
Failures:

  1) FFI_Yajl::MapLibraryName #expanded_library_names maps mingw correctly
     Failure/Error: expect(Test.send(:expanded_library_names)).to eq(expanded_library_names)

     RuntimeError:
       CRITICAL: RUBYGEMS_ACTIVATION_MONITOR.owned?: before false -> after true
     # ./spec/ffi_yajl/map_library_name_spec.rb:67:in `block (4 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # NameError:
     # uninitialized constant RSpec::Support::Differ
     # ./spec/ffi_yajl/map_library_name_spec.rb:67:in `block (4 levels) in <top (required)>'

  2) FFI_Yajl::MapLibraryName #expanded_library_names maps aix correctly
     Failure/Error: expect(Test.send(:expanded_library_names)).to eq(expanded_library_names)

     NameError:
       uninitialized constant RSpec::Support::Differ
     # ./spec/ffi_yajl/map_library_name_spec.rb:67:in `block (4 levels) in <top (required)>'

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

I didn't set up a PPA, I can do that to be in the safe side. And the autopkgtest failure was similar to the one faced in Debian and reported upstream: https://github.com/chef/ffi-yajl/issues/106

So I was hoping to get it fixed with this sync, if it is not I'd follow the patch and skip the first test that is failing in Ubuntu but apparently not in Debian.

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

If you check the ppc64el build log you will see that the autopkgtest failing tests were skipped (25 and 27):

  25) FFI_Yajl::MapLibraryName #expanded_library_names maps mingw correctly
     # Temporarily skipped with xit
     # ./spec/ffi_yajl/map_library_name_spec.rb:58

  26) FFI_Yajl::MapLibraryName #expanded_library_names maps mswin correctly
     # Temporarily skipped with xit
     # ./spec/ffi_yajl/map_library_name_spec.rb:58

  27) FFI_Yajl::MapLibraryName #expanded_library_names maps aix correctly
     # Temporarily skipped with xit
     # ./spec/ffi_yajl/map_library_name_spec.rb:58

Since gem2deb-test-runner just runs the upstream test suite against the installed version I expect those tests to be skipped in autopkgtest as well.

Revision history for this message
Christian Ehrhardt  (paelzer) wrote :

OK, thanks for these extra steps.
Sync request triggered

Source package ruby-ffi-yajl is temporarily blacklisted (blacklisted_current). Ubuntu ignores these for now. See also LP: #841372
Source ruby-ffi-yajl -> focal/Proposed: current version 2.3.1-2build1, new version 2.3.1-3
New changes:
ruby-ffi-yajl (2.3.1-3) unstable; urgency=medium

  * Team upload
  * Add patch to disable test in arm arch
  * Fix package wrt cme
  * Fix insecure link
  * Add Rules-Requires-Root: no

 -- Utkarsh Gupta <email address hidden> Sun, 05 Apr 2020 20:36:35 +0530
Sync this package [y|N]? y

Changed in ruby-ffi-yajl (Ubuntu):
status: New → Fix Committed
Mathew Hodson (mhodson)
Changed in ruby-ffi-yajl (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.