gem2deb-test-runner failures with ruby-defaults 1:3.3~ubuntu3

[Pushkar Kulkarni]

The autopkgtests of ruby-attr-encrypted that are run by the gem2deb-test-runner fail (e.g: [1]) with ruby-defaults 1:3.3~ubuntu3 due to a change in the behavior of the MiniTest gem. Ruby 3.3 comes with minitest 5.20.00. Startung version 5.19.0, the MiniTest class is no longer loaded by default. Either the use of "MiniTest" needs to be replaced by "Minitest" or env var MT_COMPAT needs to be defined.

-----

1088s /tmp/autopkgtest.MBvPc8/build.mV3/src/test/test_helper.rb:5:in `<top (required)>': uninitialized constant MiniTest (NameError)
1088s
1088s MiniTest::Test = MiniTest::Unit::TestCase
1088s ^^^^^^^^
1088s Did you mean? Minitest

----

[1] https://objectstorage.prodstack5.canonical.com/swift/v1/AUTH_0f9aae918d5b4744bf7b827671c86842/autopkgtest-oracular/oracular/amd64/r/ruby-attr-encrypted/20240820_142215_b81be@/log.gz

[2] https://docs.seattlerb.org/minitest/History_rdoc.html#label-5.19.0+-2F+2023-07-26

[Pushkar Kulkarni (pushkarnk)]

For now, we could wait for upstream projects to switch to using Minitest (instead of MiniTest) while using the MT_COMPAT solution.

[Athos Ribeiro (athos-ribeiro)]

I wonder if this should be done in the upper layer instead (e.g., gem2deb or gem2deb-test-runner). At least during the transition. Thoughts?

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-crass - 1.0.2-3ubuntu1

---------------
ruby-crass (1.0.2-3ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 13:04:35 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-chronic - 0.10.5-2ubuntu1

---------------
ruby-chronic (0.10.5-2ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rb: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 12:54:15 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-jsonpath - 1.1.0-1ubuntu1

---------------
ruby-jsonpath (1.1.0-1ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 14:06:04 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-clockwork - 3.0.1-1ubuntu1

---------------
ruby-clockwork (3.0.1-1ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 13:00:35 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-safely-block - 0.2.1-2ubuntu1

---------------
ruby-safely-block (0.2.1-2ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 14:18:45 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-default-value-for - 3.4.0-2ubuntu1

---------------
ruby-default-value-for (3.4.0-2ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 13:56:07 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-html2haml - 2.3.0-1ubuntu1

---------------
ruby-html2haml (2.3.0-1ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 14:01:27 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-attr-encrypted - 3.1.0-4ubuntu1

---------------
ruby-attr-encrypted (3.1.0-4ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 12:49:08 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-declarative-option - 0.1.0-1.1ubuntu1

---------------
ruby-declarative-option (0.1.0-1.1ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 13:17:04 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-representable - 3.0.4-1.1ubuntu1

---------------
ruby-representable (3.0.4-1.1ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 14:15:40 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-slim - 4.1.0-3ubuntu1

---------------
ruby-slim (4.1.0-3ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rb: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 14:21:46 +0530

[Launchpad Janitor (janitor)]

This bug was fixed in the package ruby-uber - 0.1.0-1.1ubuntu1

---------------
ruby-uber (0.1.0-1.1ubuntu1) oracular; urgency=medium

  * d/ruby-tests.rake: Define env var MT_COMPAT for compatibility
    with Minitest 5.20.0 in Ruby 3.3 (LP: #2077617)

 -- Pushkar Kulkarni <email address hidden> Thu, 22 Aug 2024 14:45:53 +0530

[Lucas Kanashiro (lucaskanashiro)]

Regarding comment #2 from Athos: I wouldn't change gem2deb to add this temporary flag (to add retro-compatibility of Minitest) since 1) I'd say more than 1k packages uses gem2deb and 20 or so are facing this issue; and 2) this will be removed in the near future from upstream and gem2deb can start to produce some noise (or even a failure depending on how it is implemented), moreover, those packages will become FTBFS. This is more maintenance work for whoever is maintaining the ruby stack in Ubuntu.

The approach adopted in the Debian side and what I did in some of the package that I added a delta in Ubuntu is to actually patch the code to support the newer Minitest version (which is quite simple). With this solution, we can update Minitest to whatever version and the packages will keep building fine. Setting the flag for retro-compatibility is a solution that works from now until we update Minitest to a version which removes this flag.

With all that said, since we are late in the cycle I am welcoming all the help and happy to accept the retro-compatibility flag solution. Thanks Pushkar for submitting the patches, and Athos for sponsoring some of them. I'll check where Athos stopped and I will sponsor the rest.