Timestamp incorrectly calculated for timezones with minute offset

[Ed Swierk]

Binary package hint: rsyslog

If you run rsyslog with $ActionFileDefaultTemplate set to RSYSLOG_FileFormat and set the system timezone to Australia/Adelaide, log messages incorrectly show the offset as +09:08 rather than +09:30.

Affects all versions of rsyslog in oneiric, natty, maverick, and lucid. Fixed upstream.

http://bugzilla.adiscon.com/show_bug.cgi?id=271

[Ed Swierk (eswierk)]

If you run rsyslog with $ActionFileDefaultTemplate set to RSYSLOG_FileFormat and set the system timezone to Australia/Adelaide, log messages incorrectly show the offset as +09:08 rather than +09:30.

getCurrTime() in datetime.c tries to convert the timezone offset in seconds (lBias) to OffsetHour and OffsetMinutes:

  t->OffsetHour = lBias / 3600;
  t->OffsetMinute = lBias % 3600;

lBias % 3600 gives the remainder in seconds, not minutes. Since OffsetMinute is a char, the result is effectively (lBias % 3600) % 256, which happens to be 8 in the case of the Australia/Adelaide timezone.

To fix this bug the second line should instead read:

  t->OffsetMinute = (lBias % 3600) / 60;

[Rgerhards-j (rgerhards-j)]

confirmed as far back as v3 (earlier versions not checked)

[Rgerhards-j (rgerhards-j)]

fixed in 3.22.4, 4.6.6, 5.8.2, 5.9.1. Fix for v6 with next merge (which is a large task to do).

"Official" patch here:

http://git.adiscon.com/?p=rsyslog.git;a=commitdiff;h=da52cbae520e747568162ad558bf01d40658c745

Thanks for the bug report and analysis!