pm-suspend.log needs to be rotated.

Bug #410352 reported by Manoj Iyer
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pm-utils (Ubuntu)
Fix Released
High
James Westby
Karmic
Fix Released
High
James Westby

Bug Description

Binary package hint: rsyslog

pm-suspend.log is written by pm-suspend/resume scripts directly to /var/log directory. For latops that suspends resumes all the time, but has an occasional fail might produce large enough log file and end up getting truncated instead of getting rotated.

We are thinking of writing apport hooks that will file a bug with low priority if we can determine that the failure is a one off failure, and file critical bugs when it fails more often or every time. With the current scheme we will throw away information that will be require to make a correct guess.

I would like to see rsyslog rotate the suspend/resume logs. Also I wonder why pm scripts dont use rsyslog to log these logs but have their own little function to do it, the only reason I could think of is, rsyslog operation might not be atomic, so suspend/resume might be slow?

Related branches

Revision history for this message
Colin Watson (cjwatson) wrote :

Any particular reason this needs to be done in rsyslog rather than having pm-utils rotate them itself?

Manoj Iyer (manjo)
Changed in rsyslog (Ubuntu Karmic):
importance: Undecided → High
Revision history for this message
Colin Watson (cjwatson) wrote :

I'll move this to pm-utils unless somebody explains why it needs to be done in rsyslog.

affects: rsyslog (Ubuntu Karmic) → pm-utils (Ubuntu Karmic)
Revision history for this message
James Westby (james-w) wrote :

I'm confused. The log file is truncated every time, so it doesn't need
rotation due to growing does it?

Is this a proposal to also stop the truncation and append to the logs
each time?

Thanks,

James

Changed in pm-utils (Ubuntu Karmic):
status: New → Incomplete
Revision history for this message
Manoj Iyer (manjo) wrote :

James,

Yes, we want to stop truncation and start appending to the file, and rotate it like its done for other logs in var/log

Colin Watson (cjwatson)
Changed in pm-utils (Ubuntu Karmic):
assignee: nobody → James Westby (james-w)
status: Incomplete → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pm-utils - 1.2.5-2ubuntu5

---------------
pm-utils (1.2.5-2ubuntu5) karmic; urgency=low

  * Don't clear the log file at the start of each operation and
    install a logrotate file so that it doesn't grow too much
    (LP: #410352)

 -- James Westby <email address hidden> Mon, 07 Sep 2009 18:33:14 +0100

Changed in pm-utils (Ubuntu Karmic):
status: Confirmed → Fix Released
Revision history for this message
James Westby (james-w) wrote :

Manoj, I think I implemented what you want, let me know if I didn't.

Thanks,

James

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.