| 2019-03-25 12:04:04 |
Eric Desrochers |
bug |
|
|
added bug |
| 2019-03-25 12:04:24 |
Eric Desrochers |
rsyslog (Ubuntu): status |
New |
Fix Released |
|
| 2019-03-25 12:04:29 |
Eric Desrochers |
nominated for series |
|
Ubuntu Xenial |
|
| 2019-03-25 12:04:29 |
Eric Desrochers |
bug task added |
|
rsyslog (Ubuntu Xenial) |
|
| 2019-03-25 12:04:41 |
Eric Desrochers |
tags |
|
sts |
|
| 2019-03-25 12:04:47 |
Eric Desrochers |
rsyslog (Ubuntu Xenial): status |
New |
In Progress |
|
| 2019-03-25 12:04:49 |
Eric Desrochers |
rsyslog (Ubuntu Xenial): importance |
Undecided |
Medium |
|
| 2019-03-25 12:04:51 |
Eric Desrochers |
rsyslog (Ubuntu Xenial): assignee |
|
Eric Desrochers (slashd) |
|
| 2019-03-25 12:37:14 |
Eric Desrochers |
bug |
|
|
added subscriber Bogdan Kowalczyk |
| 2019-03-25 13:03:12 |
Eric Desrochers |
description |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
* On a Xenial active systemd system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
* On a Xenial active upstart system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only.
Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes; systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no ; invoke-rc.d rsyslog rotate > /dev/null
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
* On a Xenial active systemd system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
* On a Xenial active upstart system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes; systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no ; invoke-rc.d rsyslog rotate > /dev/null
I don't see any reported bug about this new helper for Bionic/Cosmic which has it for a quite a while now.
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
|
| 2019-03-25 13:03:32 |
Eric Desrochers |
description |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
* On a Xenial active systemd system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
* On a Xenial active upstart system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes; systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no ; invoke-rc.d rsyslog rotate > /dev/null
I don't see any reported bug about this new helper for Bionic/Cosmic which has it for a quite a while now.
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
* On a Xenial active systemd system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
* On a Xenial active upstart system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes; systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no ; invoke-rc.d rsyslog rotate > /dev/null
I don't see any reported bug about this new helper for Bionic/Cosmic which has it since their released.
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
|
| 2019-03-25 13:04:05 |
Łukasz Zemczak |
rsyslog (Ubuntu Xenial): status |
In Progress |
Fix Committed |
|
| 2019-03-25 13:04:06 |
Łukasz Zemczak |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2019-03-25 13:04:08 |
Łukasz Zemczak |
bug |
|
|
added subscriber SRU Verification |
| 2019-03-25 13:04:12 |
Łukasz Zemczak |
tags |
sts |
sts verification-needed verification-needed-xenial |
|
| 2019-03-25 13:04:43 |
Eric Desrochers |
description |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
* On a Xenial active systemd system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
* On a Xenial active upstart system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes; systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no ; invoke-rc.d rsyslog rotate > /dev/null
I don't see any reported bug about this new helper for Bionic/Cosmic which has it since their released.
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
* On a Xenial active systemd system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
* On a Xenial active upstart system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
* I don't see any reported bug about this new helper for Bionic/Cosmic which has it since their released.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes:
systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no:
invoke-rc.d rsyslog rotate > /dev/null
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
|
| 2019-03-25 15:58:20 |
Eric Desrochers |
description |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
* On a Xenial active systemd system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
* On a Xenial active upstart system:
Determine the script pick the right decision approach.
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happeneded in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
* I don't see any reported bug about this new helper for Bionic/Cosmic which has it since their released.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes:
systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no:
invoke-rc.d rsyslog rotate > /dev/null
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
* On a Xenial active systemd system:
Determine the script pick the right decision (systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
* On a Xenial active upstart system:
Determine the script pick the right decision (non-systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
* I don't see any reported bug about this new helper for Bionic/Cosmic which has it since their released.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes:
systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no:
invoke-rc.d rsyslog rotate > /dev/null
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
|
| 2019-03-25 15:59:30 |
Eric Desrochers |
description |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
* On a Xenial active systemd system:
Determine the script pick the right decision (systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
* On a Xenial active upstart system:
Determine the script pick the right decision (non-systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
* I don't see any reported bug about this new helper for Bionic/Cosmic which has it since their released.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes:
systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no:
invoke-rc.d rsyslog rotate > /dev/null
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
==============================================
[1] - On a Xenial active systemd system:
==============================================
Determine the script pick the right decision (systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
==============================================
[2] - On a Xenial active upstart system:
==============================================
Determine the script pick the right decision (non-systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
* I don't see any reported bug about this new helper for Bionic/Cosmic which has it since their released.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes:
systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no:
invoke-rc.d rsyslog rotate > /dev/null
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
|
| 2019-03-25 16:07:14 |
Eric Desrochers |
description |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for logrotation
[TEST CASE]
==============================================
[1] - On a Xenial active systemd system:
==============================================
Determine the script pick the right decision (systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
==============================================
[2] - On a Xenial active upstart system:
==============================================
Determine the script pick the right decision (non-systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
* I don't see any reported bug about this new helper for Bionic/Cosmic which has it since their released.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes:
systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no:
invoke-rc.d rsyslog rotate > /dev/null
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
[IMPACT]
Xenial uses systemd as default now, debian salsa 4a49edf26d405726041bee12a42d6f064145c87e, introduce a shell script,
taking advantage of systemctl directly if systemd is active by still keeping Sysv init script as fallback only.
While there is no 'real' impact, I think it make total sense for a systemd Xenial system, to use the systemctl approach for log rotation
It has been brought to my attention by a Ubuntu user that:
"Xenial logrotate is not able to perform full log rotation on a LXC container without the 'sys_ptrace' capability[1] using the Sysv approach, invoke-rc.d just fails"
I have created a test pkg for this user, and the same user was able to conclude that it was working as expected with the systemd approach (systemctl) when sys_ptrace is disable inside the container.
[1] - lxc config set <CONTAINER_NAME> raw.lxc lxc.cap.drop=sys_ptrace
[TEST CASE]
==============================================
[1] - On a Xenial active systemd system:
==============================================
Determine the script pick the right decision (systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
==============================================
[2] - On a Xenial active upstart system:
==============================================
Determine the script pick the right decision (non-systemd approach).
# bash -vx /usr/lib/rsyslog/rsyslog-rotate
Run logrotate which contains 'include /etc/logrotate.d', thus will use the rsyslog log rotation information, now using '/usr/lib/rsyslog/rsyslog-rotate' helper.
# logrotate -vdf /etc/logrotate.conf
Check if logs rotation happened in /var/log.
# ls -altr /var/log
[POTENTIAL REGRESSION
* None, this commit introduced a new shell script (rsyslog-rotate) which uses systemctl directly if systemd is active (default in Xenial) but keeps the original Sysv init script as fallback only. Meaning no behaviour change for users who decided not to use systemd on their Xenial system.
* I don't see any reported bug about this new helper for Bionic/Cosmic which has it since their released.
/usr/lib/rsyslog/rsyslog-rotate:
1) Check if existence of systemd, if yes:
systemctl kill -s HUP rsyslog.service
2) Check if existence of systemd, if no:
invoke-rc.d rsyslog rotate > /dev/null
[OTHER INFO]
* Salsa rsyslog repository:
https://salsa.debian.org/debian/rsyslog/commit/4a49edf26d405726041bee12a42d6f064145c87e
* First introduced:
git describe --contains 4a49edf26d405726041bee12a42d6f064145c87e
debian/8.27.0-4~1
* rmadison:
=> rsyslog | 8.16.0-1ubuntu3 | xenial
rsyslog | 8.32.0-1ubuntu4 | bionic
rsyslog | 8.32.0-1ubuntu5 | cosmic
rsyslog | 8.32.0-1ubuntu7 | disco |
|
| 2019-03-28 12:19:26 |
Eric Desrochers |
tags |
sts verification-needed verification-needed-xenial |
sts verification-done-xenial verification-needed |
|
| 2019-04-01 13:50:38 |
Łukasz Zemczak |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2019-04-01 13:50:37 |
Launchpad Janitor |
rsyslog (Ubuntu Xenial): status |
Fix Committed |
Fix Released |
|
