Add a trigger to reload rsyslog when a new configuration file is dropped in /etc/rsyslog.d

Bug #1668639 reported by Frode Nordahl on 2017-02-28
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rsyslog (Debian)
Fix Released
Unknown
rsyslog (Ubuntu)
Status tracked in Artful
Trusty
Medium
Frode Nordahl
Xenial
Medium
Frode Nordahl
Zesty
Medium
Frode Nordahl
Artful
Medium
Frode Nordahl

Bug Description

[Impact]
Servers or cloud instances will not log important messages after initial deployment. Manual reboot or restart of services is necessary to get expected behaviour.

[Test Case]
1) Install, enable and start haproxy
2) Observe that /etc/rsyslog.d/49-haproxy.conf is installed
3) Observe that /var/lib/haproxy/dev/log and /var/log/haproxy.log is NOT created
4) Restart rsyslog service
5) Observe that /var/lib/haproxy/dev/log and /var/log/haproxy.log IS created
6) Restart haproxy service and observe that log now is filled with entries

With the patched deb steps 3,4 and 6 becomes irrelevant and everything works out of the box.

[Regression Potential]
Minimal.

This patch merges a patch from Debian where a trigger is added to the rsyslog package that fires when other debs drop files into /etc/rsyslog.d.

[Original Bug Description]
rsyslog should reload its configuration when other packages drop configuration in /etc/rsyslog.d

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=791337

https://anonscm.debian.org/cgit/collab-maint/rsyslog.git/commit/?id=8d4074003f8fb19dae07c59dd19f0540a639210f

Frode Nordahl (fnordahl) on 2017-02-28
description: updated
tags: added: sts
Frode Nordahl (fnordahl) on 2017-02-28
tags: added: sts-sponsor

The attachment "rsyslog-yakkety.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Brian Murray (brian-murray) wrote :

This doesn't yet seem to be fixed in Zesty, although debian fixed it in package version 8.24.0-1.

Changed in rsyslog (Debian):
status: Unknown → Fix Released
Changed in rsyslog (Ubuntu):
importance: Undecided → Wishlist
Changed in rsyslog (Ubuntu Trusty):
importance: Undecided → Wishlist
Changed in rsyslog (Ubuntu Xenial):
importance: Undecided → Wishlist
Changed in rsyslog (Ubuntu Yakkety):
importance: Undecided → Wishlist
Louis Bouchard (louis) wrote :

Too late now for sponsorship to Zesty. Since it will come with the next rsyslog merge in 8.24.0-1, well go forward with the SRU post-merge of the next rsyslog

Frode Nordahl (fnordahl) on 2017-06-21
tags: added: sts-sru-needed
removed: sts-sponsor
Eric Desrochers (slashd) on 2017-06-22
Changed in rsyslog (Ubuntu Zesty):
importance: Undecided → Medium
importance: Medium → Wishlist
Changed in rsyslog (Ubuntu Trusty):
assignee: nobody → Frode Nordahl (fnordahl)
Changed in rsyslog (Ubuntu Xenial):
assignee: nobody → Frode Nordahl (fnordahl)
Changed in rsyslog (Ubuntu Yakkety):
assignee: nobody → Frode Nordahl (fnordahl)
Changed in rsyslog (Ubuntu Zesty):
assignee: nobody → Frode Nordahl (fnordahl)
Changed in rsyslog (Ubuntu Artful):
assignee: nobody → Frode Nordahl (fnordahl)
Changed in rsyslog (Ubuntu Trusty):
importance: Wishlist → Low
Changed in rsyslog (Ubuntu Xenial):
importance: Wishlist → Low
Changed in rsyslog (Ubuntu Yakkety):
importance: Wishlist → Low
Changed in rsyslog (Ubuntu Zesty):
importance: Wishlist → Medium
Changed in rsyslog (Ubuntu Xenial):
importance: Low → Medium
Changed in rsyslog (Ubuntu Trusty):
importance: Low → Medium
Changed in rsyslog (Ubuntu Artful):
importance: Wishlist → Medium
Changed in rsyslog (Ubuntu Yakkety):
importance: Low → Medium
Frode Nordahl (fnordahl) wrote :
Eric Desrochers (slashd) on 2017-07-06
Changed in rsyslog (Ubuntu Artful):
status: New → Confirmed
status: Confirmed → In Progress

Looks like this is still missing one additional commit from when it was included in Debian; namely the addition of init-system-helpers in the Depends: field for rsyslog (this makes sure we have a new-enough init-system-helpers so try-restart works).

I'll add it for you in this case. It feels counterproductive for me to reject the change again when you already did go back on it before.

By the way, this means that for a xenial SRU, this would need to be adjusted to the right version number, or that feature will need to be backported...

Eric Desrochers (slashd) wrote :

Hi Frode,

Now that cyphermox sponsored it for Artful ... Could you prepare the debdiff(s) for the affected supported releases ? and I'll sponsored them.

Regards,
Eric

Changed in rsyslog (Ubuntu Artful):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rsyslog - 8.16.0-1ubuntu7

---------------
rsyslog (8.16.0-1ubuntu7) artful; urgency=medium

  * Cherry pick restart on configuration changes fix from Debian (LP: #1668639)
    - Trigger restart on configuration changes.
      Register a dpkg trigger on /etc/rsyslog.d that calls restart on
      configuration changes. (Closes: #791337)
    - Update dpkg trigger to use try-restart.
      Add try-restart action to SysV initscript for that, systemd supports
      this natively.
    - debian/control: Add Depends on init-system-helpers (>= 1.47~) to rsyslog.

 -- Frode Nordahl <email address hidden> Mon, 26 Jun 2017 06:29:30 +0000

Changed in rsyslog (Ubuntu Artful):
status: Fix Committed → Fix Released
Frode Nordahl (fnordahl) wrote :

@cyphermox Thank you!

Frode Nordahl (fnordahl) wrote :

@slashd Thank you! I will start work on debdiffs for the SRU's ASAP.

Simon Quigley (tsimonq2) wrote :

Unsubscribing ~ubuntu-sponsors as there's nothing left to do. Please feel free to resubscribe once patches are ready to upload (or mark your diff as a patch and let the bot do it for you) or if this was done in error.

Thank you!

Frode Nordahl (fnordahl) wrote :

Marking Won't fix for Yakkety as it is EOL.

Removing sts-sru-needed tag until patches are ready.

Changed in rsyslog (Ubuntu Yakkety):
status: New → Won't Fix
tags: removed: sts-sru-needed
Frode Nordahl (fnordahl) wrote :
Eric Desrochers (slashd) on 2017-09-07
Changed in rsyslog (Ubuntu Zesty):
status: New → Confirmed
Changed in rsyslog (Ubuntu Xenial):
status: New → Confirmed
Changed in rsyslog (Ubuntu Trusty):
status: New → Confirmed
Changed in rsyslog (Ubuntu Zesty):
status: Confirmed → In Progress
Changed in rsyslog (Ubuntu Xenial):
status: Confirmed → In Progress
Changed in rsyslog (Ubuntu Trusty):
status: Confirmed → In Progress
no longer affects: rsyslog (Ubuntu Yakkety)
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.