PreserveFQDN fix introduces regression that might cause rsyslog not to start

Bug #1187808 reported by Louis Bouchard on 2013-06-05
50
This bug affects 9 people
Affects Status Importance Assigned to Milestone
rsyslog (Ubuntu)
Critical
Steve Langasek
Precise
Critical
Steve Langasek
Raring
Critical
Steve Langasek

Bug Description

LP: #1022545 fix introduced a regression that might cause rsyslog not to start, even though the upstream commit seems to claim otherwise :

ChangeLog
  A temporary buffer was allocated one byte too small. Did only
  affect startup, not actual operations. Came up during routine tests,
  and can have no effect once the engine runs. Bug was introduced in
  7.3.11.

[Impact]
As reported in duplicate bug #1187876, this issue causes rsyslog to fail to start in some circumstances due to the resulting malloc corruption, which may cause cloud instances to fail to configure themselves correctly on boot. This is a critical regression introduced in an SRU.

[Test case]
1. reproduce the error with rsyslog failing to start, with errors written to /var/log/upstart/rsyslog.log:
*** Error in `rsyslogd': malloc(): memory corruption: 0x00000000007b2930 ***
and verify that 'status rsyslog' shows 'start/spawned' instead of 'start/running'.
2. kill any lingering rsyslog processes with 'sudo killall rsyslogd && sudo stop rsyslog'.
3. upgrade to the -proposed version of the package.
4. verify that rsyslogd is now running ('status rsyslog' shows 'start/running').

[Regression potential]
Minimal. This is a targeted one-character fix for a regression introduced in the previous SRU.

Louis Bouchard (louis) wrote :
Changed in rsyslog (Ubuntu):
assignee: nobody → Louis Bouchard (louis-bouchard)
status: New → Confirmed
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in rsyslog (Ubuntu Precise):
status: New → Confirmed
Changed in rsyslog (Ubuntu Raring):
status: New → Confirmed
Steve Langasek (vorlon) on 2013-06-05
Changed in rsyslog (Ubuntu):
status: Confirmed → In Progress
assignee: Louis Bouchard (louis-bouchard) → Steve Langasek (vorlon)
Changed in rsyslog (Ubuntu Precise):
status: Confirmed → In Progress
assignee: nobody → Steve Langasek (vorlon)
Changed in rsyslog (Ubuntu Raring):
status: Confirmed → In Progress
assignee: nobody → Steve Langasek (vorlon)
importance: Undecided → Critical
Changed in rsyslog (Ubuntu Precise):
importance: Undecided → Critical
Changed in rsyslog (Ubuntu):
importance: Undecided → Critical
tags: added: regression-update
Steve Langasek (vorlon) on 2013-06-05
description: updated

Hello Louis, or anyone else affected,

Accepted rsyslog into raring-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/rsyslog/5.8.11-2ubuntu2.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in rsyslog (Ubuntu Raring):
status: In Progress → Fix Committed
tags: added: verification-needed
Adam Conrad (adconrad) wrote :

Hello Louis, or anyone else affected,

Accepted rsyslog into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/rsyslog/5.8.6-1ubuntu8.4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in rsyslog (Ubuntu Precise):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rsyslog - 5.8.11-2ubuntu4

---------------
rsyslog (5.8.11-2ubuntu4) saucy; urgency=low

  * Adjust rsyslog init script to detect upstart, making the upstart
    patches upstreamable to Debian.
  * Add versioned dependency on lsb-base for the use of init_is_upstart.
  * debian/patches/202-off-by-one-regression-1187808.patch: upstream fix
    for an off-by-one error introduced in the previous cherry-pick, causing
    rsyslog to fail to start in some environments. Closes LP: #1187808.
 -- Steve Langasek <email address hidden> Wed, 05 Jun 2013 12:09:22 -0700

Changed in rsyslog (Ubuntu):
status: In Progress → Fix Released
Steve Langasek (vorlon) wrote :

I've reproduced the original bug in raring, and verified that the package in -proposed fixes the issue, allowing rsyslog to start.

I have not reproduced the original bug in precise, but have verified that after upgrade the new version of rsyslog still starts correctly.

Considering this verified.

tags: added: verification-done
removed: verification-needed
Simon Déziel (sdeziel) wrote :

Precise's version works fine here but I was never able to reproduce the startup issue so just one more data point for verification.

Sebastian Guarino (junkmail-r) wrote :

Fixed the issue for me too in raring with rsyslog/raring-proposed (x86_64 version).

Thanks,
Sebastián

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rsyslog - 5.8.6-1ubuntu8.4

---------------
rsyslog (5.8.6-1ubuntu8.4) precise-proposed; urgency=low

  * debian/patches/202-off-by-one-regression-1187808.patch: upstream fix
    for an off-by-one error introduced in the previous cherry-pick, causing
    rsyslog to fail to start in some environments. Closes LP: #1187808.
 -- Steve Langasek <email address hidden> Wed, 05 Jun 2013 12:36:11 -0700

Changed in rsyslog (Ubuntu Precise):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rsyslog - 5.8.11-2ubuntu2.2

---------------
rsyslog (5.8.11-2ubuntu2.2) raring-proposed; urgency=low

  * debian/patches/202-off-by-one-regression-1187808.patch: upstream fix
    for an off-by-one error introduced in the previous cherry-pick, causing
    rsyslog to fail to start in some environments. Closes LP: #1187808.
 -- Steve Langasek <email address hidden> Wed, 05 Jun 2013 12:26:19 -0700

Changed in rsyslog (Ubuntu Raring):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers