Bug #1455174 “Rsnapshot installed by ubuntu has a major flaw” : Bugs : rsnapshot package : Ubuntu

Revision history for this message

Micah Gersten (micahg) wrote on 2015-05-14:

#1

Thank you for reporting this to Ubuntu. Was this not fixed in Bug #1309710?

Changed in rsnapshot (Ubuntu):
status:	New → Incomplete

Revision history for this message

bob (coyote4til7) wrote on 2015-05-14:

#2

Download full text (8.0 KiB)

It certainly does sound like they're related.

But, the discussion over there is a bit convoluted: I'm merging! I'm not merging! Merging! so it's not clear that someone even intended to actually merge the changes into the code let alone did.

In this case, I installed Ubunut 14.04 this machine about a month ago and updated everything at that point. To be sure, I re-ran the update today. If it was merged in, it isn't pulled in during install or updates for 14.04.

It's quite easy to reproduce. Remote backups without Excludes work. If I have three excludes (things I don't want to back), it does blow up. A backup of the config file that does exactly that is below (sans a bunch of tailing commented-out examples at the end). The key lines are:

exclude /mnt/4bay0/Virtual\ Machines*
exclude /mnt/4bay0/Dropbox*
exclude /mnt/4bay0/MachineImages
backup root@vm143:/home/ VM143/

Of course, root has to have a key file setup with the other machine first, blah, blah.

Part of what made it glaringly obvious that there was something weird going on is that when you run rsnapshot at the CLI (e.g. /usr/bin/rsnapshot hourly), it will spit out each command along with any errors. The rsync error is "1" which is supposed to mean a bad argument. When I simply took the rsync command that was erroring and pasted it back in (after removing the backslashes), they just worked.

#######################
# CONFIG FILE VERSION #
#######################

config_version 1.2

###########################
# SNAPSHOT ROOT DIRECTORY #
###########################

# All snapshots will be stored under this root directory.
snapshot_root /mnt/bkups/rsnapshot/

# If no_create_root is enabled, rsnapshot will not automatically create the
# snapshot_root directory. This is particularly useful if you are backing
# up to removable media, such as a FireWire or USB drive.
#
#no_create_root 1

#################################
# EXTERNAL PROGRAM DEPENDENCIES #
#################################

# LINUX USERS: Be sure to uncomment "cmd_cp". This gives you extra features.
# EVERYONE ELSE: Leave "cmd_cp" commented out for compatibility.
#
# See the README file or the man page for more details.
#
cmd_cp /bin/cp

# uncomment this to use the rm program instead of the built-in perl routine.
#
cmd_rm /bin/rm

# rsync must be enabled for anything to work. This is the only command that
# must be enabled.
#
cmd_rsync /usr/bin/rsync

# Uncomment this to enable remote ssh backups over rsync.
#
cmd_ssh /usr/bin/ssh

# Comment this out to disable syslog support.
#
cmd_logger /usr/bin/logger

# Uncomment this to specify the path to "du" for disk usage checks.
# If you have an older version of "du", you may also want to check the
# "du_args" parameter below.
#
#cmd_du /usr/bin/du

# Uncomment this to specify the path to rsnapshot-diff.
#
#cmd_rsnapshot_diff /usr/bin/rsnapshot-diff

# Specify the path to a script (and any optional arguments) to run right
# before rsnapshot syncs files
#
#cmd_preexec /home/twood/bin/rsnapshot-preexec.sh

# Specify the path to a script (and any optional arguments) to run right
# after rsnapshot syncs files
#
#cmd_postexec /path/to/postexec/script

# Paths to lvcrea...

It certainly does sound like they're related.

But, the discussion over there is a bit convoluted: I'm merging! I'm not merging! Merging! so it's not clear that someone even intended to actually merge the changes into the code let alone did.

In this case, I installed Ubunut 14.04 this machine about a month ago and updated everything at that point. To be sure, I re-ran the update today. If it was merged in, it isn't pulled in during install or updates for 14.04.

It's quite easy to reproduce. Remote backups without Excludes work. If I have three excludes (things I don't want to back), it does blow up. A backup of the config file that does exactly that is below (sans a bunch of tailing commented-out examples at the end). The key lines are:

exclude	/mnt/4bay0/Virtual\ Machines*
exclude	/mnt/4bay0/Dropbox*
exclude	/mnt/4bay0/MachineImages
backup	root@vm143:/home/	VM143/

Of course, root has to have a key file setup with the other machine first, blah, blah.

Part of what made it glaringly obvious that there was something weird going on is that when you run rsnapshot at the CLI (e.g. /usr/bin/rsnapshot hourly), it will spit out each command along with any errors. The rsync error is "1" which is supposed to mean a bad argument. When I simply took the rsync command that was erroring and pasted it back in (after removing the backslashes), they just worked.

#######################
# CONFIG FILE VERSION #
#######################

config_version	1.2

###########################
# SNAPSHOT ROOT DIRECTORY #
###########################

# All snapshots will be stored under this root directory.
snapshot_root	/mnt/bkups/rsnapshot/

# If no_create_root is enabled, rsnapshot will not automatically create the
# snapshot_root directory. This is particularly useful if you are backing
# up to removable media, such as a FireWire or USB drive.
#
#no_create_root	1

#################################
# EXTERNAL PROGRAM DEPENDENCIES #
#################################

# LINUX USERS:   Be sure to uncomment "cmd_cp". This gives you extra features.
# EVERYONE ELSE: Leave "cmd_cp" commented out for compatibility.
#
# See the README file or the man page for more details.
#
cmd_cp		/bin/cp

# uncomment this to use the rm program instead of the built-in perl routine.
#
cmd_rm		/bin/rm

# rsync must be enabled for anything to work. This is the only command that
# must be enabled.
#
cmd_rsync	/usr/bin/rsync

# Uncomment this to enable remote ssh backups over rsync.
#
cmd_ssh	/usr/bin/ssh

# Comment this out to disable syslog support.
#
cmd_logger	/usr/bin/logger

# Uncomment this to specify the path to "du" for disk usage checks.
# If you have an older version of "du", you may also want to check the
# "du_args" parameter below.
#
#cmd_du		/usr/bin/du

# Uncomment this to specify the path to rsnapshot-diff.
#
#cmd_rsnapshot_diff	/usr/bin/rsnapshot-diff

# Specify the path to a script (and any optional arguments) to run right
# before rsnapshot syncs files
#
#cmd_preexec	/home/twood/bin/rsnapshot-preexec.sh

# Specify the path to a script (and any optional arguments) to run right
# after rsnapshot syncs files
#
#cmd_postexec	/path/to/postexec/script

# Paths to lvcreate, lvremove, mount and umount commands, for use with
# Linux LVMs.
#
#linux_lvm_cmd_lvcreate	/sbin/lvcreate
#linux_lvm_cmd_lvremove	/sbin/lvremove
#linux_lvm_cmd_mount	/bin/mount
#linux_lvm_cmd_umount	/bin/umount

#########################################
#           BACKUP INTERVALS            #
# Must be unique and in ascending order #
# i.e. hourly, daily, weekly, etc.      #
#########################################

retain		hourly	6
retain		daily	7
retain		weekly	4
retain		monthly	2

############################################
#              GLOBAL OPTIONS              #
# All are optional, with sensible defaults #
############################################

# Verbose level, 1 through 5.
# 1     Quiet           Print fatal errors only
# 2     Default         Print errors and warnings only
# 3     Verbose         Show equivalent shell commands being executed
# 4     Extra Verbose   Show extra verbose information
# 5     Debug mode      Everything
# Default:2
verbose		5

# Same as "verbose" above, but controls the amount of data sent to the
# logfile, if one is being used. The default is 3.
#
# Default:3
loglevel	3

# If you enable this, data will be written to the file you specify. The
# amount of data written is controlled by the "loglevel" parameter.
#
logfile	/var/log/rsnapshot.log

# If enabled, rsnapshot will write a lockfile to prevent two instances
# from running simultaneously (and messing up the snapshot_root).
# If you enable this, make sure the lockfile directory is not world
# writable. Otherwise anyone can prevent the program from running.
#
lockfile	/var/run/rsnapshot.pid

# By default, rsnapshot check lockfile, check if PID is running
# and if not, consider lockfile as stale, then start
# Enabling this stop rsnapshot if PID in lockfile is not running
#
#stop_on_stale_lockfile		0

# Default rsync args. All rsync commands have at least these options set.
#
#rsync_short_args	-a
#rsync_long_args	--delete --numeric-ids --relative --delete-excluded

# ssh has no args passed by default, but you can specify some here.
#
# ssh_args	-o BatchMode=yes -p 22

# Default arguments for the "du" program (for disk space reporting).
# The GNU version of "du" is preferred. See the man page for more details.
# If your version of "du" doesn't support the -h flag, try -k flag instead.
#
#du_args	-csh

# If this is enabled, rsync won't span filesystem partitions within a
# backup point. This essentially passes the -x option to rsync.
# The default is 0 (off).
#
#one_fs		0

# The include and exclude parameters, if enabled, simply get passed directly
# to rsync. If you have multiple include/exclude patterns, put each one on a
# separate line. Please look up the --include and --exclude options in the
# rsync man page for more details on how to specify file name patterns. 
# 
#include	???
#include	???
#exclude	???
#exclude	???
exclude	/mnt/4bay0/Virtual\ Machines*
exclude	/mnt/4bay0/Dropbox*
exclude	/mnt/4bay0/MachineImages

# The include_file and exclude_file parameters, if enabled, simply get
# passed directly to rsync. Please look up the --include-from and
# --exclude-from options in the rsync man page for more details.
#
#include_file	/path/to/include/file
#exclude_file	/path/to/exclude/file

# If your version of rsync supports --link-dest, consider enable this.
# This is the best way to support special files (FIFOs, etc) cross-platform.
# The default is 0 (off).
#
#link_dest	0

# When sync_first is enabled, it changes the default behaviour of rsnapshot.
# Normally, when rsnapshot is called with its lowest interval
# (i.e.: "rsnapshot hourly"), it will sync files AND rotate the lowest
# intervals. With sync_first enabled, "rsnapshot sync" handles the file sync,
# and all interval calls simply rotate files. See the man page for more
# details. The default is 0 (off).
#
#sync_first	0

# If enabled, rsnapshot will move the oldest directory for each interval
# to [interval_name].delete, then it will remove the lockfile and delete
# that directory just before it exits. The default is 0 (off).
#
#use_lazy_deletes	0

# Number of rsync re-tries. If you experience any network problems or
# network card issues that tend to cause ssh to crap-out with
# "Corrupted MAC on input" errors, for example, set this to a non-zero
# value to have the rsync operation re-tried
#
rsync_numtries	1

# LVM parameters. Used to backup with creating lvm snapshot before backup
# and removing it after. This should ensure consistency of data in some special
# cases
#
# LVM snapshot(s) size (lvcreate --size option).
#
#linux_lvm_snapshotsize	100M

# Name to be used when creating the LVM logical volume snapshot(s).
#
#linux_lvm_snapshotname	rsnapshot

# Path to the LVM Volume Groups.
#
#linux_lvm_vgpath	/dev

# Mount point to use to temporarily mount the snapshot(s).
#
#linux_lvm_mountpath	/path/to/mount/lvm/snapshot/during/backup

###############################
### BACKUP POINTS / SCRIPTS ###
###############################

backup	/mnt/4bay0/	HEK/

backup	root@vm143:/home/	VM143/

Revision history for this message

Launchpad Janitor (janitor) wrote on 2015-07-14:

#3

[Expired for rsnapshot (Ubuntu) because there has been no activity for 60 days.]

Changed in rsnapshot (Ubuntu):
status:	Incomplete → Expired

Ubuntu
rsnapshot package

Rsnapshot installed by ubuntu has a major flaw

Bug Description

Other bug subscribers

Remote bug watches

Ubuntursnapshot package

Rsnapshot installed by ubuntu has a major flaw

Bug Description

Other bug subscribers

Remote bug watches

Ubuntu
rsnapshot package