Ubuntu

please update pppoe to new upstream version

Reported by Igor A Tarasov on 2011-01-21
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rp-pppoe (Debian)
New
Unknown
rp-pppoe (Ubuntu)
Wishlist
Unassigned

Bug Description

There are new upstream version 3.10 is published: http://www.roaringpenguin.com/files/download/rp-pppoe-3.10.tar.gz
instead of those 3.8 included in distribution. The new version add new functionality and fix some bugs. Please, consider to update pppoe to new upstream version.

tags: added: upgrade-software-version
tags: removed: 3.10 upsteream
Changed in rp-pppoe (Debian):
status: Unknown → New
Changed in rp-pppoe (Ubuntu):
status: New → Confirmed
importance: Undecided → Wishlist
Whoopie (whoopie79) wrote :

Latest upstream version is 3.11.

I added the release to my testing PPA.

Whoopie (whoopie79) wrote :

Please find attached a new package for rp-pppoe 3.11. Based on the work by Lee (Debian bug report 602861), the package now has a patches directory with split patches.

I have put the following files into the rp-pppoe.tar.gz:
rp-pppoe_3.11-0ubuntu1.dsc
rp-pppoe_3.11-0ubuntu1.debian.tar.gz
rp-pppoe_3.11.orig.tar.gz

What I did more is written in the changelog:
rp-pppoe (3.11-0ubuntu1) raring; urgency=low

  * New upstream release
  * debian/control: Add Build-Depend on ppp-dev.
  * debian/rules: Specify "--enable-plugin" to get kernel support.
  * debian/patches/08_delegate-ip-addresses.patch: Delegate the
    allocation of IP addresses to pppd (LP: #705872).
  * debian/patches/09_pppoe-intermediate-agent-v0.04.patch:
    Add PPPoE Intermediate Agent support, patch taken from the
    ilc-ppp project.
  * debian/patches/10_remove-ppp-plugin-path.patch: Remove plugin
    path so that pppoe-server uses ppp's plugin directory.

 -- Whoopie <email address hidden> Tue, 05 Feb 2013 11:57:29 +0100

It looks pretty good, but I'm not entirely confident in including such a large patch (re. PPPoE Intermediate Agent support) considering there hasn't been any upstream review yet.

To ease review in the future, could you please provide the changes as a debdiff or a bzr merge proposal instead? Thanks!

Changed in rp-pppoe (Ubuntu):
status: Confirmed → Incomplete
Whoopie (whoopie79) wrote :

@Mathieu: if you prefer, I can remove the "PPPoE Intermediate Agent" patch. But is the rest okay for you?

Stéphane Graber (stgraber) wrote :

Unless you can make a strong case for having this patch in Ubuntu, I think it'd be best not to deviate so much from upstream.

Bryce Harrington (bryce) wrote :

[Unsubscribing sponsors for now; re-subscribe ubuntu-sponsors when the aforementioned issues have been resolved.]

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.