pppoe-server handles offset option incorrectly

[Arne Bernin]

I try to setup a pppoe-server for test purposes.
As we need multiple servers on different
interfaces, we need the offset option to
start from different offsets for the pppX interface
on different (physical) interfaces.

The pppoe-server provided by rp-pppoe has 2 options for
this: -o gives an offset to use, and -u tells pppoe-server
to pass this offset to the pppd when starting a new one.
Unfortunatly, this does not work, as the offset seems
to be added to the session created internally, but
when passing it to the pppd daemon, the session offset
is subtracted again.

I think, this is a bug, the line

1696 sprintf(buffer, "%u", (unsigned int) (ntohs(session->sess) - 1 - SessOffset));

should be

1696 sprintf(buffer, "%u", (unsigned int) (ntohs(session->sess) - 1));

after changing it, everything works as expected.

----------------------------------------------

ii pppoe 3.8-3 PPP over Ethernet driver