keyboard_shortcuts plugin is unloadable due to misnamed directory

[Dara Poon]

The name of the directory containing each plugin must match the name of its primary PHP file. This is according to /usr/share/roundcube/program/lib/Roundcube/rcube_plugin_api.php, line 168 (in the load_plugin() method):

            $fn = "$plugins_dir/$plugin_name/$plugin_name.php";

… and line 194:

            $plugin = new $plugin_name($this);

However, roundcube-plugins-extra-1.1.3-20151025 (part of 16.04 LTS) installs

    /var/lib/roundcube/plugins/keyboard-shortcuts/keyboard_shortcuts.php

… which defines a keyboard_shortcuts class. The mismatch between "keyboard-shortcuts" and "keyboard_shorcuts" makes it impossible to load the keyboard_shortcuts plugin. The directory name must be changed to use an underscore, since the hyphen is not part of a valid PHP class name.

Workaround:

    sudo ln -s keyboard-shortcuts /var/lib/roundcube/plugins/keyboard_shortcuts

[Dara Poon (dpoon)]

Other plugins are similarly affected:

$ dpkg -S /usr/share/roundcube/plugins/*-*
roundcube-plugins-extra: /usr/share/roundcube/plugins/compose-addressbook
roundcube-plugins-extra: /usr/share/roundcube/plugins/dovecot-impersonate
roundcube-plugins-extra: /usr/share/roundcube/plugins/keyboard-shortcuts
roundcube-plugins-extra: /usr/share/roundcube/plugins/message-highlight
roundcube-plugins-extra: /usr/share/roundcube/plugins/thunderbird-labels