| 2024-04-09 17:23:40 |
Scott K Logan |
bug |
|
|
added bug |
| 2024-04-09 17:23:40 |
Scott K Logan |
attachment added |
|
0001-Fix-argument-parsing-in-newer-Python.patch https://bugs.launchpad.net/bugs/2060717/+attachment/5762890/+files/0001-Fix-argument-parsing-in-newer-Python.patch |
|
| 2024-04-09 17:27:26 |
Launchpad Janitor |
ros2-colcon-core (Ubuntu): status |
New |
Confirmed |
|
| 2024-04-09 20:19:44 |
Ubuntu Foundations Team Bug Bot |
tags |
|
patch |
|
| 2024-04-09 20:19:49 |
Ubuntu Foundations Team Bug Bot |
bug |
|
|
added subscriber Ubuntu Review Team |
| 2024-04-10 17:15:47 |
Jose Luis Rivero |
merge proposal linked |
|
https://code.launchpad.net/~j-rivero/ubuntu/+source/ros2-colcon-core/+git/ros2-colcon-core/+merge/464037 |
|
| 2024-04-10 17:21:23 |
Jose Luis Rivero |
description |
Recent changes to Python which have been backported to Python 3.11 and 3.12 break colcon argument parsing due to a dependency on private API in argparse.
A fix has been released in colcon-core 0.16.1 which should be backported to any platforms which will receive the updated Python releases.
The python3-colcon-core package currently in Ubuntu Noble is suffering from this issue now.
https://github.com/colcon/colcon-core/pull/635 |
Patch version to solve a critical problem with colcon argument parsing mechanism.
* Merge request: https://code.launchpad.net/~j-rivero/ubuntu/+source/ros2-colcon-core/+git/ros2-colcon-core/+merge/464037
* PPA related: https://code.launchpad.net/~j-rivero/+archive/ubuntu/noble-pkgs
[Justification]
Recent changes to Python which have been backported to Python 3.11 and 3.12 break colcon argument parsing due to a dependency on private API in argparse. A fix has been released in colcon-core 0.16.1 which should be backported to any platforms which will receive the updated Python releases. The python3-colcon-core package currently in Ubuntu Noble is suffering from this issue now.
The current version in 0.15.2-1 fails to build due to problem in the test suite that detect this problem: https://code.launchpad.net/~j-rivero/+archive/ubuntu/noble-pkgs/+build/28042968
A quick test on Noble reports the problem:
--------------------- 8< ----------------------------------------
$ mkdir /tmp/colcon-repro && cd /tmp/colcon-repro
$ colcon build --cmake-args --no-warn-unused-cli
Expected:
Summary: 0 packages finished
Actual:
usage: colcon [-h] [--log-base LOG_BASE] [--log-level LOG_LEVEL] {build,extension-points,extensions,graph,info,list,metadata,test,test-result,version-check} ...
colcon: error: unrecognized arguments: --no-warn-unused-cli
--------------------- 8< ----------------------------------------
[testing done]
After using the changes proposed:
--------------------- 8< ----------------------------------------
jrivero@22d248d84027:~/code/ubuntu$ sudo dpkg -i python3-colcon-core_0.15.2-1ubuntu1_all.deb
(Reading database ... 58627 files and directories currently installed.)
Preparing to unpack python3-colcon-core_0.15.2-1ubuntu1_all.deb ...
Unpacking python3-colcon-core (0.15.2-1ubuntu1) over (0.15.2-1) ...
Setting up python3-colcon-core (0.15.2-1ubuntu1) ...
jrivero@22d248d84027:/tmp/colcon-repro$ colcon build --cmake-args --no-warn-unused-cli
Summary: 0 packages finished [0.28s]
--------------------- 8< ----------------------------------------
Playing with other colcon workspaces does not show any problem to
my eyes when passing different cmake-args like modifying the CMAKE_BUILD_TYPE.
[Original Scott email]
--- 8< ---------------------------
Recent changes to Python which have been backported to Python 3.11 and 3.12 break colcon argument parsing due to a dependency on private API in argparse.
A fix has been released in colcon-core 0.16.1 which should be backported to any platforms which will receive the updated Python releases.
The python3-colcon-core package currently in Ubuntu Noble is suffering from this issue now.
https://github.com/colcon/colcon-core/pull/635 |
|
| 2024-04-10 17:22:03 |
Jose Luis Rivero |
summary |
colcon-core argument parsing is broken by recent changes to Python 3.11+ |
[FFe] colcon-core argument parsing is broken by recent changes to Python 3.11+ |
|
| 2024-04-10 17:22:09 |
Jose Luis Rivero |
tags |
patch |
noble patch |
|
| 2024-04-10 17:23:49 |
Jose Luis Rivero |
bug |
|
|
added subscriber Ubuntu Release Team |
| 2024-04-11 12:45:01 |
Benjamin Drung |
ros2-colcon-core (Ubuntu): status |
Confirmed |
Fix Committed |
|
| 2024-04-11 12:45:04 |
Benjamin Drung |
ros2-colcon-core (Ubuntu): importance |
Undecided |
High |
|
| 2024-04-11 12:46:07 |
Benjamin Drung |
removed subscriber Ubuntu Review Team |
|
|
|
| 2024-04-11 12:46:09 |
Benjamin Drung |
bug |
|
|
added subscriber Benjamin Drung |
| 2024-04-13 06:35:45 |
Launchpad Janitor |
ros2-colcon-core (Ubuntu): status |
Fix Committed |
Fix Released |
|
