Ristretto crashes when opening SVG files

[Joshua O'Leary]

Ristretto works fine on bitmap-based files (png, jpeg etc.) but just crashes upon opening SVG files.

To reproduce:

1. Right click on a file (in preferred file manager) > open with > ristretto
2. It crashes

OR

1. Launch Ristretto
2. File>Open... Select SVG file
3. It crashes

ProblemType: Bug
DistroRelease: Ubuntu 12.10
Package: ristretto 0.6.3-0ubuntu1
ProcVersionSignature: Ubuntu 3.5.0-21.32-generic 3.5.7.1
Uname: Linux 3.5.0-21-generic i686
ApportVersion: 2.6.1-0ubuntu9
Architecture: i386
Date: Sat Jan 12 18:20:30 2013
InstallationDate: Installed on 2012-10-28 (76 days ago)
InstallationMedia: Xubuntu 12.10 "Quantal Quetzal" - Release i386 (20121017.1)
MarkForUpload: True
SourcePackage: ristretto
UpgradeStatus: No upgrade log present (probably fresh install)

[Steve Dodier-Lazaro (sidi)]

Hi,

Everything in the title, latest Arch as of 2012-11-15, Ristretto 0.6.3, librsvg installed.

Ristretto works and displays SVGs when the thumbnail bar has been disabled, otherwise instead it will hang.

[Steve Dodier-Lazaro (sidi)]

I set the severity to major because the bug occurs with 100% reproducibility under default settings.

[Stephan Arts (stephan-xfce)]

Weird, I thought that was fixed prior to 0.3...

Must be some race-condition, do you have a coredump?

[Stephan Arts (stephan-xfce)]

Hmm, I can reproduce... but it also fails when the thumbnailbar is disabled here.

Are you sure it works without the thumbnailbar with you?

[Stephan Arts (stephan-xfce)]

I am inclined to think this behaviour is not new to 0.6, so either something broke in gtk/librsvg, or it is already broken in 0.3.

Can you compile 0.6 on xubuntu 12.04 and test it there? - Iirc, only libxfce4ui and libxfce4util are out-of date. So you only need to compile those 3 packages.

[Simon Steinbeiß (ochosi)]

I just compiled git master in Xubuntu 12.04 and can confirm the bug.

[Simon Steinbeiß (ochosi)]

(In reply to comment #5)
> I just compiled git master in Xubuntu 12.04 and can confirm the bug.

I forgot to add that I can also confirm the bug with ristretto 0.3.6 (which is shipped with 12.04).

[Stephan Arts (stephan-xfce)]

Simon: does it occur when the thumbnailbar is disabled too?

[Simon Steinbeiß (ochosi)]

Happens to me either way.

[Stephan Arts (stephan-xfce)]

This can not be reproduced on fedora 18 with librsvg-2.36.4

[Stephan Arts (stephan-xfce)]

Which versions of librsvg, libcairo and gtk-2 do you have?

[EwenS (stephen-ewen)]

I can confirm this. Removing $HOME config files for Ristretto and letting them re-propagate does not solve the issue.

[b3nmore (b3nmore)]

Having this issue on xubuntu 12.04 with:
ristretto: 0.6.3 (from raring)
librsvg: 2.36.1
libcairo: 1.10.2
gtk-2: 2.24.10
No matter if the thumbnail bar is on or off.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Raphgro (raphgro)]

I can reproduce with Fedora 18.

ristretto-0.6.3-1.fc18.x86_64
librsvg2-2.36.4-1.fc18.x86_64
cairo-1.12.14-2.fc18.x86_64
gtk2-2.24.19-1.fc18.x86_64

[Raphgro (raphgro)]

Created attachment 5094
hang with libreoffice4 logo

$ strace ristretto ./opt/libreoffice4.0/program/flat_logo.svg
…
lstat("/opt/libreoffice4.0/program/flat_logo.svg", {st_mode=S_IFREG|0644, st_size=29230, ...}) = 0
open("/opt/libreoffice4.0/program/flat_logo.svg", O_RDONLY) = 12
fstat(12, {st_mode=S_IFREG|0644, st_size=29230, ...}) = 0
mmap(NULL, 4096, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x7febe1ad7000
read(12, "<?xml version=\"1.0\" encoding=\"UT"..., 4096) = 4096
open("/usr/share/locale/de_DE.UTF-8/LC_MESSAGES/libexif-12.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
open("/usr/share/locale/de_DE.utf8/LC_MESSAGES/libexif-12.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
open("/usr/share/locale/de_DE/LC_MESSAGES/libexif-12.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
open("/usr/share/locale/de.UTF-8/LC_MESSAGES/libexif-12.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
open("/usr/share/locale/de.utf8/LC_MESSAGES/libexif-12.mo", O_RDONLY) = -1 ENOENT (No such file or directory)
open("/usr/share/locale/de/LC_MESSAGES/libexif-12.mo", O_RDONLY) = 13
fstat(13, {st_mode=S_IFREG|0644, st_size=115655, ...}) = 0
mmap(NULL, 115655, PROT_READ, MAP_PRIVATE, 13, 0) = 0x7febe1aba000
close(13) = 0
close(12) = 0
munmap(0x7febe1ad7000, 4096) = 0
lstat("/usr/share/icons/elementary/actions/24/document-save-as.svg", {st_mode=S_IFREG|0644, st_size=22089, ...}) = 0
open("/usr/share/icons/elementary/actions/24/document-save-as.svg", O_RDONLY) = 12
fstat(12, {st_mode=S_IFREG|0644, st_size=22089, ...}) = 0
read(12, "<?xml version=\"1.0\" encoding=\"UT"..., 65536) = 22089
futex(0x1b86270, FUTEX_WAIT_PRIVATE, 2, NULL <unfinished ...>
+++ killed by SIGKILL +++

[Steve Dodier-Lazaro (sidi)]

I cannot reproduce the bug with librsvg 2.40.2. Raphael, are you sure your Ristretto is crashing as a result of the attached SVG and not another one? Your strace indicates another SVG file is opened first, can you try to open this svg in a separate folder?

[Raphael Groner (projects-rg)]

(In reply to Steve Dodier-Lazaro from comment #14)
> I cannot reproduce the bug with librsvg 2.40.2. Raphael, are you sure your
> Ristretto is crashing as a result of the attached SVG and not another one?
> Your strace indicates another SVG file is opened first, can you try to open
> this svg in a separate folder?

Steve, thanks for your response. In the meantime, I switched to Fedora 20, cause F18 is EOL since ages... So I am not able to reproduce any more with both of he hereby referenced svg files: libreoffice and document-save-as.svg.

ristretto-0.6.3-4.fc20.x86_64
librsvg2-2.40.1-1.fc20.x86_64
cairo-1.13.1-0.1.git337ab1f.fc20.x86_64
gtk2-2.24.24-2.fc20.x86_64

About the path '/usr/share/icons/elementary/actions/24/document-save-as.svg' mentioned in the backtrace, I can see that Ristretto opens and tries to show all icons in the dedicated folder, maybe there was some faulty file those days, I can not say any detail.

=> WORKSFORME

[Steve Dodier-Lazaro (sidi)]

Raphael,

Great, that seems to narrow the bug down to librsvg 2.36, since the devs haven't pointed out any relevant commit from Ristretto 0.6.3-1 to 0.6.3-4. Marking as resolved.

[Theo Linkspfeifer (lastonestanding)]

This bug was fixed in librsvg.