Rhythmbox Context Pane Plugin lacks internationalization
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Rhythmbox |
Expired
|
Medium
|
|||
rhythmbox (Ubuntu) |
Triaged
|
Low
|
Ubuntu Desktop Bugs |
Bug Description
Binary package hint: rhythmbox
I'm using rhythmbox-plugins 0.12.6git201002
LastFM api allows developper to set the artist information language with the parameter "lang" in the url of function "artist.getInfo()".
See http://
Context Pane should get system language, and use it to define this parameter.
In the version 0.12.6git201002
A better behavior would be Context Pane falling back to english if the artist information is empty for the given system language.
(I tried to fix it myself, but I had never worked with Python before, and I don't know how Rhythmbox plugins code is organized, so I just made a temporary fix for french language. A real internationaliz
tags: | added: patch |
tags: |
added: patch-upstreaminput removed: patch |
Changed in rhythmbox: | |
importance: | Undecided → Unknown |
status: | New → Unknown |
Changed in rhythmbox (Ubuntu): | |
status: | Confirmed → Triaged |
tags: |
added: patch-forwarded-upstream removed: patch-upstreaminput |
Changed in rhythmbox: | |
importance: | Unknown → Medium |
status: | Unknown → New |
Changed in rhythmbox: | |
status: | New → Confirmed |
Changed in rhythmbox: | |
status: | Confirmed → Expired |
This is a quick and dirty fix in /usr/lib/ rhythmbox/ plugins/ context/ ArtistTab. py :
Added:
import locale //line 34
language_string = locale. setlocale( locale. LC_ALL, '') //line 231
language_alpha2 = language_string[:2] //line 232
Modified:
url = '%sartist. %s&artist= %s&lang= %s&api_ key=%s' % (LastFM.URL_PREFIX, value['function'], artist, language_alpha2, LastFM.API_KEY) //line 236