Rhythmbox Context Pane Plugin lacks internationalization

Bug #526845 reported by Loris Zinsou on 2010-02-24
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Rhythmbox
Expired
Medium
rhythmbox (Ubuntu)
Low
Ubuntu Desktop Bugs

Bug Description

Binary package hint: rhythmbox

I'm using rhythmbox-plugins 0.12.6git20100223-0ubuntu1 in Lucid Lynx.

LastFM api allows developper to set the artist information language with the parameter "lang" in the url of function "artist.getInfo()".
See http://www.lastfm.fr/api/show?service=267

Context Pane should get system language, and use it to define this parameter.
In the version 0.12.6git20100223-0ubuntu1, it only works with english language.

A better behavior would be Context Pane falling back to english if the artist information is empty for the given system language.

(I tried to fix it myself, but I had never worked with Python before, and I don't know how Rhythmbox plugins code is organized, so I just made a temporary fix for french language. A real internationalization would be great !)

Revision history for this message
Loris Zinsou (nepenthes) wrote :

This is a quick and dirty fix in /usr/lib/rhythmbox/plugins/context/ArtistTab.py :

Added:

import locale //line 34

language_string = locale.setlocale(locale.LC_ALL, '') //line 231
language_alpha2 = language_string[:2] //line 232

Modified:

url = '%sartist.%s&artist=%s&lang=%s&api_key=%s' % (LastFM.URL_PREFIX, value['function'], artist, language_alpha2, LastFM.API_KEY) //line 236

tags: added: patch
Revision history for this message
Sebastien Bacher (seb128) wrote :

Thank you for your bug report. The issue is an upstream one and it would be nice if somebody having it could send the bug the to the people writting the software (https://wiki.ubuntu.com/Bugs/Upstream/GNOME)

Changed in rhythmbox (Ubuntu):
assignee: nobody → Ubuntu Desktop Bugs (desktop-bugs)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Sebastien Bacher (seb128) wrote :

could you also add a patch rather than a source copy to the bug?

Revision history for this message
Loris Zinsou (nepenthes) wrote :

It's my first time fixing a bug here, so could you please explain me (or just give me a link to the documentation) how to add a real patch ?

Revision history for this message
Sebastien Bacher (seb128) wrote :

you can have a look to https://wiki.ubuntu.com/Bugs/HowToFix on the subject

Revision history for this message
Sebastien Bacher (seb128) wrote :

you can also simply use "diff -u upstream_source updated_source"

tags: added: patch-upstreaminput
removed: patch
Angel Abad (angelabad) on 2010-03-02
Changed in rhythmbox:
importance: Undecided → Unknown
status: New → Unknown
Changed in rhythmbox (Ubuntu):
status: Confirmed → Triaged
Nigel Babu (nigelbabu) on 2010-06-12
tags: added: patch-forwarded-upstream
removed: patch-upstreaminput
Changed in rhythmbox:
importance: Unknown → Medium
status: Unknown → New
Changed in rhythmbox:
status: New → Confirmed
Changed in rhythmbox:
status: Confirmed → Expired
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.