Shuffle starts with intersection of two playlists

[Charbonnier]

If one changes the playlist while shuffle mode is active rhythmbox starts playing with the intercept of both old and new playlist.

I expect to have a new random distribution of the musics not based on the previous playlist.

Observed on Trusty and previous releases.

I have a fix, will send it later.

[Charbonnier (charboma38)]

Here is my patch.

In shell/rb-play-order-shuffle.c:

The error comes from using rb_shuffle_entry_added after rb_shuffle_entry_removed since the first reverse modifications done by the latter.

I added a function that only adds entry without changing priv->entries_removed.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Sebastien Bacher (seb128)]

Thank you for taking the time to report this bug and helping to make Ubuntu better. The issue you are reporting is an upstream one and it would be nice if somebody having it could send the bug to the developers of the software by following the instructions at https://wiki.ubuntu.com/Bugs/Upstream/GNOME. If you have done so, please tell us the number of the upstream bug (or the link), so we can add a bugwatch that will inform us about its status. Thanks in advance.

[Charbonnier (charboma38)]

Hi!

In fact, the bug is present since ... well, 2006.

The bug number is 330686:
https://bugzilla.gnome.org/show_bug.cgi?id=330686

regards,

Matthieu Charbonnier.

2014-10-28 11:14 GMT+01:00 Sebastien Bacher <email address hidden>:

> Thank you for taking the time to report this bug and helping to make
> Ubuntu better. The issue you are reporting is an upstream one and it
> would be nice if somebody having it could send the bug to the developers
> of the software by following the instructions at
> https://wiki.ubuntu.com/Bugs/Upstream/GNOME. If you have done so, please
> tell us the number of the upstream bug (or the link), so we can add a
> bugwatch that will inform us about its status. Thanks in advance.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1363609
>
> Title:
> Shuffle starts with intersection of two playlists
>
> Status in “rhythmbox” package in Ubuntu:
> New
>
> Bug description:
> If one changes the playlist while shuffle mode is active rhythmbox
> starts playing with the intercept of both old and new playlist.
>
> I expect to have a new random distribution of the musics not based on
> the previous playlist.
>
> Observed on Trusty and previous releases.
>
> I have a fix, will send it later.
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/rhythmbox/+bug/1363609/+subscriptions
>

[Sebastien Bacher (seb128)]

That was fixed in https://git.gnome.org/browse/rhythmbox/commit/?id=6a2f690 and that commit is in the wily ubuntu version