should use keywords in its .desktop entry

Bug #1029964 reported by Sebastien Bacher on 2012-07-27
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Rhythmbox
Fix Released
Medium
rhythmbox (Ubuntu)
Wishlist
Unassigned
Precise
Wishlist
Unassigned

Bug Description

Impact:
It makes rhythmbox hard to find in the dash

Test Case:
Open the unity dash, type "CD" or "DAAP" or "Ipod", any of those should find rhythmbox

Regression potential:
rhythmbox will be listed as matching some new keywords, shouldn't create any issue

---

Those keywords are using by gnome-shell,unity for searches, having some like
"mp3", "DAAP", "CD" would probably make sense

totem example:
http://git.gnome.org/browse/totem/commit/?id=b730b1faf830900e58718503aff8b55f0aaddacb
"_Keywords=Video;Movie;Film;Clip;Series;Player;DVD;TV;Disc;"

One list for rhythmbox could be:

"_Keywords=mp3;Audio;CD;MTP;Podcast;DAAP;Playlist;Ipod;"

Changed in rhythmbox (Ubuntu):
importance: Undecided → Wishlist
status: New → Fix Committed
Changed in rhythmbox (Ubuntu Precise):
importance: Undecided → Wishlist
status: New → In Progress
description: updated
Changed in rhythmbox:
importance: Unknown → Medium
status: Unknown → New
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rhythmbox - 2.97-1ubuntu3

---------------
rhythmbox (2.97-1ubuntu3) quantal; urgency=low

  [ Sebastien Bacher ]
  * debian/patches/09_keywords.patch:
    - backport upstream patch to set keywords in the desktop entry,
      it makes easier to find totem in the unity dash or gnome-shell
      (lp: #1029964)

  [ Iain Lane ]
  * debian/*.prs, debian/patches/10_encoding_use_ubuntu_profiles.patch: Add an
    OGG and MP3 preset with improved defaults to use when encoding. Patch
    rhythmbox.gep to work with user-supplied custom settings (LP: #945987)
  * debian/patches/dont_free_consumed_floating_gvariant.patch: Take patch from
    upstream bug#680842 (by Ryan Lortie) to not crash when opening preferences
    dialog by trying to free an already consumed value. (LP: #1030295)
  * Add Breaks and Replaces on versions of transmageddon which shipped the
    .prs files we are now shipping in -data.
 -- Iain Lane <email address hidden> Mon, 30 Jul 2012 17:46:42 +0100

Changed in rhythmbox (Ubuntu):
status: Fix Committed → Fix Released
Chris Halse Rogers (raof) wrote :

As with totem update; this breaks string freeze.

Is there an assurance that these keywords are never shown in the UI?

Sebastien Bacher (seb128) wrote :

Does string freeze really apply to non visibile strings? Those are just keywords for dash searchability and no they are not displayed in any ui elemenet

Chris Halse Rogers (raof) wrote :

I was just checking that they really were never displayed in any UI element; they *are* marked as translatable.

Hello Sebastien, or anyone else affected,

Accepted rhythmbox into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/rhythmbox/2.96-0ubuntu4.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in rhythmbox (Ubuntu Precise):
status: In Progress → Fix Committed
tags: added: verification-needed
Sebastien Bacher (seb128) wrote :

Thanks for checking ;-)

> they *are* marked as translatable.

yes, so french people can type "navigateur" and find their "browser" ;-)

C de-Avillez (hggdh2) wrote :

Verified that without the update these keywords (Mp3;Audio;CD;MTP;Podcast;DAAP;Playlist;Ipod) do not work; after installing Rhythmbox (and associated coreqs) from -proposed, all keywords above show Rhythmbox as a possible application.

Tagged verification-done.

tags: added: verification-done
removed: verification-needed

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rhythmbox - 2.96-0ubuntu4.2

---------------
rhythmbox (2.96-0ubuntu4.2) precise-proposed; urgency=low

  * debian/*.prs, debian/patches/10_encoding_use_ubuntu_profiles.patch: Add an
    OGG and MP3 preset with improved defaults to use when encoding. Patch
    rhythmbox.gep to work with user-supplied custom settings (LP: #945987)
  * Add Breaks and Replaces on versions of transmageddon which shipped the
    .prs files we are now shipping in -data.

  [ Sebastien Bacher ]
  * debian/patches/09_keywords.patch:
    - backport upstream patch to set keywords in the desktop entry,
      it makes easier to find rhythmbox in the unity dash or gnome-shell
      (lp: #1029964)
 -- Iain Lane <email address hidden> Mon, 30 Jul 2012 18:03:50 +0100

Changed in rhythmbox (Ubuntu Precise):
status: Fix Committed → Fix Released
Changed in rhythmbox:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.