[MIR] rhythmbox-plugin-alternative-toolbar

Bug #1703662 reported by Sebastien Bacher on 2017-07-11
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
rhythmbox (Ubuntu)
Wishlist
Unassigned
rhythmbox-plugin-alternative-toolbar (Ubuntu)
Wishlist
Unassigned
ubuntu-settings (Ubuntu)
Wishlist
Unassigned

Bug Description

[Availability]

The package is a python plugin and of type arch all, it's building fine in artful
https://launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/0.17.3-1

[Rationale]

The plugin improves the look of rhythmbox and the desktop team believes it would be a welcome change to the default experience.

[Security]

The plugin only change UI layouts and has no known security report.

[Quality assurance]

The package is in sync with Debian and has no open bugs on the Debian BTS nor on launchpad. Upstream seems active though activity is rather low (but there are no open bugs or request so not a lot is needed)

[Dependencies]

The dependency are minimal and already in main

[Standards compliance]

The packaging is classic dh and using the current standards.

[Maintenance]

The package is well maintained upstream and in Debian, the Ubuntu Desktop team is going to keep an eye on it in Ubuntu though (desktop-bugs is subscribed)

[Background information]

The description summarize what the package is doing "Enhanced play controls and interface for Rhythmbox"

Changed in rhythmbox-plugin-alternative-toolbar (Ubuntu):
importance: Undecided → Wishlist
Sebastien Bacher (seb128) wrote :

Could somebody from the MIR team review this one? It shouldn't be a too difficult one...

I'm a bit concerned with the way this is packaged.

Why is it necessary to remove the LICENSE file, for instance? This is no the only source to ship one; it should probably remain and live with the rest of the documentation (such as with copyright). The right way to fix this would obviously be upstream, and since the upstream is also packaging for Debian and Ubuntu, this should be a simple fix.

There are also extra postinst, prerm files which I expect should not be needed. Again, this is not the first python package, isn't python3 already doing all that is necessary? Building the package should be done when the package is being built, not when it is installed or removed.

There is a relevant warning in the build logs:
E: dh_python3 dh_python3:173: no package to act on (python3-foo or one with ${python3:Depends} in Depends)

Finally, nothing currently Depends/Recommends rhythmbox-plugin-alternative-toolbar. This means it would not stay in main if promoted.

Please fix for the above. I see no other issues with this package.

Changed in rhythmbox-plugin-alternative-toolbar (Ubuntu):
status: New → Incomplete
Sebastien Bacher (seb128) wrote :

Thanks for the review Mathieu. I'm going to have a look at the packaging issue and come back once those are resolved

> Finally, nothing currently Depends/Recommends rhythmbox-plugin-alternative-toolbar. This means it would not stay in main if promoted.

right, I though we wanted the MIR approved first before adding a recommend but we can do it the other way around if that's preferred

Sebastien Bacher (seb128) wrote :

The review comments should be addressed in
https://launchpad.net/ubuntu/+source/rhythmbox-plugin-alternative-toolbar/0.17.4-1

The desktop-bugs team is subscribed to the package

Let me know if you want me to add the recommends to rhythmbox now or after the MIR is approved

Changed in rhythmbox-plugin-alternative-toolbar (Ubuntu):
status: Incomplete → New

Looks good to me, thanks! MIR approved.

Changed in rhythmbox-plugin-alternative-toolbar (Ubuntu):
status: New → Fix Committed
Sebastien Bacher (seb128) wrote :

Thanks, rhythmbox recommends it now so I guess we can close the bug

Changed in rhythmbox-plugin-alternative-toolbar (Ubuntu):
status: Fix Committed → Fix Released
Changed in rhythmbox (Ubuntu):
importance: Undecided → Wishlist
status: New → Fix Committed
Changed in ubuntu-settings (Ubuntu):
importance: Undecided → Wishlist
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-settings - 17.10.10

---------------
ubuntu-settings (17.10.10) artful; urgency=medium

  * debian/ubuntu-settings.gsettings-override:
    - enabled the rhythmbox alternative-toolbar plugin (lp: #1703662)

 -- Sebastien Bacher <email address hidden> Thu, 10 Aug 2017 17:40:11 +0200

Changed in ubuntu-settings (Ubuntu):
status: Fix Committed → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package rhythmbox - 3.4.1-2ubuntu5

---------------
rhythmbox (3.4.1-2ubuntu5) artful; urgency=medium

  * debian/control.in: typo fix from the previous upload

 -- Sebastien Bacher <email address hidden> Thu, 10 Aug 2017 23:33:53 +0200

Changed in rhythmbox (Ubuntu):
status: Fix Committed → Fix Released
Changed in rhythmbox-plugin-alternative-toolbar (Ubuntu):
status: Fix Released → Fix Committed
Matthias Klose (doko) on 2017-08-22
Changed in rhythmbox-plugin-alternative-toolbar (Ubuntu):
status: Fix Committed → New
Changed in rhythmbox-plugin-alternative-toolbar (Ubuntu):
status: New → Fix Committed
Matthias Klose (doko) wrote :

Override component to main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful: universe/misc -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful amd64: universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful arm64: universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful armhf: universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful i386: universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful ppc64el: universe/misc/optional/100% -> main
rhythmbox-plugin-alternative-toolbar 0.17.4-1 in artful s390x: universe/misc/optional/100% -> main
7 publications overridden.

Changed in rhythmbox-plugin-alternative-toolbar (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers