revelation can not "Open file on startup" when the filename contains (not-so) special characters

[Hristo Erinin]

When you select a file to be automatically opened on startup and that file contains anything but [a-Z/] revelation fails to open it.

The file name is stored in gconf in a <stringvalue> and special characters are URI encoded (" " = %20, "%" = %25, "+" = %2B, etc.). Later, when Revelation reads the filename from gconf it tries to open it without decoding the URI encoded string.

Two error messages are produced (the file is /home/ubuntu/test bug/passwords):
"The file '/home/ubuntu/test%20bug/passwords' could not be opened. Make sure that the file exists, and that you have permissions to open it."
and a traceback:
"Traceback (most recent call last):
  File "/usr/bin/revelation", line 1833, in <module>
    app.run()
  File "/usr/bin/revelation", line 1591, in run
    self.file_open(io.file_normpath(file))
  File "/usr/bin/revelation", line 1481, in file_open
    entrystore = self.__file_load(file, password)
  File "/usr/bin/revelation", line 1019, in __file_load
    return result
UnboundLocalError: local variable 'result' referenced before assignment"

In Debian this bug is fixed in 0.4.11-5 and the bug is #518085 (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=518085). In that bug report there is a 2 line patch that fixes the problem by adding urllib.unquote to the processing of the filename.

Please apply that patch to the Ubuntu package as well.

ProblemType: Bug
DistroRelease: Ubuntu 14.04
Package: revelation 0.4.14-2
ProcVersionSignature: Ubuntu 3.13.0-24.46-generic 3.13.9
Uname: Linux 3.13.0-24-generic x86_64
ApportVersion: 2.14.1-0ubuntu2
Architecture: amd64
CurrentDesktop: Unity
Date: Thu Apr 24 02:13:54 2014
InstallationDate: Installed on 2013-12-19 (125 days ago)
InstallationMedia: Ubuntu 13.10 "Saucy Salamander" - Release amd64 (20131016.1)
SourcePackage: revelation
UpgradeStatus: Upgraded to trusty on 2014-04-03 (20 days ago)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "A patch proposed by Bart Veldstra in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=518085#19" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]