Remmina crashes after RDP connection

[David Boman]

* Impact

When connecting with RDP Remmina crashes. It's due to an invalid API use in remmina and stricter checking in the most recent freerdp3 version which makes it error out now.

* Test case

Try to connect to a RDP server using remmina, it shouldn't crash

* Regression potential

The change is fixing an incorrect API use in the RDP plugin around color check, if there is an issue it will be in the RDP support, probably around colors handling

--------------------------

Syslog show the following:

2024-04-18T13:49:02.969819+02:00 localhost dbus-daemon[3214]: [session uid=1001 pid=3214] Successfully activated service 'org.gnome.seahorse.Application'
2024-04-18T13:49:03.655883+02:00 localhost systemd[3176]: Started app-gnome-org.remmina.Remmina-53436.scope - Application launched by gnome-shell.
2024-04-18T13:49:03.656884+02:00 localhost remmina[53441]: Remmina does not log all output statements. Turn on more verbose output by using "G_MESSAGES_DEBUG=remmina" as an environment variable.#012More info available on the Remmina wiki at:#012https://gitlab.com/Remmina/Remmina/-/wikis/Usage/Remmina-debugging
2024-04-18T13:49:03.766401+02:00 localhost remmina[53441]: gtk_menu_attach_to_widget(): menu already attached to GtkMenuItem
2024-04-18T13:49:13.851397+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [ERROR][com.freerdp.common.settings] - [freerdp_settings_get_bool]: Invalid key index 0 [FreeRDP_instance|FREERDP_SETTINGS_TYPE_POINTER]
2024-04-18T13:49:13.851716+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_int_assert]: FALSE [obj-x86_64-linux-gnu/libfreerdp/CMakeFiles/freerdp.dir/compiler_depend.ts:freerdp_settings_get_bool:637]
2024-04-18T13:49:13.851760+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 0: dli_fname=/lib/x86_64-linux-gnu/libwinpr3.so.3 [0x70e694e2b000], dli_sname=winpr_backtrace [0x70e694e97660]
2024-04-18T13:49:13.851791+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 1: dli_fname=/lib/x86_64-linux-gnu/libwinpr3.so.3 [0x70e694e2b000], dli_sname=winpr_log_backtrace_ex [0x70e694e9f150]
2024-04-18T13:49:13.851803+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 2: dli_fname=/lib/x86_64-linux-gnu/libfreerdp3.so.3 [0x70e694200000], dli_sname=(null) [(nil)]
2024-04-18T13:49:13.851815+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 3: dli_fname=/lib/x86_64-linux-gnu/libfreerdp3.so.3 [0x70e694200000], dli_sname=freerdp_settings_get_bool [0x70e6942658a0]
2024-04-18T13:49:13.851827+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 4: dli_fname=/usr/lib/x86_64-linux-gnu/remmina/plugins/remmina-plugin-rdp.so [0x70e6958dd000], dli_sname=(null) [(nil)]
2024-04-18T13:49:13.851839+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 5: dli_fname=/usr/lib/x86_64-linux-gnu/remmina/plugins/remmina-plugin-rdp.so [0x70e6958dd000], dli_sname=(null) [(nil)]
2024-04-18T13:49:13.851851+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 6: dli_fname=/usr/bin/../lib/x86_64-linux-gnu/libc.so.6 [0x70e699400000], dli_sname=(null) [(nil)]
2024-04-18T13:49:13.851873+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 7: dli_fname=/usr/bin/../lib/x86_64-linux-gnu/libc.so.6 [0x70e699400000], dli_sname=(null) [(nil)]
2024-04-18T13:49:13.851885+02:00 localhost org.remmina.Remmina.desktop[53441]: [13:49:13:572] [53441:0000d116] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 8: unresolvable, address=(nil)
2024-04-18T13:49:14.938231+02:00 localhost org.remmina.Remmina.desktop[53436]: /usr/bin/remmina-file-wrapper: line 37: 53441 Aborted (core dumped) "$REMMINA" "${@}"

ProblemType: Bug
DistroRelease: Ubuntu 24.04
Package: remmina 1.4.35+dfsg-0ubuntu4
ProcVersionSignature: Ubuntu 6.8.0-22.22-generic 6.8.1
Uname: Linux 6.8.0-22-generic x86_64
NonfreeKernelModules: nvidia_modeset nvidia
ApportVersion: 2.28.0-0ubuntu1
Architecture: amd64
CasperMD5CheckResult: pass
CloudArchitecture: x86_64
CloudID: none
CloudName: none
CloudPlatform: none
CloudSubPlatform: config
Date: Thu Apr 18 13:59:31 2024
InstallationDate: Installed on 2022-05-21 (698 days ago)
InstallationMedia: Ubuntu-Server 22.04 LTS "Jammy Jellyfish" - Release amd64 (20220421)
RebootRequiredPkgs: Error: path contained symlinks.
SourcePackage: remmina
UpgradeStatus: Upgraded to noble on 2024-04-17 (1 days ago)

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[joepadmiraal (joep-groovytunes)]

For me it seems to crash at the same point.
[15:46:32:936] [295376:00048252] [FATAL][com.freerdp.winpr.assert] - [winpr_log_backtrace_ex]: 8: unresolvable, address=(nil)
[1] 295376 IOT instruction (core dumped) remmina

This is from a connection to a Windows 10 machine that is up and running and the same connection used to work before I upgraded from Ubuntu 23.10 to 24:04.
remmina version: org.remmina.Remmina - 1.4.35 (git n/a)

I attached the core dump.

[Jakub Klos (9v-ka2ub-3y)]

The issue has been already fixed in Remmina:
https://gitlab.com/Remmina/Remmina/-/issues/3090

Now, the question is how long to get into Ubuntu's 24.04 packages

Supposedly, you can use the flatpak version or downgrade remmina

[Hiroyuki Tanaka (myheroyuki)]

Here's the patch that fixed it upstream. Hopefully this can be applied to the Ubuntu package.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "crash_patch.patch" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[mtech (mgordhandas)]

facing the same issue

[Daniel Ramirez Brescia (dramirez9814)]

I was able to make remnina works using the snap version. If anyone wants to import all of its conections can do it moving the files here: ~/snap/remmina/current/.local/share/remmina/

[Hiroyuki Tanaka (myheroyuki)]

In addition, a version of Remmina with the fix applied can be installed using the project's remmina-next PPA, found here:

https://launchpad.net/~remmina-ppa-team/+archive/ubuntu/remmina-next

A flatpak version exists as well.

[Alan Baghumian (alanbach)]

I just rebuilt and installed fresh packages on Noble using the supplied patch above and all good now!

[Sebastien Bacher (seb128)]

I've uploaded the fix for SRU, it's waiting in the review queue now