Redmine Javascript Modal Dialog Not Appear

[Katsuya Nagai]

Hi Maintainers,

I'm Katsuya, an old engineer in Japan.
Excuse me my poor English.

At assign members on the projects or assign projects on user,
the modal dialog made by "Rendered members/new.js.erb" is not appear in my browsers
which are Chrome 75 and Internet Explorer 11,
but new tab made by "Rendered members/new.html.erb" work right.

Due to Chrome's developers mode, zIndex in the "application.js" is not function.
I modify the "application.js" as attached file, it seems to work right.

But "Close" text on the close button in the modal dialog,
I can't resolve it.

Regards,

ProblemType: Bug
DistroRelease: Ubuntu 19.04
Package: redmine 4.0.1-2 [modified: usr/share/redmine/public/javascripts/application.js]
ProcVersionSignature: Ubuntu 5.0.0-21.22-generic 5.0.15
Uname: Linux 5.0.0-21-generic x86_64
ApportVersion: 2.20.10-0ubuntu27.1
Architecture: amd64
CurrentDesktop: ubuntu:GNOME
Date: Tue Jul 30 21:03:49 2019
InstallationDate: Installed on 2018-05-04 (451 days ago)
InstallationMedia: Ubuntu 17.10 "Artful Aardvark" - Release amd64(20180108.1)
PackageArchitecture: all
ProcEnviron:
 TERM=xterm-256color
 PATH=(custom, no user)
 XDG_RUNTIME_DIR=<set>
 LANG=ja_JP.UTF-8
 SHELL=/bin/bash
SourcePackage: redmine
UpgradeStatus: Upgraded to disco on 2019-04-25 (95 days ago)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "application.js.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

[Katsuya Nagai (katsuya1128)]

It is a patch file, but it is quite the solution as ad hoc.
You can ignore the patch file.

[Go MAEDA (vividtone)]

Hello, I am one of the committers of Redmine.

The root cause of this issue is that the Redmine package in Ubuntu does not use jquery-ui bundled with Redmine.

But I have applied the same patch to the upstream repo. You can fix the problem if you update the package using https://svn.redmine.org/redmine/branches/4.0-stable/.

Related issues:
https://www.redmine.org/issues/31870
https://www.redmine.org/issues/31708

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Katsuya Nagai (katsuya1128)]

I found "Close" text on modal dialog on close button on Ubuntu 20.04 also.

Redmine package uses distributed jQuery library (libjs-jquery package) but uses Redmine's local jQuery-UI library files.
The difference of version causes some trouble.

1. Should be change is link for distributed package

  usr/share/javascript/jquery-ui/ui -> usr/share/redmine/public/javascripts/jquery-ui
  usr/share/javascript/jquery-ui/themes/base -> usr/share/redmine/public/stylesheets/jquery

But this link maybe remove libjs-jquery-ui's files in overwrite update....

2. To use distributed package.

---------------------- app/helpers/application_helper.rb ----------------------
index 22d178c..94b3708 100644
@@ -1391,7 +1391,7 @@ module ApplicationHelper
                      "beforeShow: beforeShowDatePicker};")
         jquery_locale = l('jquery.locale', :default => current_language.to_s)
         unless jquery_locale == 'en'
- tags << javascript_include_tag("i18n/datepicker-#{jquery_locale}.js")
+ tags << javascript_include_tag("jquery-ui/i18n/datepicker-#{jquery_locale}.js")
         end
         tags
       end

----------------------- app/views/layouts/base.html.erb -----------------------
index 48ba562..d3e1944 100644
@@ -9,7 +9,7 @@
 <meta name="keywords" content="issue,bug,tracker" />
 <%= csrf_meta_tag %>
 <%= favicon %>
-<%= stylesheet_link_tag 'jquery/jquery-ui-1.11.0', 'application', 'responsive', :media => 'all' %>
+<%= stylesheet_link_tag 'jquery/jquery-ui', 'application', 'responsive', :media => 'all' %>
 <%= stylesheet_link_tag 'rtl', :media => 'all' if l(:direction) == 'rtl' %>
 <%= javascript_heads %>
 <%= heads_for_theme %>

3. Some local files likes public/javascripts/i18n, public/stylesheets/jquery/* already do not use.

4. Redmine local raphael.js also does not need due to use distributed one.

[Katsuya Nagai (katsuya1128)]

> But this link maybe remove libjs-jquery-ui's files in overwrite update....

It was wrong.

Debian package can not write over directory with symbolic link,
Only writing symlinks into debian/links, it should be failed in over write installation.