syntax highlighting is broken using coderay

Bug #1088440 reported by Claudio Bley
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
redmine (Ubuntu)
Confirmed
Undecided
Unassigned

Bug Description

The coderay syntax highlighting library redmine is using changed the HTML output of short-form CSS class names (like pp) to longer names (like preprocessor) a year ago.

Redmine changed their names also, but the package of ruby-coderay which is currently used by redmine still uses the old names.

This breaks syntax highlighting in redmine, ubuntu 12.04 LTS.

https://github.com/rubychan/coderay/commit/36531238fa4ef33f1792c6ea6de5e00dcadf018a

Tags: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in redmine (Ubuntu):
status: New → Confirmed
Revision history for this message
X Xiao (austinxxh-linux) wrote :

Anyone progress on this fix?

Revision history for this message
Claudio Bley (cbley) wrote :

Here's a patch which adds back the old CSS rules, leaving the (new) long CSS names intact.

I extracted those rules from some old version out of the repository. HTH.

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "redmine_scm_old_names.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
Revision history for this message
X Xiao (austinxxh-linux) wrote :

the above diff patch did not work for me, still the git repo code review has no syntax highlighting...

Revision history for this message
Brad Jones (brad-jones) wrote :

I can confirm the patch in #3 fixes the highlighting. The patch doesn't directly apply (you need to tell it which file to patch since scm.css.orig doesn't exist on your system) but it does fix the problem. It's not a definitive fix from upstream, but it does get you to the intended display.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.