Ubuntu

RecordItNow doesn't stop record since Oneiric (patch available)

Reported by nabrown on 2011-09-25
82
This bug affects 18 people
Affects Status Importance Assigned to Milestone
recorditnow (Ubuntu)
Undecided
Unassigned

Bug Description

On 2 machines with fresh installs of kubuntu 11.10, recorditnow seems to work with ffmpeg option but stop button does nothing and recording continues. File is created correctly in tmp folder when ffmpeg killed from the command line.

Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in recorditnow (Ubuntu):
status: New → Confirmed
Alex10336 (ap10336) wrote :

Same for me. upgraded from natty when oneiric go in "rc" state (between beta2 and final)

deymosmathphy (deymosmathphy) wrote :

Same for me after fresh installation 11.10!

ffmpeg does not stop on "q"
Here is how recorditnow tries to stop ffmpeg:

void FfmpegRecorder::stop()
{
    if (m_recorder) {
        m_recorder->write("q\n");
        m_paused = false;
    }
}

Starting ffmpeg on a commanline, it does not recognize "q" as a signal to stop, only ctrl-c works

Fenix-TX (jesusvpct) wrote :

I think that this is the change that is needed on src/plugins/recorder/ffmpegrecorder/ffmpegrecorder.cpp file

191c191
< kill(m_recorder->pid(), SIGINT);
---
> m_recorder->write("q\n");

Alex10336 (ap10336) wrote :

Don't work, I all-ready tested this. He report has "The recorder has crashed!"

Maybe from (line 315 src/plugins/recorder/ffmpegrecorder/ffmpegrecorder.cpp):
    if (status == KProcess::CrashExit || ret != 0) {
        clean();
        emit finished(Crash);
        return;
    }

Tested too and not work (I'm not c++ programmer, but can compile it):
        char ctrlC = 0x03;
        m_recorder->write( &ctrlC );
and
        m_recorder->write("^c");

Alex10336 (ap10336) wrote :

Fix found. see .diff attached.

I force ffmpeg to stop. and inform recorder to ignore forcing.

(french sorry if u don't understand)

The attachment "recorditnowfix858973.diff" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
Alex10336 (ap10336) wrote :

I have made own 'test' ppa with this fix included. My first ppa, seems to work correctly.

 → https://launchpad.net/~ap10336/+archive/ppa

#sudo add-apt-repository ppa:ap10336/ppa

summary: - recorditnow doesn't stop 11.10
+ RecordItNow doesn't stop record since Oneiric (patch available)
Ray-Ven (ray-ven) wrote :

persists in saucy

Alex10336 (ap10336) wrote :

porting raring fixed build to saucy https://launchpad.net/~ap10336/+archive/test

You can try it when build done.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers