RecordItNow doesn't stop record since Oneiric (patch available)

[nabrown]

On 2 machines with fresh installs of kubuntu 11.10, recorditnow seems to work with ffmpeg option but stop button does nothing and recording continues. File is created correctly in tmp folder when ffmpeg killed from the command line.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Alex10336 (ap10336)]

Same for me. upgraded from natty when oneiric go in "rc" state (between beta2 and final)

[deymosmathphy (deymosmathphy)]

Same for me after fresh installation 11.10!

[Andreas Blochberger (andreas-blochberger)]

ffmpeg does not stop on "q"
Here is how recorditnow tries to stop ffmpeg:

void FfmpegRecorder::stop()
{
    if (m_recorder) {
        m_recorder->write("q\n");
        m_paused = false;
    }
}

Starting ffmpeg on a commanline, it does not recognize "q" as a signal to stop, only ctrl-c works

[Andreas Blochberger (andreas-blochberger)]

"q" to quit was removed from ffmpeg with this commit: http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=8fb566fdf839206584b1dec7da2eb9c9540108fa

[Fenix-TX (jesusvpct)]

I think that this is the change that is needed on src/plugins/recorder/ffmpegrecorder/ffmpegrecorder.cpp file

191c191
< kill(m_recorder->pid(), SIGINT);
---
> m_recorder->write("q\n");

[Alex10336 (ap10336)]

Don't work, I all-ready tested this. He report has "The recorder has crashed!"

Maybe from (line 315 src/plugins/recorder/ffmpegrecorder/ffmpegrecorder.cpp):
    if (status == KProcess::CrashExit || ret != 0) {
        clean();
        emit finished(Crash);
        return;
    }

Tested too and not work (I'm not c++ programmer, but can compile it):
        char ctrlC = 0x03;
        m_recorder->write( &ctrlC );
and
        m_recorder->write("^c");

[Alex10336 (ap10336)]

Fix found. see .diff attached.

I force ffmpeg to stop. and inform recorder to ignore forcing.

(french sorry if u don't understand)

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "recorditnowfix858973.diff" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-sponsors please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

[RussianNeuroMancer (russianneuromancer)]

Deb by Alex10336 with applied patch: http://www.mediafire.com/?2imujbtzey9p85o

[Alex10336 (ap10336)]

I have made own 'test' ppa with this fix included. My first ppa, seems to work correctly.

 → https://launchpad.net/~ap10336/+archive/ppa

#sudo add-apt-repository ppa:ap10336/ppa

[Ray-Ven (ray-ven)]

persists in saucy

[Alex10336 (ap10336)]

porting raring fixed build to saucy https://launchpad.net/~ap10336/+archive/test

You can try it when build done.