radeontop version is "unknown"

[Daniel Tang]

radeontop's version in missing. This is a packaging problem as the version is there when I build from my own Git branch.

$ lsb_release -rd
Description: Ubuntu Kinetic Kudu (development branch)
Release: 22.10

$ apt-cache policy radeontop
radeontop:
  Installed: 1.4-1
  Candidate: 1.4-1
  Version table:
 *** 1.4-1 500
        500 https://gpl.savoirfairelinux.net/pub/mirrors/ubuntu kinetic/universe amd64 Packages
        100 /var/lib/dpkg/status

# Expected behavior

$ ./radeontop -v
RadeonTop v1.4-6-g258162f

# Actual behavior

$ radeontop -v
RadeonTop unknown

As well, the version shown when actually running it is also "unknown".
---
ProblemType: Bug
ApportVersion: 2.23.0-0ubuntu2
Architecture: amd64
CasperMD5CheckResult: unknown
CurrentDesktop: KDE
DistroRelease: Ubuntu 22.10
Package: radeontop 1.4-1
PackageArchitecture: amd64
ProcVersionSignature: Ubuntu 5.19.0-18.18-generic 5.19.7
Tags: kinetic
Uname: Linux 5.19.0-18-generic x86_64
UpgradeStatus: Upgraded to kinetic on 2022-09-29 (9 days ago)
UserGroups: dialout docker kvm libvirt libvirtd lpadmin lxd plugdev sudo systemd-journal video wireshark
_MarkForUpload: True

[Daniel Tang (daniel-z-tg)]

apport information

[Daniel Tang (daniel-z-tg)]

apport information

[Daniel Tang (daniel-z-tg)]

apport information

[John Paul Adrian Glaubitz (glaubitz)]

»radeontop's version in missing. This is a packaging problem as the version is there when I build from my own Git branch.«

It's not a packaging problem, it's an upstream bug:

The version number is set through the script "getver.sh" which is part of the upstream source tree [1]. Since this script exclusively relies on git to determine the version number and the Debian package is built from the distributed tarball which does not contain any git repository information, there is no way for "getver.sh" to determine the version information from the distributed tarball source.

In order to fix this problem, the upstream developers need to modify the Makefile to generate the version information and write it into "getver.sh" anytime "make dist" is called.

Please report this bug upstream, it's not a packaging bug. Also, the original package is maintained in Debian, not Ubuntu which is why it took a bit longer until me (the package maintainer) saw this bug report.

> [1] https://github.com/clbr/radeontop/blob/master/getver.sh

[Daniel Tang (daniel-z-tg)]

Reported upstream at https://github.com/clbr/radeontop/issues/150