Comment 0 for bug 1982000

Revision history for this message
Andrea Righi (arighi) wrote :

[Impact]

r8168 dkms fails to build on the latest 5.19 kernel with the following error:

/var/lib/dkms/r8168/8.050.03/build/r8168_n.c: In function ‘rtl8168_init_one’:
/var/lib/dkms/r8168/8.050.03/build/r8168_n.c:26907:25: error: implicit declaration of function ‘netif_set_gso_max_size’; did you mean ‘netif_set_tso_max_size’? [-Werror=implicit-function-declaration]
26907 | netif_set_gso_max_size(dev, LSO_32K);
      | ^~~~~~~~~~~~~~~~~~~~~~
      | netif_set_tso_max_size

[Test case]

$ sudo apt install r816-dkms

[Fix]

Make netif_set_gso_max_size() available again to external modules (as a static inline func).

[Regression potential]

We may see regressions in this driver with kernels >= 5.18.