Proxy tests failing in the autopkgtest environment

[Lucas Kanashiro]

Failures:

  1) R10K::Settings global settings proxy setting a default value respects the HTTP_PROXY environment variable
     Failure/Error: expect(output[:proxy]).to eq("http://proxy.value/#{env_var}")

       expected: "http://proxy.value/HTTP_PROXY"
            got: "http://squid.internal:3128"

       (compared using ==)
     # ./spec/unit/settings_spec.rb:237:in `block (7 levels) in <top (required)>'
     # ./spec/unit/settings_spec.rb:235:in `block (6 levels) in <top (required)>'

  2) R10K::Settings global settings proxy setting a default value respects the http_proxy environment variable
     Failure/Error: expect(output[:proxy]).to eq("http://proxy.value/#{env_var}")

       expected: "http://proxy.value/http_proxy"
            got: "http://squid.internal:3128"

       (compared using ==)
     # ./spec/unit/settings_spec.rb:237:in `block (7 levels) in <top (required)>'
     # ./spec/unit/settings_spec.rb:235:in `block (6 levels) in <top (required)>'

Those tests are failing because the Ubuntu autopkgtest infrastructure uses the same variables the tests are trying to update. They should be skipped when executed under those circumstances.

[Lucas Kanashiro (lucaskanashiro)]

The attached debdiff fixes this issue.

[Lucas Kanashiro (lucaskanashiro)]

I uploaded the proposed debdiff to this PPA:

https://launchpad.net/~lucaskanashiro/+archive/ubuntu/testing

And triggered the test to make sure everything is all right:

https://autopkgtest.ubuntu.com/results/autopkgtest-impish-lucaskanashiro-testing/impish/amd64/r/r10k/20210816_185721_f8e52@/log.gz

[Athos Ribeiro (athos-ribeiro)]

Thanks, Lucas! LGTM

At first I thought this change could be forwarded upstream if instead of verifying the AUTOPKGTEST_TMP env variable we verified the env variables were not defined before overriding them.

Then I realized that the functions used to do so are indeed running in a somewhat contained scope: https://github.com/puppetlabs/r10k/blob/main/lib/r10k/util/exec_env.rb#L27. It seems that the autopkgtest infrastructure will (thankfully) not allow overrides to the proxy settings.

[Lucas Kanashiro (lucaskanashiro)]

Thanks for the review Athos! I am going to upload the package.

[Launchpad Janitor (janitor)]

This bug was fixed in the package r10k - 3.7.0-2ubuntu1

---------------
r10k (3.7.0-2ubuntu1) impish; urgency=medium

  * d/p/20_disable_test_changing_proxy_settings: skip tests trying to change
    the proxy settings, they are failing in the Ubuntu autopkgtest
    infrastructure (LP: #1940104).

 -- Lucas Kanashiro <email address hidden> Mon, 16 Aug 2021 11:49:31 -0300